Message ID | be1a2495-1c46-cda1-4f89-7e3a39d939db@gmail.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | fs/ntfs3: fix wrong cast in xattr.c | expand |
On 15.11.2022 12:17, Daniel Pinto wrote: > cpu_to_be32 and be32_to_cpu respectively return and receive > __be32, change the cast to the correct types. > > Fixes the following sparse warnings: > fs/ntfs3/xattr.c:811:48: sparse: sparse: incorrect type in > assignment (different base types) > fs/ntfs3/xattr.c:901:34: sparse: sparse: cast to restricted __be32 > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Daniel Pinto <danielpinto52@gmail.com> > --- > fs/ntfs3/xattr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c > index 8620a7b4b3e6..6056ecbe8e4f 100644 > --- a/fs/ntfs3/xattr.c > +++ b/fs/ntfs3/xattr.c > @@ -808,7 +808,7 @@ static int ntfs_getxattr(const struct xattr_handler *handler, struct dentry *de, > err = sizeof(u32); > *(u32 *)buffer = le32_to_cpu(ni->std_fa); > if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE)) > - *(u32 *)buffer = cpu_to_be32(*(u32 *)buffer); > + *(__be32 *)buffer = cpu_to_be32(*(u32 *)buffer); > } > goto out; > } > @@ -898,7 +898,7 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler, > if (size != sizeof(u32)) > goto out; > if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE)) > - new_fa = cpu_to_le32(be32_to_cpu(*(u32 *)value)); > + new_fa = cpu_to_le32(be32_to_cpu(*(__be32 *)value)); > else > new_fa = cpu_to_le32(*(u32 *)value); Thank you for your work, applied!
diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c index 8620a7b4b3e6..6056ecbe8e4f 100644 --- a/fs/ntfs3/xattr.c +++ b/fs/ntfs3/xattr.c @@ -808,7 +808,7 @@ static int ntfs_getxattr(const struct xattr_handler *handler, struct dentry *de, err = sizeof(u32); *(u32 *)buffer = le32_to_cpu(ni->std_fa); if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE)) - *(u32 *)buffer = cpu_to_be32(*(u32 *)buffer); + *(__be32 *)buffer = cpu_to_be32(*(u32 *)buffer); } goto out; } @@ -898,7 +898,7 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler, if (size != sizeof(u32)) goto out; if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE)) - new_fa = cpu_to_le32(be32_to_cpu(*(u32 *)value)); + new_fa = cpu_to_le32(be32_to_cpu(*(__be32 *)value)); else new_fa = cpu_to_le32(*(u32 *)value);
cpu_to_be32 and be32_to_cpu respectively return and receive __be32, change the cast to the correct types. Fixes the following sparse warnings: fs/ntfs3/xattr.c:811:48: sparse: sparse: incorrect type in assignment (different base types) fs/ntfs3/xattr.c:901:34: sparse: sparse: cast to restricted __be32 Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Daniel Pinto <danielpinto52@gmail.com> --- fs/ntfs3/xattr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)