From patchwork Sat Apr 15 09:08:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Stoakes X-Patchwork-Id: 13212339 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63A5C7619A for ; Sat, 15 Apr 2023 09:08:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 570966B0072; Sat, 15 Apr 2023 05:08:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5204F6B0078; Sat, 15 Apr 2023 05:08:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E7FD6B007B; Sat, 15 Apr 2023 05:08:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2FE0B6B0072 for ; Sat, 15 Apr 2023 05:08:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 00C3D1401D8 for ; Sat, 15 Apr 2023 09:08:37 +0000 (UTC) X-FDA: 80683049916.25.41BAECC Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf30.hostedemail.com (Postfix) with ESMTP id 21E0880005 for ; Sat, 15 Apr 2023 09:08:35 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=aaBU96Ki; spf=pass (imf30.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681549716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J+LSahXs7vXHVGQn1uT2igLaiQzqbh9LfXfVKe7mEnQ=; b=mxFVa4BWsmzk4H3b7rV5uhBQUP1mqsEEjJ+HZ9Pgus2XWcvwF1uKyPFARbBOGxlqCCJgi1 ddiJBkVDTOqTRR0YrT44jQ1n/Pxpzh0KxGahNrIRc2PM39XPjStAoX+ZjxJ/iinNLczomb 800q9Q6nSRzcsvov7VqJEyFB+S4F2gs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=aaBU96Ki; spf=pass (imf30.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681549716; a=rsa-sha256; cv=none; b=MDVtsBj5zrinIrwn4BW4ZCh0r3MxGgwNs+iSv6r8jkj+XUh/XE5f+/dxoO9atH2EuwzJta 1f4Mzh4JQjMIsJUJoimSfNCBPAFbiVBsdD5Sa9e3QzN6O4Up+/GAWf29OY1gp2oCh8c5/N Kwrf+0/l9ViO2SwtHbL8+cEonxuRL9k= Received: by mail-wm1-f50.google.com with SMTP id v10so4829172wmn.5 for ; Sat, 15 Apr 2023 02:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681549714; x=1684141714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J+LSahXs7vXHVGQn1uT2igLaiQzqbh9LfXfVKe7mEnQ=; b=aaBU96KigAuWjJFM596TLA0njsd4CcaEKGbQ3wHULm3FUlHtgzTCyGDhowFPT++iSW MSDxV70HUFBewCPLHdXGdlAdNSFZ2QHM4BuZOWLhabEOa8OpeehQN57s3BUDDoK9spkH t/mC67DAUUPnUuCCmjpDHqOJqjNQHzchn32p+RLHbm5+G7bJCo/+D0U1ld+EKsUxpDJa o7ONzkpaOxHVYQ3KPloV+uHoEgKwIYqbmEdFiaDoeHgpPNWMEIHsijRd5LrD6JizDysX 5fIbBUnSZCIIAaDbh76y0cBT0g5/VD/RlillTzQSP9llXM+nuh/teQkLE5uP1eqzvY9B FB2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681549714; x=1684141714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J+LSahXs7vXHVGQn1uT2igLaiQzqbh9LfXfVKe7mEnQ=; b=LCO78DH0rA4bzkuyse/Vj5fl1NqsTWglmZMRck+LUs33jG7ON7p0X58Cclb7tapVJA 67KNQm2g9bjJcnibvQrJaX1DCLFYUDYtMeOAL0ozHHb6CIA2e9S9Y8T48K4TNPoNpCnm dBch0Cy6/OJurkWsDQI/eWPK3/5SFiVPCZ2ZjNWu7xyCjs7R5dPQwrUteNQB76O5pE9A 54G4sRG8k9vdZ1nSl2uyVKiV3pD2SHE5ZjWLelH0xXpINd3Bgp77RSDdjyteIoBOR0TZ 7YkapAbNyF3eMubXehEzRiPAOVfMyJApW2CXxJZCpDxOfwol6WcPJxlvpPIBBkNiyPcy 9wqA== X-Gm-Message-State: AAQBX9fu7Y+zKAfhQvLqWQKX2K23VLK2ZY6godJ+asmSXUf84CJPiBmW 9oSb0INEDGNRf9x2hq/oPBQUOFjSSQ+HFQ== X-Google-Smtp-Source: AKy350Z6MMpxVfEBhLeercWBNyCumV7NKYzKXFdNExcPGCyibd1J697CX7f/NrQ0Ho74DWqlh8A3kg== X-Received: by 2002:a7b:ce8c:0:b0:3f0:b194:4912 with SMTP id q12-20020a7bce8c000000b003f0b1944912mr3243201wmj.19.1681549714401; Sat, 15 Apr 2023 02:08:34 -0700 (PDT) Received: from lucifer.home ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.googlemail.com with ESMTPSA id g8-20020a05600c310800b003eddc6aa5fasm9876591wmo.39.2023.04.15.02.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 02:08:33 -0700 (PDT) From: Lorenzo Stoakes To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , iommu@lists.linux.dev Cc: Matthew Wilcox , David Hildenbrand , kvm@vger.kernel.org, Jason Gunthorpe , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Alex Williamson , Lorenzo Stoakes Subject: [PATCH v2 2/7] mm/gup: remove unused vmas parameter from pin_user_pages_remote() Date: Sat, 15 Apr 2023 10:08:30 +0100 Message-Id: X-Mailer: git-send-email 2.40.0 In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 1se8oqxhfjkhxykmqsgdcyz1tf8ftyni X-Rspamd-Queue-Id: 21E0880005 X-HE-Tag: 1681549715-396235 X-HE-Meta: U2FsdGVkX1/AeindNgNAnOqkO+ff54VOQcGMEJr3S/UC3WqtuHWAsV3iDn8vPeR7nbX07evqME5eLlRUaQceqvI+JReqJySKScGHZpXkMm4+QdazYX8aR5dgvfyIC9p89MEPiqxAqvVTfjTyEqHeT9ZjAESzn4RIT13IN/ePYJOe83QMD2M62PTsJH3ORg/WKPquoPb9uJrTHRnko7tKeNpefIMlF1z7FhI5eKRDaqgv/7XVIUhD1C78Y5anjHheNW6rsZhu8TlAKXPg4BCbTg8iTmyrexS45nF2BLsUAWtn9wkYlMvk/LzyurTJuFzxangTVxCriiycq6/0ekbLwlElwEztOE1muHk+nDYLOW5DNFpCPy8BgO7IwAOEpaNC1e0FpjmcoYjPEG3ZLPyNvrqsyisxV4sh4Tv9I3VCFkBVeYndOJ4i8YyPPqSX+56+LoRMpgtbfzFlZQs+wuGt7bY3Vc3ST2yUITkLxaKV2ON1Kp9/isL8CHqrrIRlI7Vk8p4QlmgxFdBg2SO4SE6It6jJgN4Dad6QCIiA7AnlqIjmEjbNkAGpbdXpgBFSILlbP9hLG8zaLYHtAMANmzM2hqFEuCFOmXCIqAnmRthFhey02dC7fjSiJvAA9D/2uX5PaLLpIjVYt9ODSENjbBJ89P/0C8/KUT3GCQoTewaucqYia9NN/6Utzqks0m/s4rpY2M9hU2ER0uP9YTvADFThnAS/HYiyOMd0Tj5cw+0vQNQQSBfCh/zJI8hfg5SXXMf48P0NQRNKlSZpaVJj1F5AST4kKvlglhEZeZRR48J/ik6vDfYY7V21xTY03uesOZLO/nRRCXAJfYipJCugrp1xSSPVlHvj3v7mO4j20BMjknWbeDT5aNyNj/jGKhi3ZCfHqFKl3ewPRHPxWgHYjQxdPAeiUGnmwJLNRWZ9bEQ/G6OZuYk2HwWn+DAi3hxSZpM5+y5enEonG4XOGGCA+us StGMCdcn e4ThzAbGCA2TZ9QbKvpJehTfzt8KVSmtC8XLVVoW8rQyrXok+jNSg014XaMQG30VEYv2g5+hw3K6DRgIEeIpo5Ne7ZP58wGp3OXgCH/MEIwSS1oaa/ePm9W41+xJ7qFKsvpbduPkps3BqEDIL67Gq3m4Mcpp8Y+rFNV1wYGE/fTnpmiOfB1DzBJr8kJ4J91hk3Ktsod4Lyxt37eLtCy+L4AXneLiCJJ/G9Sg5t4xtMCX+5e1fLzY7gco61CI3JZfCG9ZtTTlmqcSfWIfqC5spGgXsIU3uwFRtfvjM/e6pM59hgfsNDvWzj1qYfJRtZczFdSJlaN4+jzGaBXPBK9D5X6NEu1UNh7ljLUQjDmLDJz+/0z+APfMiWdR/pmt30fL10VA+Ocsl10FGwnleffHOojCsilDj4uZyhnEIm86dg3mBS3pj6KrnSamesJVOM7sDx/2Q5jOrLsUECnCHFRhebRpG5q/raTeiZ1mI0L7q7E/afke6KWxkhtqjXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: No invocation of pin_user_pages_remote() uses the vmas parameter, so remove it. This forms part of a larger patch set eliminating the use of the vmas parameters altogether. Signed-off-by: Lorenzo Stoakes --- drivers/iommu/iommufd/pages.c | 4 ++-- drivers/vfio/vfio_iommu_type1.c | 2 +- include/linux/mm.h | 2 +- mm/gup.c | 8 +++----- mm/process_vm_access.c | 2 +- 5 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/iommu/iommufd/pages.c b/drivers/iommu/iommufd/pages.c index f8d92c9bb65b..9d55a2188a64 100644 --- a/drivers/iommu/iommufd/pages.c +++ b/drivers/iommu/iommufd/pages.c @@ -786,7 +786,7 @@ static int pfn_reader_user_pin(struct pfn_reader_user *user, user->locked = 1; } rc = pin_user_pages_remote(pages->source_mm, uptr, npages, - user->gup_flags, user->upages, NULL, + user->gup_flags, user->upages, &user->locked); } if (rc <= 0) { @@ -1787,7 +1787,7 @@ static int iopt_pages_rw_page(struct iopt_pages *pages, unsigned long index, rc = pin_user_pages_remote( pages->source_mm, (uintptr_t)(pages->uptr + index * PAGE_SIZE), 1, (flags & IOMMUFD_ACCESS_RW_WRITE) ? FOLL_WRITE : 0, &page, - NULL, NULL); + NULL); mmap_read_unlock(pages->source_mm); if (rc != 1) { if (WARN_ON(rc >= 0)) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index 493c31de0edb..e6dc8fec3ed5 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -562,7 +562,7 @@ static int vaddr_get_pfns(struct mm_struct *mm, unsigned long vaddr, mmap_read_lock(mm); ret = pin_user_pages_remote(mm, vaddr, npages, flags | FOLL_LONGTERM, - pages, NULL, NULL); + pages, NULL); if (ret > 0) { int i; diff --git a/include/linux/mm.h b/include/linux/mm.h index b14cc4972d0b..ec9875c59f6d 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2378,7 +2378,7 @@ long get_user_pages_remote(struct mm_struct *mm, long pin_user_pages_remote(struct mm_struct *mm, unsigned long start, unsigned long nr_pages, unsigned int gup_flags, struct page **pages, - struct vm_area_struct **vmas, int *locked); + int *locked); long get_user_pages(unsigned long start, unsigned long nr_pages, unsigned int gup_flags, struct page **pages); long pin_user_pages(unsigned long start, unsigned long nr_pages, diff --git a/mm/gup.c b/mm/gup.c index 7e454d6b157e..931c805bc32b 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -3093,8 +3093,6 @@ EXPORT_SYMBOL_GPL(pin_user_pages_fast); * @gup_flags: flags modifying lookup behaviour * @pages: array that receives pointers to the pages pinned. * Should be at least nr_pages long. - * @vmas: array of pointers to vmas corresponding to each page. - * Or NULL if the caller does not require them. * @locked: pointer to lock flag indicating whether lock is held and * subsequently whether VM_FAULT_RETRY functionality can be * utilised. Lock must initially be held. @@ -3109,14 +3107,14 @@ EXPORT_SYMBOL_GPL(pin_user_pages_fast); long pin_user_pages_remote(struct mm_struct *mm, unsigned long start, unsigned long nr_pages, unsigned int gup_flags, struct page **pages, - struct vm_area_struct **vmas, int *locked) + int *locked) { int local_locked = 1; - if (!is_valid_gup_args(pages, vmas, locked, &gup_flags, + if (!is_valid_gup_args(pages, NULL, locked, &gup_flags, FOLL_PIN | FOLL_TOUCH | FOLL_REMOTE)) return 0; - return __gup_longterm_locked(mm, start, nr_pages, pages, vmas, + return __gup_longterm_locked(mm, start, nr_pages, pages, NULL, locked ? locked : &local_locked, gup_flags); } diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c index 78dfaf9e8990..0523edab03a6 100644 --- a/mm/process_vm_access.c +++ b/mm/process_vm_access.c @@ -104,7 +104,7 @@ static int process_vm_rw_single_vec(unsigned long addr, mmap_read_lock(mm); pinned_pages = pin_user_pages_remote(mm, pa, pinned_pages, flags, process_pages, - NULL, &locked); + &locked); if (locked) mmap_read_unlock(mm); if (pinned_pages <= 0)