From patchwork Tue Jul 2 09:09:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13719176 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27268C30658 for ; Tue, 2 Jul 2024 09:10:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06C816B00B4; Tue, 2 Jul 2024 05:10:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F38126B00B5; Tue, 2 Jul 2024 05:10:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D66396B00B6; Tue, 2 Jul 2024 05:10:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AEF7C6B00B4 for ; Tue, 2 Jul 2024 05:10:48 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6967481C49 for ; Tue, 2 Jul 2024 09:10:48 +0000 (UTC) X-FDA: 82294242576.04.28EEEE0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id BF9DD12001E for ; Tue, 2 Jul 2024 09:10:46 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KTz8NtUc; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719911425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wlDjMGMoY5vmg8XP+VTRHx2+O1DZwsQWCcm7mjUpOdM=; b=8lbvfVUhHenuL1J/MbtJuPfefgdbfMYVtw4yfEOeZEX9AijBhNxjgQtDk+PQ4NcgQBIMup YDgvYwEZc7rfRyy0DYYIql02N+Z6w2OcI6QG5sydcmsJZPmVanui30IytAfhxdxUa3bYaC 8gBV4xpWYomb78o2jijbq3EiJL/u3HA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719911425; a=rsa-sha256; cv=none; b=feVNpSt4AsMldvPyccR1vuDL2qqUPwG3UjzaWHysKtj+Nx+xZh9xRKHpApkme1gwXR4VuK LhtboG2rMo7igfXf2p7XCuhYuV3fjtz8cQB/3EyQpfhtk26CDjGn8ZIPE4JA/LiTNZq3m4 hYfOnYx4DOLJPJwpTysqCaJnD9bkI6g= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KTz8NtUc; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0574461A24; Tue, 2 Jul 2024 09:10:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB9F3C4AF0A; Tue, 2 Jul 2024 09:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719911445; bh=pdK7V9xHdNBFoHCz59AGR5WOTx5xl2Vj8twOHvengYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KTz8NtUcFIGsDCeQDH+Db9PamT6/nlViuegQcsznIc+DF9srj7x240NEr4il//Xc/ 8i6luwPgO0yiJWdOnRcYYR5NL7yfawxlEKbv7drJYa8B4a339djv3OvkkqYT8c8H3F 2fawWfN+3TdW5300DYyGBMMir31FVKME3Mb0rFDkEafNNmyz4K9325deM1XSwCqvmZ j68Pmkr7YplRS9KcdrYMe4vUV3x2d5CnPCIdbVmN1wj2l59g8sgHeEOk1PKw3gUGEO sLuttA9bzZDdVviGMe/UOzCvZZ/jZMpHBqkeBTmM9HISPNn+o452NCrh1hoAqBSCYz dRKD1bcV6Pa7w== From: Leon Romanovsky To: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Keith Busch , Christoph Hellwig , "Zeng, Oak" , Chaitanya Kulkarni Cc: Leon Romanovsky , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v1 12/18] RDMA/umem: Prevent UMEM ODP creation with SWIOTLB Date: Tue, 2 Jul 2024 12:09:42 +0300 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: BF9DD12001E X-Stat-Signature: xi9jito6p7gxrdfmj7tjdenpg6xsi46q X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719911446-15292 X-HE-Meta: U2FsdGVkX1+dBjH6ev3kLrCHfbTUMkXKOM+W23C1dHQoGzQv5kN3Ejz0KgdtG4N+P2h7VHZBF+rgeuya2emnIDxcS41E0uottMhlb+tj6+cG68xSHA4rxmST4+ATr5tU5oESvqLI+7597mc1bmhc+ZTiwCohL6pMUI5gUcZdWKvYGf1GsCEhc2OryksbmiPiEWiXI0sghrXOh8RBLzr2do40AL0qbUIOmi6fULuAWFSX9ObLw0WLhCbTbZcbvzh3heD1lYRwN4HMzviuLj00wGq7TBKSzyo7bN97X8nRClecyKAsunqH8JiI0SIuuQSs5doYoQRWfH9GdFCXeQmP/1ePNMImD6kHiSDPOoct5v89/yctbkUeMbY+6zZuwIwU1xvR+UXU8AlNk3i9fmJdPu94qWh5zWPvhvmnEqxbRMEQT527YmReP87s4Hg1u/89Ssv4cyHUgb95Mnqqa5GnEJPj2T4PhgESwsCekdb0HxlcULxJqqWuE77qR6WFryHJCI6XV84SKc7UYJqv9u8v//7MT09x2RWx5rGWExgKUp3vIcg2C0Nqfoq+JoIIDklmS8KyF+qEKq17XQhZogKOHOwTSHY7wtJgFGSoDGq00s+rD/YUEP6cIbyr2k/mR/+1pMnOyoBoqB/8BiNQG/IvMGARtSWjHKzdBjrM9uGNTk1n6Cv/G3atalQv2cMzIuQ4Xr6CBxmh+UOYXLNPg/byvB0gDTDgyCNwFuo9KD5sq7EUjO61i89OjiFQE6gNtgPycI6VsFOrilVluwVv2as3AVY/BUzGXaicreNyxDqtjlwr1B1/YekhVhaKINn0++teWhFdD0yTP6u/FIf0KCxAyQu9JpFtb/Saum/JUQFe8Ejx83gjnABCAwmSyMWZHDYVggJOX12eiBBs3U/ENzkZnZXogbL5rY8wr0/YyZ3HRNFWTxLjKFEcpy+sLIPS1GTZvxYFVi9UtH5r+P290RR fc1+X8sq 8T12TE4cjdFcOcOr2FJiYgFttZTdP8Q5lx8KOHrowpkTtUSzih/Qz2rp+J5bCoQKX6/pW+CsG+4QobpNhi2WCCwDJtJgijHJzNUlqR1kbxFbiGQ1OjFn/vG+NMhvlsPO+q5+0f+qt3QyzSzB09Fnf3s8y2nbP4TWy9mNQvsziC4pALtsjYsLcGiEF51Pbr6cnPIPhntcRSvj1Cio= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Leon Romanovsky RDMA UMEM never supported DMA addresses returned from SWIOTLB, as these addresses should be programmed to the hardware which is not aware that it is bounce buffers and not real ones. Instead of silently leave broken system for the users who didn't know it, let's be explicit and return an error to them. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/umem_odp.c | 81 +++++++++++++++--------------- 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/drivers/infiniband/core/umem_odp.c b/drivers/infiniband/core/umem_odp.c index 6e170cb5110c..12186717a892 100644 --- a/drivers/infiniband/core/umem_odp.c +++ b/drivers/infiniband/core/umem_odp.c @@ -42,7 +42,8 @@ #include #include #include - +#include +#include #include #include "uverbs.h" @@ -51,50 +52,50 @@ static inline int ib_init_umem_odp(struct ib_umem_odp *umem_odp, const struct mmu_interval_notifier_ops *ops) { struct ib_device *dev = umem_odp->umem.ibdev; + size_t page_size = 1UL << umem_odp->page_shift; + unsigned long start, end; + size_t ndmas, npfns; int ret; umem_odp->umem.is_odp = 1; mutex_init(&umem_odp->umem_mutex); + if (umem_odp->is_implicit_odp) + return 0; + + if (dev_use_swiotlb(dev->dma_device, page_size, DMA_BIDIRECTIONAL) || + is_swiotlb_force_bounce(dev->dma_device)) + return -EOPNOTSUPP; + + start = ALIGN_DOWN(umem_odp->umem.address, page_size); + if (check_add_overflow(umem_odp->umem.address, + (unsigned long)umem_odp->umem.length, &end)) + return -EOVERFLOW; + end = ALIGN(end, page_size); + if (unlikely(end < page_size)) + return -EOVERFLOW; + + ndmas = (end - start) >> umem_odp->page_shift; + if (!ndmas) + return -EINVAL; + + npfns = (end - start) >> PAGE_SHIFT; + umem_odp->pfn_list = + kvcalloc(npfns, sizeof(*umem_odp->pfn_list), GFP_KERNEL); + if (!umem_odp->pfn_list) + return -ENOMEM; + + umem_odp->iova.dev = dev->dma_device; + umem_odp->iova.size = end - start; + umem_odp->iova.dir = DMA_BIDIRECTIONAL; + ret = dma_alloc_iova(&umem_odp->iova); + if (ret) + goto out_pfn_list; - if (!umem_odp->is_implicit_odp) { - size_t page_size = 1UL << umem_odp->page_shift; - unsigned long start; - unsigned long end; - size_t ndmas, npfns; - - start = ALIGN_DOWN(umem_odp->umem.address, page_size); - if (check_add_overflow(umem_odp->umem.address, - (unsigned long)umem_odp->umem.length, - &end)) - return -EOVERFLOW; - end = ALIGN(end, page_size); - if (unlikely(end < page_size)) - return -EOVERFLOW; - - ndmas = (end - start) >> umem_odp->page_shift; - if (!ndmas) - return -EINVAL; - - npfns = (end - start) >> PAGE_SHIFT; - umem_odp->pfn_list = kvcalloc( - npfns, sizeof(*umem_odp->pfn_list), GFP_KERNEL); - if (!umem_odp->pfn_list) - return -ENOMEM; - - - umem_odp->iova.dev = dev->dma_device; - umem_odp->iova.size = end - start; - umem_odp->iova.dir = DMA_BIDIRECTIONAL; - ret = dma_alloc_iova(&umem_odp->iova); - if (ret) - goto out_pfn_list; - - ret = mmu_interval_notifier_insert(&umem_odp->notifier, - umem_odp->umem.owning_mm, - start, end - start, ops); - if (ret) - goto out_free_iova; - } + ret = mmu_interval_notifier_insert(&umem_odp->notifier, + umem_odp->umem.owning_mm, start, + end - start, ops); + if (ret) + goto out_free_iova; return 0;