From patchwork Thu Aug 9 10:52:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Yi" X-Patchwork-Id: 10560711 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 512D014E5 for ; Thu, 9 Aug 2018 02:14:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38A552AC87 for ; Thu, 9 Aug 2018 02:14:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2CFB72AD81; Thu, 9 Aug 2018 02:14:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D166B2AC87 for ; Thu, 9 Aug 2018 02:14:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A43566B0007; Wed, 8 Aug 2018 22:14:14 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 9F39C6B0008; Wed, 8 Aug 2018 22:14:14 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E3CC6B000A; Wed, 8 Aug 2018 22:14:14 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by kanga.kvack.org (Postfix) with ESMTP id 4924C6B0007 for ; Wed, 8 Aug 2018 22:14:14 -0400 (EDT) Received: by mail-pf1-f199.google.com with SMTP id i68-v6so2436917pfb.9 for ; Wed, 08 Aug 2018 19:14:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=RxYu3w67orhQVDy+hQfozN1oWimHlxvIQibw4swPKIw=; b=GS/hJdUNuliT4u35oliJyBAlvrdk9U2fRMMavfBSJG4mmZx/+AA/j472AM919M3RRh 8sHa1yRgfQacOmMz+RaRSaUcFaBiB2rgvbWeAa+Ojl4J5RI8Qiw/i6LwpPm0Pm2LrWWe PGhYYuWThkotGWzzIjoEYKIAg6vVCbjoDelgnTdc6W24McFSWIbuCvFKwkRLZO7UlKo0 OkMxJFZecgkmdPymdtXkntrDyd6ygOBrtG6w2kUCTYf0+ecx56WT7IV16/OqMYMdHywK 5tE7dnZDIwD+yCMeIpyvu23wd02K30GuYiLt8RCmZnEscxc8T/8QgdKF3XhRNXH8TEVr LTGw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of yi.z.zhang@linux.intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=yi.z.zhang@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: AOUpUlGdmqTrL3ndYI41LupM/XlefggKxhgOQsv4MVnZ/wQLgH08yKwG S/TS4r011CNBqZPs9dRUL+v+X7Xa30FCEB/1aK+FYdmKmqvk+xwJ6T3r4+TbDi5OeeCf/awWpo/ LJmzywxxj+p5N6+p5MUcpvU9G/fGlZ87XRVrGaeSSN7UuqySefNMrv65p68OsCB6E8w== X-Received: by 2002:a62:5302:: with SMTP id h2-v6mr211129pfb.183.1533780853995; Wed, 08 Aug 2018 19:14:13 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzkZzVSqTgeNbJeTinp3yKQCKYFTOBL8l1a/7scyazw51N+wWMcQ2RmHa9txZxszf5/4bpV X-Received: by 2002:a62:5302:: with SMTP id h2-v6mr211077pfb.183.1533780853067; Wed, 08 Aug 2018 19:14:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533780853; cv=none; d=google.com; s=arc-20160816; b=gIqniycZSVlXHWqSKG/EIS/OvYRgZGRzvUZrkQuASObTLrDVEMgsqqk7nbgLzlYBfw aW8h+gRTstR++dPhRp54vPjZl4E/iOxrZCxPtKAC2wVFb7D9YWqlnGcwKSUzdFyS5Wok eNNNkI2Q0hG+EvjDEU8/QrzugJnFSrGHDnV9y9oARfOlhDjHqaXKUnaR1lpfXrvR74xw c/3uiUWxv2vn0gcxPIz9JkIysjYuc54q7YVh9J+1VgCaWD8oZl6Kgq8yXr9SUNenbWMr b/5PEsF8YaYIYmqX7HhNFOyuB5Laa+BxY9nsf2AuBQqPRQuPaccJQeCy7lfQheQK1Ec7 zpvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=RxYu3w67orhQVDy+hQfozN1oWimHlxvIQibw4swPKIw=; b=mJ3RpHNOGudmhe2Tpu3cBvtFj7WvMOfu09vFSaH2G0FPr6Mf+tEJOfL4OhYjKgsNKU GIj1curMP9NPNwpAdHxYdfKqM3+8ypvfPJ05MypgCiwKopJXHiWKtZmh/l1YmrYjAcf8 IA557hZC9d4mrgORK7C0JctJAqz5az0M4ydV/L1cIFqgU6ycVOwcMaNq3ErBWp5/NWtk skjYm3gq0O3DcFha1CdUMsYnyOH3GW7b3bSFd1me1rb54nOoQ2Y9Ym+wTAVSWpQ7adcs bM0i/8BTMiI/8omYuWFzDmQX1FM9VZloSCTeb9fjvKX/luv+4P3jprOdXlIH13EvthUb 7LcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of yi.z.zhang@linux.intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=yi.z.zhang@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga09.intel.com (mga09.intel.com. [134.134.136.24]) by mx.google.com with ESMTPS id r59-v6si4628620plb.39.2018.08.08.19.14.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Aug 2018 19:14:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of yi.z.zhang@linux.intel.com designates 134.134.136.24 as permitted sender) client-ip=134.134.136.24; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of yi.z.zhang@linux.intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=yi.z.zhang@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 19:14:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,213,1531810800"; d="scan'208";a="81868676" Received: from linux.intel.com ([10.54.29.200]) by orsmga002.jf.intel.com with ESMTP; 08 Aug 2018 19:14:12 -0700 Received: from dazhang1-ssd.sh.intel.com (unknown [10.239.48.78]) by linux.intel.com (Postfix) with ESMTP id 6679A5801BD; Wed, 8 Aug 2018 19:14:10 -0700 (PDT) From: Zhang Yi To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, pbonzini@redhat.com, dan.j.williams@intel.com, jack@suse.cz, hch@lst.de, yu.c.zhang@intel.com Cc: linux-mm@kvack.org, rkrcmar@redhat.com, yi.z.zhang@intel.com, Zhang Yi Subject: [PATCH V3 1/4] kvm: remove redundant reserved page check Date: Thu, 9 Aug 2018 18:52:55 +0800 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP PageReserved() is already checked inside kvm_is_reserved_pfn(), remove it from kvm_set_pfn_dirty(). Signed-off-by: Zhang Yi Signed-off-by: Zhang Yu Acked-by: Pankaj Gupta Reviewed-by: David Hildenbrand --- virt/kvm/kvm_main.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 8b47507f..c44c406 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1690,12 +1690,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty); void kvm_set_pfn_dirty(kvm_pfn_t pfn) { - if (!kvm_is_reserved_pfn(pfn)) { - struct page *page = pfn_to_page(pfn); - - if (!PageReserved(page)) - SetPageDirty(page); - } + if (!kvm_is_reserved_pfn(pfn)) + SetPageDirty(pfn_to_page(pfn)); } EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);