From patchwork Thu Mar 30 10:43:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13193872 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA21AC77B6E for ; Thu, 30 Mar 2023 10:44:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EB8C900003; Thu, 30 Mar 2023 06:44:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79A86280001; Thu, 30 Mar 2023 06:44:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 662B8900008; Thu, 30 Mar 2023 06:44:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 573B7900003 for ; Thu, 30 Mar 2023 06:44:47 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 324D21C6572 for ; Thu, 30 Mar 2023 10:44:47 +0000 (UTC) X-FDA: 80625231414.23.7C6916E Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf17.hostedemail.com (Postfix) with ESMTP id 20CBA40003 for ; Thu, 30 Mar 2023 10:44:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=lsFnIr8C; spf=pass (imf17.hostedemail.com: domain of "prvs=446327cdf=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446327cdf=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680173085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WXkJDJqTCv0Db2aR823cGfOZaDqrHbaHORfxS5dBSZw=; b=qUBIK4rm2jLqrzutoB1GaCOWDsSjaL0tauEbR5y5PHm3AYTR8tGlah9InkIwElMOO1ZDOw IhvOs80XiKpZWYXd8+YEeg3oAyqGZNQIG4YPV8/SSNdTnpJg2PbK6YYsLKjSnToIG3weZH 43bqKps6ZqsWBTeRrFGcL01PIiIIxXU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=lsFnIr8C; spf=pass (imf17.hostedemail.com: domain of "prvs=446327cdf=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446327cdf=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680173085; a=rsa-sha256; cv=none; b=h6OpUQ4Kz8GBPY/JqipymLLQ+nkTxbZAoWvzmbtusHyqlLW2/Ri42wY0BJ/+05cyS4j0vU GPgDDvbh5kNjJahY7g+B1YtN1TUpddhoH1WFTtyBEVzul5G04USvqf2EeTbWm170N5B/0/ H0ornY9pC7OIqvEPCYs8FlXof0IEdK0= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680173085; x=1711709085; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RHMrIgXLZtjmRd+5c9MBnc3q/BEGhtEER4XpeifNGfw=; b=lsFnIr8C7uu9Arieojcb2ZlNnsw6nrTS1RPUQpQ0g8qnGFWnAAqPup1I Z2xtKghpuCeod4cS7aFS6U5ue9w6lWwd+qkiSDXOoUb/V/d69eit7RxSV Y4TFCqFkXT1J/2sSYPHVoMUpD234ziKcc75iwCmtzA6Wmvk6nPhdpxfAK ceArj2GayOt24LCU+hTOCN1UtaH8MOtVxcwjqTA9xsNg1P6UVQaUK6XR5 9uk/gZbvSRhn4BUCqws/Q4ZUurKwni1wcOa8cyovBpTpdXZcrgjFmGjva hsPSdk5j5rV+MxWAmQjuqZae3yM6Cl1KHt/7RoHYqhXDrk92XTNhr9iaR A==; X-IronPort-AV: E=Sophos;i="5.98,303,1673884800"; d="scan'208";a="231853956" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 18:44:44 +0800 IronPort-SDR: nybUrECD97FvLUa+hJgrsDnFBDIyzXDYifrGniijxBo0+mh0ycKV/osknhTR+kk3QeXWRj2+ql HwDRA+pVC5aZpV/ZLQS/QeQhXin6ddF8V4+/YPuNq5FI/QfDpc43v9m/U3NWLTR+TUvzv5CwMT 0uOiaDIu+xs54PCDKKBlftpGpfPFBr/wG2frc3RXjEKLB67r2W/aByUkIaYtPY658qUrN5z6z8 hpA5qCVTllCVpiKPEXTbk4vLp5bKyXDq0pmznDat40p0MMAKQCSg84N/iPUV6W0nZLr7KdZSZj sB4= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Mar 2023 02:55:11 -0700 IronPort-SDR: skMtz4+keJr/cRyrN9pwkgS0ewLiSNPb2M9dHYXrhuJ4g5fW5pyblL2I46HGHIXXc8RzTaSiVQ vh/QodlyDksqLq7Dbn7EODH7rPaYpLyeTet6XndzDCHJq/UDe4ACMF5fuQcuF8b6PngN7P5WFm 6bbx8cI+1QGvEI3G+Itr17jIH6UA32wollKGVJ8Lv5OT101pzER2Ix5fj4DLVdWgljSJSJ+fAE pfT9r3OX9yQGbEd5JejAszDBVE5RDoC09pcH9t7rXTz2l8qBWAe6vvY/LavdGZzoCYiQnqJYAA 1/k= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.72]) by uls-op-cesaip01.wdc.com with ESMTP; 30 Mar 2023 03:44:42 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v2 13/19] zram: use __bio_add_page for adding single page to bio Date: Thu, 30 Mar 2023 03:43:55 -0700 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: hj8d945ouahy15hymaduqs3jmopk68op X-Rspamd-Queue-Id: 20CBA40003 X-HE-Tag: 1680173084-439085 X-HE-Meta: U2FsdGVkX19oBKdF2v94NBgy/t8JXR9wvznHdyI4yl0oPRUlFlc0JT0LzbJY1DbziGEbnMwdAscCaB+aJ0Oe3tZj4zU+deoabjF3y9a6LiuqVVzHE3/kNi8oYJmL78ACsmrIwSappMmI/A6drBGevuPpmWApmy3vgxzt6n7RdDo7Xaoh0unSYwjkeBeDSkwp7lm6rFeFUkmdnT1OgVISFzqsfqB+iLsgz5cHrJ7wTYRPT8/VcI82K9TzUqrmTJxxcMg1Yl12mOHxGEddLAvgaEIothoVeWbiVmNJ7WiJ+EikvD78rSRunGyQLCCBGNfjCNosbiEjOmySwfGB6/7LwhcxS5kZhyLu6PmtMSgfCGwcLcHmm4Zq10pGuOlodtkQrNbFEE0HtcGLIrBuS0Tqtg+5W+zZcD88X2MyBM/4EPghxNvjUgnl9eD+gJ+ocTCiTm/jYuBaLpsrsvLfllz0tL9XHNkS7OhyDbT0edaE77LkTvhC5wpNTuHYgSxNqeo5sUOtqfKgsPSrnHFDarK0usICLBnyVdvjwUFLKg1r0tiT9mFPdHchkPn9wLHIpUUptzCn/zwNVwSCMpeYcEfYi++ZNa0nFU9yrRixbv9AbA33Mk+4GPBhRB1TjBxeGjl2rUYD08RJiHymdq8uUa+8Tg7ZOYvnj6zlDtR9GjbCFNKWE43E30FU/IbnonPxNg+d4umtkXEY4ciltqlNs51tM3U2BMU3mQkBUubcrX6m0V/LViIGQD5ovn2OVlnp99a3A5sZP/x368wscNMi2isXrK59qWR98ktZhtUkZ1dn1bt0RMuGBvzhasI3MdMR5g+GLyajDyPWQxS192mQNzVK83oJFK0wumlZIGRi504EcaQ0TYEoyjuxmRTJjW12Vt1hb//vuVepzL5WYiYpmMJW3K4qP2meo5RnvVmJwwtrTqcfCV/HGfPi3nj0FqqFZDOFLNl3kYU/jzykCt7fQzc KwVow/lK e514XWFwZ2jcB2drYYCYWSBJCOhTGgUHY90V8CwuB1lr65uoMZPFhJy+VWaWG8G/GKEl0T9d+Rel2wJjcecclP4gib6D82voNgPVceBJ8smvdeoBo0HujcgNf1tbxVFfcP0PNFnTuYWcAG0TPK+M1mF7fKtPZ2mlUylX+W4Y3RSa+7kGjYFAr5wn46YvNKAArbNaT2wC0qU5FNvJHVYt6yMoqoFjezD3n+QLe0dt9vtSqQ4Az+VbFVMB+/Th7E/5iE26YSEs+eKvdehTj6iZcTNFvy12qra0n9yXWdq43WYGuRE1noY2VwwrAfeRjYahH/fic+II2kKuKcRoTpuaY2rEVQnhVA/T7vcPUExmj/mQAVzUeel+Wdsj0tAlIT1dq3pjlJ2pYT2UEdTSiYSnSAVSdW/6qiYKu3f/Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The zram writeback code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal --- drivers/block/zram/zram_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index aa490da3cef2..9179bd0f248c 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -760,7 +760,7 @@ static ssize_t writeback_store(struct device *dev, REQ_OP_WRITE | REQ_SYNC); bio.bi_iter.bi_sector = blk_idx * (PAGE_SIZE >> 9); - bio_add_page(&bio, bvec.bv_page, bvec.bv_len, + __bio_add_page(&bio, bvec.bv_page, bvec.bv_len, bvec.bv_offset); /* * XXX: A single page IO would be inefficient for write