From patchwork Fri Feb 7 09:44:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 13964700 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D35C0219B for ; Fri, 7 Feb 2025 09:44:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B757280004; Fri, 7 Feb 2025 04:44:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8688D280001; Fri, 7 Feb 2025 04:44:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72FC6280004; Fri, 7 Feb 2025 04:44:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 53AD9280001 for ; Fri, 7 Feb 2025 04:44:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6E326161786 for ; Fri, 7 Feb 2025 09:44:37 +0000 (UTC) X-FDA: 83092663836.02.0143335 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 6E9A18000B for ; Fri, 7 Feb 2025 09:44:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=iVgKSGuJ; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738921475; a=rsa-sha256; cv=none; b=DuOc2EZebJrVyVn5WZXGwl647IcO3HAnU+RliMHhxOwwk3pUL7/Gaxbnkvzrf4RlpjVk2V UuYXID7LIU+jV/PlznnOtp26vc4mrS1PkkhtOV37yejnm6CZXWoMxAanaGZGQTQtFmR+rA OuocYjHan8XArdgcT+IvhttYl2QpN/Q= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=iVgKSGuJ; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738921475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ET2M5RfKIACOkV7gUbUijh4rZv1dga746bLIAUCkeds=; b=rmcSjCW1NV7gZU8soToK/kChI9Yq8Xn1udfMXJHLfWz+Th7ZJUMMD9z34uyxUjY94DLIlT /C9TAIn26uUA3xCa+qErK9guG2t2giOkhHWkWKjJQd7Dz9I6iFBXnPd0oamXbN8tpnj/Eo clYUu7mcSd/OQSPF7fA3xJLIYX9mk/I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1738921471; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=ET2M5RfKIACOkV7gUbUijh4rZv1dga746bLIAUCkeds=; b=iVgKSGuJfWQ/3ueMrxUy2Np0vqR+xXpEYz/3hq08f1wcK05O0vmRAhL1OgGHSH1eSI48RycCU1p6mMjDVHZfntZ4QQWC9ecGeBGe/Y/awO8gDttdN0+1k1X9UvSTng2IxiseifEjlVQrc55SzbV+40Mr7pG/5/Pb0HCX+U+bGOs= Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WOz4ok4_1738921470 cluster:ay36) by smtp.aliyun-inc.com; Fri, 07 Feb 2025 17:44:30 +0800 From: Baolin Wang To: akpm@linux-foundation.org, hughd@google.com Cc: david@redhat.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] mm: shmem: remove duplicate error validation Date: Fri, 7 Feb 2025 17:44:19 +0800 Message-Id: X-Mailer: git-send-email 2.39.3 In-Reply-To: References: MIME-Version: 1.0 X-Stat-Signature: wq4ik65tdw8smoak8bbgeobw56ksh1yn X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6E9A18000B X-Rspam-User: X-HE-Tag: 1738921475-931821 X-HE-Meta: U2FsdGVkX19FUYJnic2yqtRLIHYuyiac9vDFlFKoQhZfRcT7vA9wAmsFqgogcberLw9ibQcUIx8gSjSB+m53ZHusCtPY+z+z+S7h7r/wK0O5VNHAIIQZ8JuBW5Xx97/hYWXuCfPnogpfwxxA+kY2lCtxTqL51w4zQrPmsuU/6UExQFe0AL5zXMQDN+1jrgMwWo6pN6yEeujLJR8rMbAzMJvemZMPIIWlXMiXKNfzxoGoBOk2883lm+Cc/xOQ4OKQND4UD6Fm4uyh1GnMDosHkDjHtZMlw79lq/nHXLUf+S9SiA5km7D5n44ADt2E6SfVSrjeASqY0H0gak18VoDi1FSxpettYnTADzx+EqtTKoPQ7xHd8BxvdbFEGrVcRP6M4b3641DwCcnDZx2TQYsgZSMkSCifkAK0aPvxuZrxXx/22HCrHdEtFZa3aA8N5MQFbRzuqu8QFw9l62XMTrs45vZvQiWAbnNT/yzDBP3Mnexy575R0/JQTgafaMLh4OmE7vyYKu7R5NOCDKqv/4Uc3LQ4XZt8LbhxO7C70+K28cX92XL3H3BtQn8hdmlVOeRwGRsmWO+qTxxW4/4mw9n8kbm7k7Ki1bZrKsCsRmSnvUVqMaAl0bOGt04NPPRn4VyXF/CzM7xwHTejPukpqxAJ4FfDPXFB9ZazvuNGL13ysV2VUY9ifal7UJouDAwKlzzt2nbuzVkxpyYYprNNIbiUzwbtJ6GfInGQ8CTAoyhlnjYwMAMDfsCDYEP1suTjcrydG5EsZ9fYSHoJXn83SYmtULIdTvB8NXXEz6cxoCLyci/U8w97BCjyIub/yfz0H+NLvYEtL4JFpCdhpCpZ1Of42g+9YXtiksukIXRtn5s1MpLl/Qp7/QMldamx699tS9xpIxKEjRWfWgZtLIs91/zDhRcMoqucIFOAirDHH4o5i3ENCo1qwVz8lnol79mmuPt3yYa3vhpVQ4l8RM6mmTf +VXAXczq UQ+Mef/qHrg9jryVW9pfRdvk7p82SfeOn1PjvOJAbB0kdKRZZmAZdngm8CNDYA1L+RJJkyFIarZ/0k9+BmUfNwn8i1gmoebSTJAHLbj3sxT6Ft6oz4RfM2kRtjy4Encfl7U0379MEhJVwGWDPISbUVlkzkJn/PL5EC4GYHRK+4qsHs6ju0jgQfYCfSUWdVoc2NHdRvUtHEPJxSVZW3jnbZ0p9aIs3QP/n0zkf X-Bogosity: Ham, tests=bogofilter, spamicity=0.053615, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Remove duplicate error code checks for 'start' and 'end', as the get_order_from_str() will only return -EINVAL if the cmdline string is configured incorrectly. Signed-off-by: Baolin Wang --- mm/shmem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index b7aef4f0a427..b764ad336598 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -5650,19 +5650,19 @@ static int __init setup_thp_shmem(char *str) THP_ORDERS_ALL_FILE_DEFAULT); } - if (start == -EINVAL) { + if (start < 0) { pr_err("invalid size %s in thp_shmem boot parameter\n", start_size); goto err; } - if (end == -EINVAL) { + if (end < 0) { pr_err("invalid size %s in thp_shmem boot parameter\n", end_size); goto err; } - if (start < 0 || end < 0 || start > end) + if (start > end) goto err; nr = end - start + 1;