From patchwork Thu Sep 12 11:15:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13801924 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FACDEEB594 for ; Thu, 12 Sep 2024 11:16:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B938B6B0082; Thu, 12 Sep 2024 07:16:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B45086B0083; Thu, 12 Sep 2024 07:16:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E4906B0085; Thu, 12 Sep 2024 07:16:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 828316B0082 for ; Thu, 12 Sep 2024 07:16:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3B0E512185D for ; Thu, 12 Sep 2024 11:16:11 +0000 (UTC) X-FDA: 82555832142.28.227F8A7 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id A29BFC000D for ; Thu, 12 Sep 2024 11:16:08 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EmLlNz91; spf=pass (imf28.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726139663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dRHSz0R1VwTi0dYb+LlH3KG5wXGf6fhQy9+v7ADWjGg=; b=YZ3cq+BeYONJ01nD2xjAwmuEKJ+fyo2B+bP7jnxrfH8zkiyR470d1ED3zttji0HcNZURGu ZsFTqfFr47RmSyREY/JchrYDIPfjbThhELGv4OD9UoagEn08r3UwfjZWJQA4hXSmorch9J e5Frgkk+5skuJzaUye6/D7OOQHM/H6k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726139663; a=rsa-sha256; cv=none; b=8qXtffBH8JGZFFddVXeodM3juq40SoQP5CkN2m9nt95ScmWDqtZUUoUKHZYFOelojSCLuo 3KaKrsFwaFNaKtpTBkdLQ/Osv0YE1Mqdyj8Ut7srs0AY1/g62bX/q0JWNxZrir2wVc3E0U FQiG25bCjvlk1gncjiPAvSep7LXcj7o= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EmLlNz91; spf=pass (imf28.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5B36CA4523B; Thu, 12 Sep 2024 11:16:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D77C3C4CEC3; Thu, 12 Sep 2024 11:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726139767; bh=VWjabdNWVPsGz8JpMutT65B9uF9Uo/BpJGgpfDUTVak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EmLlNz91vs6SxK07DPB0FeRsNdYraG/8/aqHCC+3yK4unyOBTigWl3dgYpL2FkZvP G00341+DXFortwi5A0DRM0oHHJqqoS7g8LSRwclecTKFOR6jCplrCR/SZdrKvwQrep 5phR03LaxkxKfznDtpK311Npqk+LqTE1hfaGrQzheteDVBW+0npQPavVlKK53ZaCZV jUwtCJrepSK/qZzM0l46iOZh5zC7lj4U1Ro+C1FrUtN0yi1ZAX+AUZ4QhVVi/LHgnS 9a/vmDOidRNoehzzXg/ZzBt24/4beQiO6/rnc2z0BUmysAh3pMoMNwdyfrAPJ0MonP a9CIwLBnLrSxw== From: Leon Romanovsky To: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Keith Busch , Christoph Hellwig , "Zeng, Oak" , Chaitanya Kulkarni Cc: Leon Romanovsky , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: [RFC v2 02/21] iommu/dma: Implement link/unlink ranges callbacks Date: Thu, 12 Sep 2024 14:15:37 +0300 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 X-Stat-Signature: souno9tu9xjmf9u41ggi3x1uwkzmkywf X-Rspamd-Queue-Id: A29BFC000D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1726139768-448608 X-HE-Meta: U2FsdGVkX1+cOiSRZKj9yWtV3BLS9eNIo4/Vb94zNVetgC8i4SQEOGIIymKQtKVL/ghzMbRWmmoiDXrjaCQxGBBLh2l5O3LJBHDlQ1GZuhNbS72VDTD2aH1zH7JCcfbBWjGdXeBTxmHJAZGN+yUZB/j0M6+D2z2/JfOTezrqjJbo0P7ei7TBqhOTr+B/bi4dqcY4t1JAuXuofPlpzlD5TxxD6jy2kg66XLbdYM3TkvmXq35aBDqHzuYdFeiq6KXoWfWf/MoRfpT+TNQGxbOl2+OerQvHPJHQjzQ3/L3ooSdwNlCfD8/E0wHfBHsBEXDjsng46fvRG6AgYtEWxuguZ9SJroSHu/n3HuLvCXE8SvduepBG3gTXCSeI29nKlbq1rz29mEP7Gz7lU6dnVXa+d2B7WlR0f+7gYN5UNoGhkQ8WPyk69zC/QBKW7VptxKK/vLyyINjVGECrLvJ2gsEdNlRCtWb1Yfx49VHtDUug0Al1TWmMxUac0TjXFcIvrYXoYHMoF7qVpwmlYxvWZCGLjo3foSIitv2HaYrCNJ1BbvGu3csBMEMRnFPaf7st9Qg9BHduDfLCTTRGpChRKe0fxkNjwTpq7YuKP5ne5vyzSqI37KQYFSConwawxHNSEUPSdd3ys+uHtZrshIxzsl0NQay78I2YgKpzVEgl0a1oe0ROpEEXKf2Kw3drnO6n2YMFGoEk2sZv1ZkhLuYRCINJpPYHRKVMTwGgBugpgblEY+FyaKNBvCIaqB/l3S3JfkPa1/47GPMbn9kOl0gHQKY2lM+h/Ma4XRnT2qkggBqaAQy3qmJaLBF3ST1Z+z99J80sX2pLVvQb78afOC5OWmoz7rpnzy+1ryIXuZR04KwAv+NT79N266Ep7sNWoODKX/vonZ344fhmaVJ6H3ROyhwG1ErzI+IRMs+5tzLq0gPIHxzLgtsE6VDN3B5nV8UJHmVyhrX9ps2QHZCFB/4PR/5 G8gqdVpK UYphtqhwLiVA4F+rByjMnuLHRMhYcVh3xr0VbU2LI9jF1zhxLdsfJPWjzgKVQlKzVGrN1wM3ggI2vyFwFdifxeCy1K3Du2dI3zldeHblOxVjm9vmvE8gWF0gfG9rmayMTNEqbY18sUe0C7aSnbGcA0FpSbPHI86DtwwW5SmuumcIi8fHRcwtrIHBchsst1yO/fVCQBw+hFh8m8FY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Leon Romanovsky Add an implementation of link/unlink interface to perform in map/unmap pages in fast patch for pre-allocated IOVA. Signed-off-by: Leon Romanovsky --- drivers/iommu/dma-iommu.c | 86 +++++++++++++++++++++++++++++++++++++++ include/linux/iommu-dma.h | 25 ++++++++++++ 2 files changed, 111 insertions(+) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 09deea2fc86b..72763f76b712 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -1743,6 +1743,92 @@ void iommu_dma_free_iova(struct dma_iova_state *state) &iotlb_gather); } +int iommu_dma_start_range(struct device *dev) +{ + struct iommu_domain *domain = iommu_get_dma_domain(dev); + + if (static_branch_unlikely(&iommu_deferred_attach_enabled)) + return iommu_deferred_attach(dev, domain); + + return 0; +} + +void iommu_dma_end_range(struct device *dev) +{ + /* TODO: Factor out ops->iotlb_sync_map(..) call from iommu_map() + * and put it here to provide batched iotlb sync for the range. + */ +} + +dma_addr_t iommu_dma_link_range(struct dma_iova_state *state, phys_addr_t phys, + size_t size, unsigned long attrs) +{ + struct iommu_domain *domain = iommu_get_dma_domain(state->dev); + struct iommu_dma_cookie *cookie = domain->iova_cookie; + struct iova_domain *iovad = &cookie->iovad; + size_t iova_off = iova_offset(iovad, phys); + bool coherent = dev_is_dma_coherent(state->dev); + int prot = dma_info_to_prot(state->dir, coherent, attrs); + dma_addr_t addr = state->addr + state->range_size; + int ret; + + WARN_ON_ONCE(iova_off && state->range_size > 0); + + if (!coherent && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) + arch_sync_dma_for_device(phys, size, state->dir); + + size = iova_align(iovad, size + iova_off); + ret = iommu_map(domain, addr, phys - iova_off, size, prot, GFP_ATOMIC); + if (ret) + return ret; + + state->range_size += size; + return addr + iova_off; +} + +static void iommu_sync_dma_for_cpu(struct iommu_domain *domain, + dma_addr_t start, size_t size, + enum dma_data_direction dir) +{ + size_t sync_size, unmapped = 0; + phys_addr_t phys; + + do { + phys = iommu_iova_to_phys(domain, start + unmapped); + if (WARN_ON(!phys)) + continue; + + sync_size = (unmapped + PAGE_SIZE > size) ? size % PAGE_SIZE : + PAGE_SIZE; + arch_sync_dma_for_cpu(phys, sync_size, dir); + unmapped += sync_size; + } while (unmapped < size); +} + +void iommu_dma_unlink_range(struct device *dev, dma_addr_t start, size_t size, + enum dma_data_direction dir, unsigned long attrs) +{ + struct iommu_domain *domain = iommu_get_dma_domain(dev); + struct iommu_dma_cookie *cookie = domain->iova_cookie; + struct iova_domain *iovad = &cookie->iovad; + struct iommu_iotlb_gather iotlb_gather; + bool coherent = dev_is_dma_coherent(dev); + size_t unmapped; + + iommu_iotlb_gather_init(&iotlb_gather); + iotlb_gather.queued = READ_ONCE(cookie->fq_domain); + + if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && !coherent) + iommu_sync_dma_for_cpu(domain, start, size, dir); + + size = iova_align(iovad, size); + unmapped = iommu_unmap_fast(domain, start, size, &iotlb_gather); + WARN_ON(unmapped != size); + + if (!iotlb_gather.queued) + iommu_iotlb_sync(domain, &iotlb_gather); +} + void iommu_setup_dma_ops(struct device *dev) { struct iommu_domain *domain = iommu_get_domain_for_dev(dev); diff --git a/include/linux/iommu-dma.h b/include/linux/iommu-dma.h index 698df67b152a..21b0341f52b8 100644 --- a/include/linux/iommu-dma.h +++ b/include/linux/iommu-dma.h @@ -60,6 +60,12 @@ void iommu_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sgl, int iommu_dma_alloc_iova(struct dma_iova_state *state, phys_addr_t phys, size_t size); void iommu_dma_free_iova(struct dma_iova_state *state); +int iommu_dma_start_range(struct device *dev); +void iommu_dma_end_range(struct device *dev); +dma_addr_t iommu_dma_link_range(struct dma_iova_state *state, phys_addr_t phys, + size_t size, unsigned long attrs); +void iommu_dma_unlink_range(struct device *dev, dma_addr_t start, size_t size, + enum dma_data_direction dir, unsigned long attrs); #else static inline bool use_dma_iommu(struct device *dev) { @@ -184,5 +190,24 @@ static inline int iommu_dma_alloc_iova(struct dma_iova_state *state, static inline void iommu_dma_free_iova(struct dma_iova_state *state) { } +static inline int iommu_dma_start_range(struct device *dev) +{ + return -EOPNOTSUPP; +} +static inline void iommu_dma_end_range(struct device *dev) +{ +} +static inline dma_addr_t iommu_dma_link_range(struct dma_iova_state *state, + phys_addr_t phys, size_t size, + unsigned long attrs) +{ + return DMA_MAPPING_ERROR; +} +static inline void iommu_dma_unlink_range(struct device *dev, dma_addr_t start, + size_t size, + enum dma_data_direction dir, + unsigned long attrs) +{ +} #endif /* CONFIG_IOMMU_DMA */ #endif /* _LINUX_IOMMU_DMA_H */