Message ID | ec7762407bfe4a1cd41faf89b35ed393b592a816.1736221254.git-series.apopple@nvidia.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E45B7E77197 for <linux-mm@archiver.kernel.org>; Tue, 7 Jan 2025 03:43:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77FC26B00A3; Mon, 6 Jan 2025 22:43:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 708BE6B00A4; Mon, 6 Jan 2025 22:43:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50DDF6B00A5; Mon, 6 Jan 2025 22:43:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2CA2C6B00A3 for <linux-mm@kvack.org>; Mon, 6 Jan 2025 22:43:51 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E116816066D for <linux-mm@kvack.org>; Tue, 7 Jan 2025 03:43:50 +0000 (UTC) X-FDA: 82979261820.05.7BE63FD Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2055.outbound.protection.outlook.com [40.107.236.55]) by imf22.hostedemail.com (Postfix) with ESMTP id 2782AC000A for <linux-mm@kvack.org>; Tue, 7 Jan 2025 03:43:47 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=eu2MCoNK; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf22.hostedemail.com: domain of apopple@nvidia.com designates 40.107.236.55 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736221428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rWLD/0xp0BR6MUjdXJUQ+QA/Pxu3/82VW88rj0w5N0E=; b=3t409KcbzuNDal/HvSdgQmnuAdfyPr2f0kononQNTdNmQ8sJpXMze5e1oWIwIdx5niw0wF tUde7eguBVhyWkFTE+7I2A8axIsBVH1PlA1lGsn88pJPnKOMNWL0LZFbmakNcQKBzyUo5+ zWnBhsd6ttG7/fKyN3c40KbApP/1jf4= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736221428; a=rsa-sha256; cv=pass; b=MeqrEPnSy6nnOTyl0WF5HXu9bW5jx86wVSPSvJhXjE9gZMtTEA0l1NB4j9Ga7F8fZ9cXDq QJiCzyQGm4ScsapoPsQcUK958cGCDYgfTssn2GCGpaRfm/YfmZAsowxUmn/B5ndpyR6jvM IZ/ofkxqMsW2zUhGttcP2LsHwixfgzs= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=eu2MCoNK; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf22.hostedemail.com: domain of apopple@nvidia.com designates 40.107.236.55 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GdodkYuEQ8mZAfNg3PxnAFg7HdZKGtqhzdm8nTdKX/fC7OFNJFJefOY2GHCIozqvgauPYvOtCOnQQ4CXIoo7kJOi2KHX9UXLgdzspJiTvygc6KSJ/3iM9MGTa1gh56/3vfkjnSRu2z8yI67ITVvWjOxiYHTlH5Xw0OOiODuqciQAdYi8d7DP6ppkoVe3l0LMCTzxOCYZhROqHXimgSTWL8rBGXJipT17d68PEWn68xPLxR0E4a+PdH60JwxdcgxOAdVBdGHvXJBde5PAzXv9KxBDdujlZAoqbVtjkLfr7pgus0Q6AkZOHi/d2bzHfkggM+iICi3mWPNsGI2twgrNyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rWLD/0xp0BR6MUjdXJUQ+QA/Pxu3/82VW88rj0w5N0E=; b=NbBxUuhP1ogbM70t++8AARvqDAiWjt0+ZgTdGotqb0oSZ55Q0dTeV+BIAWXc9WWq81ceYvtnkwW+wd1xOgDwMz3XJNh+bftULYZ7rq0VnoEZugERz/isP0jPOKYyzPtsNPSzYOqiEqOTLmZKj8SM3a8csm7rfMGjeSTmHTuYQhgy4Ywt+It3UEz6CLUk+exslvmrDM1YqP2WjI/fR6bAco9mSyJyswPc2Lk9cT1NdXfbSPdHpzrl15dlyyzRhCkhz4hKFIABER+sAbrAHl74dq4z6VJAJnnWDfQ5qmupwLpp/jNYdInNF56hlGZHC9AKqXGIY++ooitwvq1fpc9T5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rWLD/0xp0BR6MUjdXJUQ+QA/Pxu3/82VW88rj0w5N0E=; b=eu2MCoNKZXLpOde6x+8LGxb4cpiLFNjqTKmopaNRWkmdoXPtICpSyh+JPxzAC5RQUOpLWICkzZNgP4t+bj8cJvdLkfTU3fV3MZGhdBa9alrNlXHNLBhysswcELDRQ5BNtPc7+5KpX/vL3X2e35hK/Eo5nIb7ly1RgNuAGlZ0lhIkiKdpO1Ji3N2+34vMIeevmgqpWRWo+h/xVb9l3ybKoEvCGCCBOgX3FS2pJFpKHpqa4N+kAm62HdcTGRpmfbv2OsIZ9Gv9URyP7XUCVG9mEdgrMWKCK+rYEhWkLdeQ6jL0Ew5C9loxtH0DJHPFRyrtnDWZCHfTzCn7oBBglbOs/w== Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by CY5PR12MB6129.namprd12.prod.outlook.com (2603:10b6:930:27::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.15; Tue, 7 Jan 2025 03:43:40 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%6]) with mapi id 15.20.8314.015; Tue, 7 Jan 2025 03:43:40 +0000 From: Alistair Popple <apopple@nvidia.com> To: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: Alistair Popple <apopple@nvidia.com>, lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, Jason Gunthorpe <jgg@nvidia.com> Subject: [PATCH v5 09/25] mm/gup: Remove redundant check for PCI P2PDMA page Date: Tue, 7 Jan 2025 14:42:25 +1100 Message-ID: <ec7762407bfe4a1cd41faf89b35ed393b592a816.1736221254.git-series.apopple@nvidia.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <cover.425da7c4e76c2749d0ad1734f972b06114e02d52.1736221254.git-series.apopple@nvidia.com> References: <cover.425da7c4e76c2749d0ad1734f972b06114e02d52.1736221254.git-series.apopple@nvidia.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SYYP282CA0006.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:b4::16) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|CY5PR12MB6129:EE_ X-MS-Office365-Filtering-Correlation-Id: f7206646-b6d1-4f67-d692-08dd2ecd79be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: nP3GNKjxXyNTSlUTGmIG1P9OutP6OLaqBhSHG9pETCGU3f2S2aSDmVjRGth0n98Bk48oc3oF35hFeFpxQfXA7fecxgLSS5ycQ/5iphTwH42plN6y8joizfj/3XQ7DD3t5U27d8S63a4Q9EFccDjBP+BuDnxb6KpezXKMei/NNuZ7zj1MFXz1vnd2R9cVsw/N60DPgkEOzLuAUXMMu8uMUpG9XcQo3iqt+v2GWwjlX9gmJy2zv2VII7n2TdRbCrxF9gdVSAnGobw6bPICS3siLP9fem7SZjHDdMBTCnfFu5RFnWii87v1qlR5COqPA6R/bfYeRh7ZoFgNMaBeQw6rxBLcQP71/Gcb2nd5uZnsQ6YYF5QKgoTDS+EvG81DV/5WsMlZnPlZuw+zkUwMg/NYU6pUbYS9XERUt52IrDzVe/8Uf1NivIUFwHBYocCfhXPgeJENBlRMXGHdSjtDjwy+gf8sOZUvA6ue+G9jIoa3HEUOaxT9xD1llasUa5Qq9nVAnkOeuYh+7LjXDsIB6amZ+CV93jJZCPKLzNTYfLfvk5fTaHD/suUik9o/9oS2/rpomZ5ltOHLI/y1199wl0rvYePPVCFqfXZ6CGw9bXIzcZfFd/M5UiR3HqhD8oqhDB2Iyyp+cNorGgJKB83gO7ka2xSg2F00PTYigKlSF1WZb688KCIiEfUcr1q2foAHYzChhHpm4FzG0RPOYIB/S9lywFMkDtJtPkt3oFuz9mcmFYUKAlSuwhLtmqYycWMPDSiHpK/CEqbMym+mRKUpXZjWHKbbauA7Oavp1hrJ8TwYGZ1R6ieck/Fm9Im49lpoY1boI8FPo3ygT9D1u5SnD1fnB6aeq1478R78otD2zmazrgz9EflXN2oHPbD/tblsO65lFBzsH2yaxr2WN62AmYdDdrzCOAhZlEsws/8AXNzzjcu0Q1W7SR/tCVV/wZtakukeYuNKYJXYt+MOtwNzYubHgFUAK91j8KxmoqjBYKFaDagXOasavTshE8mUAi5lvcZcDpyllRW51nPuydQTZ1NpkQLOu4LvjQxjx22jUKW5NOyRgJigyZSc7G419EYNWZGvUZrMHN35A8SuHJQ9knQKImVPM9aJh+v/sxlylBGmJKaUvLG0lCYpnUqwkqIeKZUCR5l66+sEEFt0ENOpxjzIwdGgaW3/bzzrX/DIuBr73ZpEQKulw+VM6OmC9FO+myt3RJgHO86zL/Sh0BHY75fKe/HZJORJbzi0v7m+ok3HHCfDbcX2+vJ8QUa5Z8r5zHe3PCJWUVxY7yBfuFa0BdnxCKwZaaN1+F6ewYC5Y5/DG+oxSecGqCmn0I87zoGbzuRDE6M+s241vu6Z9d2GJHTmaLPd9lmuvz1BoZ1QuTN21yseKCO855HHLuVEwGrII8b3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: SNwJhUCZJQl7L6DYWcq5HrgRzQDzpOwBaUxCbd9PAaooiTKkog5OdH3wMLuoKxcyz2k+iZJyIOL1jY8NHm00lMxU/IVHu/kz3AY+Bxf1DynK7OQaAZ6UvWWX0soZUweMakJeqA5UmPdrlk3TkJg/xSByK44vT6y7UdKxcmIGEB5glTmNE0K3a0YoKSgUNKIUM2v0xJiGxtoS2kwV+ARyirrumKn4Zm7d9aobmK717lMzimAvQWbRcxqpm3ODQ6xNa3SMNDEC4Y/VbplBsvE43zQTie1tO09bstdDlI6kDn2chPp5XL6UqWxCnXBhEIUg2QlDaLs5QuZa0wdCy2Ul/sYeOcPemVJPN1lhKv8L57VNpdU6MA1xTOa7Ooktpz15HMImgGTlGcxv/2sICL4lzPsCt4KASL/kAvDolck03vOZfpAVM6yD1AbJneRY6TZPDrkwFgJSBbEA4rJgEGO9TksF7Hb/JakLzF8/H3Y+cDv4eao6Mo5p0rjAm3upBnEUsmQVfTdw1dZ3hhKBHbEmIcZL5hUDut17mFCAa5trPvnv18TVL19BacelyFf/7NYV8tE5J3YLFtgA2CBQ0JxXUH/AKI6ql6MD8zyhk81h2JxZsvK54xLW7P9M4ekUACWguSColol8NLVcE7GT9aoEssPUMWQ24qFqJvfP8wkYGJkZDJ+YE3xjGtz3+PJ3MnNfDNoNcmB5CuwAyg+hF1U1pP7637v5BzMjSiVPScY3y1uZ6cD1ox0SSyB3IqwCvYLrIh6IKifP9P5zoIKU9Eraw4VcgFB/NWSeQVA51Iq5vhWLOUoXZbyr42Fc8153eMr/VomZkV+nbNjWUSRZwPKXdIhvJTmYu9jEAHyHxx/oaKE9PywyXRj4fcQ4wKot7V30MCqZjNls1El5EY4Ssc27xQ8nab8/dbUW72eLYBa4O72jpaCkJHvIYK1jw0GXw0oxL/ocuJzSxp3LX+B7UxADz4IbAF53daYtbPWC+zCMH00r9ZK1NQ68mKQp1a/6kwN63z1CSazfXCifctTxtfzl3Sn/+UbvIBR4Y6lVjRuHfqG923j6IQ7T9rPpfoGMoBzHBlTucOxHq84BTWUWfU70XIZuqqLU7amAMLjA2qr6OaQPjw7ueHZPha74DfiML3KKh8gT9o1NoPvE9vTw7HYbSbGoZh1ixXoob++h+zYThlqsKy+brpKIdwPkkWhFKK1j+n9JVbSJAkIcXDx//jDzKOD1Y7BE53ZF9M/hy+Xt/mC66oeJHGPVnf3Db+KHPYQKDFftEkYXLEGeVjFIjH/13QaEnMPvkEH4p4yKwEEiev3n57QWTkhxxck6Br58P+eFTa9P/71TNPlKCGdFH2x0Fwwt6iJkJTrGdwgFhoXyv0pV+PetkQkWlRy1gJTlfIMxL0tjghgm64yUJDFwGWODCAe4cX0FvB0tHH/L0r2Qslw1o0SCf5+6OhW7lZJv4VxZyKwDmDMlfg9B3XrYVvokbsjUqLc7dF4T2ZS+6FFRzBChU+28gpDI2zt9iCSF36qmsCHDSTCigzig0VlE3T/RNN+p8wspuvyOqPvon4cIsCAYZpWXnZgaVUUivS8V4OtF X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7206646-b6d1-4f67-d692-08dd2ecd79be X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2025 03:43:40.5419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wtiQWG7NozZG5CaXlhXKa4fUr1rWOh6N0JNHUk+ErRkkbe9aWMZMtTO1KijAKiXCXNex+qY3FbKXCNKrKe5YUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6129 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2782AC000A X-Stat-Signature: rpaz9qnsaa9nric15xa4bta1poc48hz4 X-Rspam-User: X-HE-Tag: 1736221427-855404 X-HE-Meta: U2FsdGVkX1+ezoNqgyURt2as/azGNOthZaEjdRq/+3kv9pB0rKI/4PmeR05rl3pEBBwLYAhXr6ZWCpd234FJa647Src21n8J0Z/MqD21jNCiwFwQtGcLuX/7mE6q9u3B93YRA+SRmkSAkjs2i8KMycQRx1RstgyWFBfEoK+Ge5ht5g8SonWRvMQD22/OgnkD92t2bdWQVZ6Yz/4MQ1r0ep/a0xUUOT18LvgGbApfWJZ1UtGF8DO/vjZikKWgFNUl0fxTSu5G/ZPz8SDoSqSA0KZ7KLXNtUUGp0lp1SIT+YsTHBAeTYc7YCOQQTNVBj0lJzOdgN/RO64JFHaC5H87JJEYl+9cSc34Rb8MBcB4GLRBIFkTcwI4hqOmV7A41OdpdDV7uVuqjAuQyW3Jk9loDz39PR9g0y3+jspdNjXG5FcbyBdnw6y5vGi4lEm2V3jLt3YAO9rFPOnWejwrvIjQsC+pKJN3qmLTgKHVqhDwxZ++KW/aoX+lkOFYecy4+jgD89tgSmBx/MNls9QG72yIBzysSNI19+7yyEsYO93fVJ+1upqNIh71N6IKT3ZIA4PKttht6rNKW5TPfurbHt3ahj2RKSxSelEA9VeviZH6IhjrkzW34pC/luwcW/iBRnw4aa92XPy15be1jpSBfS3rHubbnnMPmP8eAJyFZi2m2Plie4K19cd/5bmvJVDc9TlP6X6MlJ3oFsEplZ061QTiaMfDF4uWmSchfYuEnFkxAFz4XkiJl/9UV3MFwNs70HsZUZuCHqc1/Tj5RYsPmqlN3OFpJnl4zN3lR/Qf8FcKrntIAZPJqiVmWQQ5QAEpT+roOf9mt1kgsDpe2l6ax/rx2F2SdkcuicqQWBu398e3l14EkClqAfzybEtRhKfI6xxa878Ys96p94eM0Gk/+ImIKAUs8t9T4JK/hzVubnnjBF8Ze1BmpLiQ27E4cd7OIg998JnI09ZGBgMehdspKN3 j9ttX1X9 ByUQgu/mTzV4pkv9zV0B2cU0/i/O/fAegZ6uJDKYAPInd2fVMX6ixdlwMTcHYnwTBarb4NaPDqYgA09qGcst6FErKP9FJGpl7qmLkAmYhMGvk9wJqhMqi9rv8ZssV0Hx1R8vriSS5DLnl//teZY/OV0xtpkYy5c1kkbPJzs8E59TXBbZ7pQ0EzYiQGrQjKZ80rvcUFR1PN4V7F8uKolc6nJRWlfcdlIrIkEeaHaCTzpIeOVjD0jQ8R8MJjzoGmhoP9yownFr4gPEMHcWlc6JdLbd4AwiCFXep/TLdO7AJTXphmI/pYCdhvS39/NuNW2+gJGnQ+5XaHAGyt1MWwVgt6fcn0nm0eF4cWrKylP+Km1kbsltx4hOT7PlbYIWsTEiKjY9SKtBQJAZx5WceGxVDg4g4O9OTxrb9dchsc7Zn7gFDTgdqZgpX0iqmxRRLzD1NTwkyDqpqi2IVW3s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
fs/dax: Fix ZONE_DEVICE page reference counts
|
expand
|
diff --git a/mm/gup.c b/mm/gup.c index 2304175..9b587b5 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -3016,11 +3016,6 @@ static int gup_fast_devmap_leaf(unsigned long pfn, unsigned long addr, break; } - if (!(flags & FOLL_PCI_P2PDMA) && is_pci_p2pdma_page(page)) { - gup_fast_undo_dev_pagemap(nr, nr_start, flags, pages); - break; - } - folio = try_grab_folio_fast(page, 1, flags); if (!folio) { gup_fast_undo_dev_pagemap(nr, nr_start, flags, pages);