From patchwork Mon Feb 13 11:59:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Huang, Kai" X-Patchwork-Id: 13138312 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD6AC64EC4 for ; Mon, 13 Feb 2023 12:01:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B2FD6B0083; Mon, 13 Feb 2023 07:01:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73C186B0085; Mon, 13 Feb 2023 07:01:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56B886B0087; Mon, 13 Feb 2023 07:01:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3F2266B0083 for ; Mon, 13 Feb 2023 07:01:42 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 196D01615BA for ; Mon, 13 Feb 2023 12:01:42 +0000 (UTC) X-FDA: 80462129244.11.3E8D33E Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf18.hostedemail.com (Postfix) with ESMTP id DCCF41C0029 for ; Mon, 13 Feb 2023 12:01:39 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QHD6uN6n; spf=pass (imf18.hostedemail.com: domain of kai.huang@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=kai.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676289700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RdfcsHWDVDtG1P+CRifyEeWTxdd0FDIz6IgiWxp1zAw=; b=l8NcO3yYRvlqr0betwkO1sq+vWtRW8OW4rI8lwOYcUWtWMTC5aDregfOPKvGmQdnkaIGnt kQf17nucBPze+TJInvtWJbtUDDz7V2J5hf92+QUvi8YVP1t1kGJyz+ZmorQsi9G72BIdfG pyreP24LFbJGMhMRGx6MPTPCv+Wc3HE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QHD6uN6n; spf=pass (imf18.hostedemail.com: domain of kai.huang@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=kai.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676289700; a=rsa-sha256; cv=none; b=5ZiDUXNS5CgjDF1T44bSLwbSvt7nZzNbq89bKGV0SWFsZycBkIFcykvPE2oJl7s1QIg3nJ PqeUPihdyfL3cFP6KN9KLVEB4dH8oJYM6tpBffrylBqkZDnflkH6pFWxTiju12uxX/5bo4 uGLZtp372DvrXNERpUyTUcHKsbQWzHI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676289699; x=1707825699; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TGDot2bjHCtuoG3UVHU78PX2clfks7hjsOzbIQgZuuE=; b=QHD6uN6n7rKXB6zJuhLbymE83NeqkuC3PKW6iVuefQh9aVPlcp0INgR+ SXjzScrTBrcle+/x1uy9oTWXWXHoBSwm4J+AiU4pOKdHG2v3Sbt6yWCrq NUErm81CPuozv5b5/sLE5dLnQj5OZVOQvrfkOOoAnwoivcIAZqZzIuhay fVDPbVy8TO0RFm5yCz/5mz5o6e2lDzM391NUNS3VWQRjOeAYSOkGBYazk FQ0zGv67+Gcgaz5seMzDHzoT3t537uD73mUmgIZeFwWKUwcsX+rS1E4xr Yaf2YzUCxVJhA/DQlFwIDzs/ZJEhKPK5z33oof3pcpG8oaQRC34CrbC3J g==; X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="358283510" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="358283510" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 04:01:37 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="701243539" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="701243539" Received: from wonger-mobl.amr.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.209.188.34]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 04:01:32 -0800 From: Kai Huang To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, dave.hansen@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, david@redhat.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com, kai.huang@intel.com Subject: [PATCH v9 16/18] x86/virt/tdx: Initialize all TDMRs Date: Tue, 14 Feb 2023 00:59:23 +1300 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DCCF41C0029 X-Stat-Signature: xz6ik5ttg9c6awfamxm3a9eo1tmosmfa X-Rspam-User: X-HE-Tag: 1676289699-532315 X-HE-Meta: U2FsdGVkX198G/QSRS+W0J3N6ide/ZKrU5zySL8pN54kNHf4P184p/e709byPhfJjHQTViwo3E2FlVVWPoXpGY2WQqNa0EwTNtJtCkB3jgX2JZEWz9QQpB1bcWZ/Yrj7KrkJGZylElKP+ggu0ahSLfmJn7wecKVcnC+vT70IhMtaIZs+b/hndqtxcWyTPjcbxuYBSRuCxowo8q3eGj5daCxzgXm9w/A4QtW9Yic7dRwM3QXGWRWOpsEvZnMRYv1MydU0obuQnZuugZ2fTv020cb+tGqUDHkHzMYbB+7ybtYVqYzusZfips1vujB6Ld/BJ2oQhW8EN8YFGkNlcUNjqUJzzY9+KHlSDVl8pN79oq0fREh+f0tvxPd12e1iRhuzgWybNx5eizeYj2XUwWfMhi0dD3VSq+dL3Xzo/1Vc9WVOqIM35jfUQ8eUsA9IdhopqnQ2NT3osQTftc2aAhM1JjtuErvW8E58r9uH/GxH4PLiDE+zaJ2NPOBeKpFbg5OtMF/m4oHAUq9pYWojk2OTJ0IW2YQ9t1P/HpAnyM+2ZAQffp3rg9/j7F4Nc5C26Z0Y2k1DycnoGPutYLsiDh0Iwk2Gl0v5dqnpjCA24F4kuSmNQ4LPtYvmuBqdf8+n3V3seEaDii5FD055NtTJXVqR3UVb9v/2yHqUj+WpJrQJzCOmANt+UFt/yRUGeejFIgMcQ268AOOKaZacfRRh2VH8iu20eMWEYzyakqyTZkWSP2PW3f63cVgK6JD57Nrsh3ZMy3jytBFXu+2kFWXfPl5oc2jBlW8hNA66EdX9z4lpVl0hmPIydTLx7+5s0U6hLQrMtkhdzme5bEOt6kkNSjCkRqCUiySx+u3ZzsOVlr7AlvH/Xk768/vubkvJMpIHteHmuw5UevzpI9M2kJOMO2lDqVc7psX+4VUO8J/szr5IhMEu9N8dfLV0moYs6LCglf+kylfk1i27350p6g0jZHd CJwHFa8V whaYkSM0sTXL+AFXiBvbh7gLsy6XFQPTwrkrPsyNiIhIRrq/H0yJz67HbbPA7N1T0HD98SXw99+V6mO5sfH/mMSZosArwoV0s3QJDPtYbr/85qOUs0nLGRLY1wPnOS2k66WXCt2PZy6NeXre5OvOLee1bxQw5DH2Owud/W3Jovxc0ub0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: After the global KeyID has been configured on all packages, initialize all TDMRs to make all TDX-usable memory regions that are passed to the TDX module become usable. This is the last step of initializing the TDX module. Initializing TDMRs can be time consuming on large memory systems as it involves initializing all metadata entries for all pages that can be used by TDX guests. Initializing different TDMRs can be parallelized. For now to keep it simple, just initialize all TDMRs one by one. It can be enhanced in the future. Signed-off-by: Kai Huang Reviewed-by: Isaku Yamahata --- v8 -> v9: - Improved changlog to explain why initializing TDMRs can take long time (Dave). - Improved comments around 'next-to-initialize' address (Dave). v7 -> v8: (Dave) - Changelog: - explicitly call out this is the last step of TDX module initialization. - Trimed down changelog by removing SEAMCALL name and details. - Removed/trimmed down unnecessary comments. - Other changes due to 'struct tdmr_info_list'. v6 -> v7: - Removed need_resched() check. -- Andi. --- arch/x86/virt/vmx/tdx/tdx.c | 60 ++++++++++++++++++++++++++++++++----- arch/x86/virt/vmx/tdx/tdx.h | 1 + 2 files changed, 53 insertions(+), 8 deletions(-) diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c index ff6f2c9d9838..c291fbd29bb0 100644 --- a/arch/x86/virt/vmx/tdx/tdx.c +++ b/arch/x86/virt/vmx/tdx/tdx.c @@ -1086,6 +1086,56 @@ static int config_global_keyid(void) return ret; } +static int init_tdmr(struct tdmr_info *tdmr) +{ + u64 next; + + /* + * Initializing a TDMR can be time consuming. To avoid long + * SEAMCALLs, the TDX module may only initialize a part of the + * TDMR in each call. + */ + do { + struct tdx_module_output out; + int ret; + + /* All 0's are unused parameters, they mean nothing. */ + ret = seamcall(TDH_SYS_TDMR_INIT, tdmr->base, 0, 0, 0, NULL, + &out); + if (ret) + return ret; + /* + * RDX contains 'next-to-initialize' address if + * TDH.SYS.TDMR.INIT did not fully complete and + * should be retried. + */ + next = out.rdx; + cond_resched(); + /* Keep making SEAMCALLs until the TDMR is done */ + } while (next < tdmr->base + tdmr->size); + + return 0; +} + +static int init_tdmrs(struct tdmr_info_list *tdmr_list) +{ + int i; + + /* + * This operation is costly. It can be parallelized, + * but keep it simple for now. + */ + for (i = 0; i < tdmr_list->nr_consumed_tdmrs; i++) { + int ret; + + ret = init_tdmr(tdmr_entry(tdmr_list, i)); + if (ret) + return ret; + } + + return 0; +} + static int init_tdx_module(void) { static DECLARE_PADDED_STRUCT(tdsysinfo_struct, tdsysinfo, @@ -1170,15 +1220,9 @@ static int init_tdx_module(void) if (ret) goto out_free_pamts; - /* - * TODO: - * - * - Initialize all TDMRs. - * - * Return error before all steps are done. - */ + /* Initialize TDMRs to complete the TDX module initialization */ + ret = init_tdmrs(&tdx_tdmr_list); - ret = -EINVAL; out_free_pamts: if (ret) { /* diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h index ca4e2edbf4bc..4e312c7f9553 100644 --- a/arch/x86/virt/vmx/tdx/tdx.h +++ b/arch/x86/virt/vmx/tdx/tdx.h @@ -18,6 +18,7 @@ */ #define TDH_SYS_KEY_CONFIG 31 #define TDH_SYS_INFO 32 +#define TDH_SYS_TDMR_INIT 36 #define TDH_SYS_CONFIG 45 struct cmr_info {