Message ID | fde443d0e67f76a51e7ab4e96647705840f53ddb.1738686764.git.maciej.wieczor-retman@intel.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0C5C02194 for <linux-mm@archiver.kernel.org>; Tue, 4 Feb 2025 17:36:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 140EB280004; Tue, 4 Feb 2025 12:36:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F1A3280001; Tue, 4 Feb 2025 12:36:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB229280004; Tue, 4 Feb 2025 12:36:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CB40D280001 for <linux-mm@kvack.org>; Tue, 4 Feb 2025 12:36:42 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C8CEBA0C7E for <linux-mm@kvack.org>; Tue, 4 Feb 2025 17:36:30 +0000 (UTC) X-FDA: 83082966540.10.2D9C30C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf10.hostedemail.com (Postfix) with ESMTP id 6BD59C0019 for <linux-mm@kvack.org>; Tue, 4 Feb 2025 17:36:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QJJdt2Pa; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738690588; a=rsa-sha256; cv=none; b=rxE3jSPmGSSCqr2NNUQ7GGcWednAf5egqPb9U9Oc4CJiM0In7QWi97J7kd3ra4tg9SBUou b7yNI1R1gyeLDWeSomEgITo/gTnGdpb9NOYZ9gXwUUbaToSOgF5+a+0mKMtY0zYFGFmj+U mSzCiPZRB3/4ELo05DLEKfIOtH0jR8A= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QJJdt2Pa; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738690588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OjOreTL+Ot1aK4xRTqvixmr6X+5Hdo5QfDrtzsBAFBk=; b=n+HFg7sY4kJ+WL4xOG5uiaZjtp2Nqt7c4AYG6yCYLnHRpDmJ6sy0NjHAVr5vthv+Vt5SC9 eG1Yc+e3CuDXLrt92JeRWPAWuBVzsFfF6+7bqIHuvL8niq8JflQbZSMN6l6tojmRhujDXO 7FVOkmXhS41epYXgr+oUYPafPCi1x7c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738690588; x=1770226588; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZPDKrg9roFM67mEQ2fI48/uwWPYPBpbE1ZWp7rfkzQw=; b=QJJdt2Pa5SkVFcYXoKE9T8aJKEjwDs3ohZukkt8mZCqeMpk2OQtVBxwF HYyiQy1lHeez6Bs5WKdQA/qKl+mwaloknEDAj4LeXjeLQk75SJu7rh1rg oKB1KIMIZEEFQ+up/yCX7kTqkFpFcHZ66Rv0dt2FHfVOLqHKwxETCK9Ds wv/RsnQA4O3PwckiTyPaUeXQ9WPnPK0rV35hnhpCT9J5W1lebE/qQxsm/ 8ExrFYMmggdnNgMdRHb2WgbU8XH4ugsYcpIJiFyh4cXhOf90h9tDbIj/0 X2ic/PYhxrcD01oinVTK8xpp6RGkezs8h3zkb7ktzZTlySuQmbzOkBzOf w==; X-CSE-ConnectionGUID: O59URw+GSReF5jOJU8kj+g== X-CSE-MsgGUID: ZRUd77SSTfa10iykTY0YYg== X-IronPort-AV: E=McAfee;i="6700,10204,11336"; a="38930858" X-IronPort-AV: E=Sophos;i="6.13,259,1732608000"; d="scan'208";a="38930858" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2025 09:36:26 -0800 X-CSE-ConnectionGUID: jXIRAGRVSi6AV3rBRiAebw== X-CSE-MsgGUID: yAFfDOxmTeCrIA01iFfVXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="147866806" Received: from mjarzebo-mobl1.ger.corp.intel.com (HELO wieczorr-mobl1.intel.com) ([10.245.244.61]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2025 09:36:14 -0800 From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com> To: luto@kernel.org, xin@zytor.com, kirill.shutemov@linux.intel.com, palmer@dabbelt.com, tj@kernel.org, andreyknvl@gmail.com, brgerst@gmail.com, ardb@kernel.org, dave.hansen@linux.intel.com, jgross@suse.com, will@kernel.org, akpm@linux-foundation.org, arnd@arndb.de, corbet@lwn.net, maciej.wieczor-retman@intel.com, dvyukov@google.com, richard.weiyang@gmail.com, ytcoode@gmail.com, tglx@linutronix.de, hpa@zytor.com, seanjc@google.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, justinstitt@google.com, jason.andryuk@amd.com, glider@google.com, ubizjak@gmail.com, jannh@google.com, bhe@redhat.com, vincenzo.frascino@arm.com, rafael.j.wysocki@intel.com, ndesaulniers@google.com, mingo@redhat.com, catalin.marinas@arm.com, junichi.nomura@nec.com, nathan@kernel.org, ryabinin.a.a@gmail.com, dennis@kernel.org, bp@alien8.de, kevinloughlin@google.com, morbo@google.com, dan.j.williams@intel.com, julian.stecklina@cyberus-technology.de, peterz@infradead.org, cl@linux.com, kees@kernel.org Cc: kasan-dev@googlegroups.com, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, linux-doc@vger.kernel.org Subject: [PATCH 09/15] x86: Physical address comparison in current_mm pgd check Date: Tue, 4 Feb 2025 18:33:50 +0100 Message-ID: <fde443d0e67f76a51e7ab4e96647705840f53ddb.1738686764.git.maciej.wieczor-retman@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <cover.1738686764.git.maciej.wieczor-retman@intel.com> References: <cover.1738686764.git.maciej.wieczor-retman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6BD59C0019 X-Stat-Signature: 1wy46edaeis1dtgfsywpfw5en8meewzu X-HE-Tag: 1738690588-436473 X-HE-Meta: U2FsdGVkX1+9gVpB8LHTW0oUHumb+GFx3vUTJhLdKPC4PFSmbjmU7z1gxv/g9Ic49B5crsXOZWbBG0VGfwUP8htIdeGFgrPm2AFeOKHx5y1JlXqdffF97Mj+zp9Nvsy0FL7ATD3jWQWgHf7AmhQiX6eonOEndZKdF1LiUOHqteIBicqRmiFnBZeacCv4Jm1qznIR9t02ZcltovA05t+K01btiw7qlriEVhdnflDlasA9D0Cz8O8Rd07Lp2X3StkwuxMEmCa43jCU25GBNuPu0PvRba9Ei4jblgVAfSBtL7vNFW3oM74lklO1HbhWxgr6WDhkxD6mFBuqKcVX8GEGcFLeBFIvDsYLrCpSRPg0M7L6MZb6Mtrt/+EB6zP1TCHngANoFkGDeQvG5uNnsoZhdmzptxoPgtOz1D+x/i7qLeUKtTw75JP7tVctTZzGTY8y0LQXF9nNB/iSVnwHfd+ahRlGNss8Q7sOlg/i2MHe/9q6aXboXwUI75YeBC/URQIJeSLhvu2ePs0ePVBG1yTY5OQoURzUkRffrrC+xi06pK1XaQ/m0jQiwfus4Zc5M7Rub3NmRG7/xUZ24GlxdDZ3pu87gedZMjHFk1Lb2LrlDTvv9gSuA4TYbA90IN5uQ4HeRYD3HDT4/Ty7yRi2aLHGNIJ0CdpzniWeWpoiWjztNEm7QPauIwscXdVuAx0PEVbXGPan58Ppez2TUVH4bu1/5MnYe6NoWj9sAts9a2yTWK+7vOe2mviwjZz/R4qzpo/u6DFIpj2wtg5zDxd0BHIypKeqE+d1mPt9fkKGnvRwwvHVEs8EBVIwaiI7FPFlsWIy3xXPmda62atNUI4myT8vuZnJlC6ZssK9Np7xRBNit+GyzSqHRBKOaD+43VWrTbN/TWGaba+tWZMdjwiW1AAiEIIF9qqr0s1qL+He6fICSucFF2eOJ5GJJjPSlYGl/CEU0lXpxwr2ZIUbTUddnTI gQ3cVTw5 zl7z9Rmg1xTReTy4cGyyRdZx2AczlbR18LTz2PQHVK5cPiylI8HYZo2bX1pRN8K5DA4X4XLy7QoigBDJdoLw30LlxYAf3kxp1m0ompTqYZtRJISR0jBPotmP/TP1CzTTB2rbzfoQi5HMUxErjhLPhGDG1jaqV2O4XiIBwqchNKatv3TDINMKo/eWeO5k0SahBqdEFZudaCh19gxtopGtQg3hXvMIFGjMOkUxYx2+zUXqMwPK3Zp2z/vF/O9YEN3jJOSwELMJ8gbI8DodU3e0le2muXgT+F1wMEoSHGJCR0lPZ0hs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
kasan: x86: arm64: risc-v: KASAN tag-based mode for x86
|
expand
|
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 86593d1b787d..95e3dc1fb766 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1295,7 +1295,7 @@ bool nmi_uaccess_okay(void) if (loaded_mm != current_mm) return false; - VM_WARN_ON_ONCE(current_mm->pgd != __va(read_cr3_pa())); + VM_WARN_ON_ONCE(__pa(current_mm->pgd) != read_cr3_pa()); return true; }
With KASAN software tag-based mode enabled PGD pointer stored in current_mm structure is tagged while the same pointer computed through __va(read_cr3_pa()) ends up with the tag space filled with ones. Use current_mm->pgd' physical address and drop the __va() so the VM_WARN_ON_ONCE can work properly and not report false positives while KASAN is enabled. Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com> --- arch/x86/mm/tlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)