diff mbox series

mm/mempolicy.c: include pagemap.h directly

Message ID tencent_38F9530F8D11EC9B038B77AE97E73145DA07@qq.com (mailing list archive)
State New
Headers show
Series mm/mempolicy.c: include pagemap.h directly | expand

Commit Message

Junjie Fu Dec. 7, 2024, 8:14 a.m. UTC 
Thanks for the review and suggestion. I agree that depending on indirect
includes isn't ideal. This patch followed your suggestion and now directly
includes pagemap.h in mempolicy.c

Signed-off-by: Junjie Fu <fujunjie1@qq.com>
---
 mm/mempolicy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matthew Wilcox (Oracle) Dec. 7, 2024, 5:14 p.m. UTC | #1 
On Sat, Dec 07, 2024 at 04:14:30PM +0800, Junjie Fu wrote:
> @@ -113,7 +113,7 @@
>  #include <asm/tlbflush.h>
>  #include <asm/tlb.h>
>  #include <linux/uaccess.h>
> -
> +#include <linux/pagemap.h>
>  #include "internal.h"

This is in the wrong place.  The linux/ includes go before the asm/
includes.  I like to stick to alphabetical order within that divide,
but other people have other preferences.
diff mbox series

Patch

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 88eef9776bb0..c3f25a7951e0 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -113,7 +113,7 @@ 
 #include <asm/tlbflush.h>
 #include <asm/tlb.h>
 #include <linux/uaccess.h>
-
+#include <linux/pagemap.h>
 #include "internal.h"
 
 /* Internal flags */