From patchwork Sat Apr 27 08:51:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: linke li X-Patchwork-Id: 13645597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67388C4345F for ; Sat, 27 Apr 2024 09:05:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD9716B0083; Sat, 27 Apr 2024 05:05:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A88B36B0085; Sat, 27 Apr 2024 05:05:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94FED6B0087; Sat, 27 Apr 2024 05:05:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 74DB26B0083 for ; Sat, 27 Apr 2024 05:05:27 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D817840AB5 for ; Sat, 27 Apr 2024 09:05:26 +0000 (UTC) X-FDA: 82054728252.11.9D3AB79 Received: from out203-205-221-155.mail.qq.com (out203-205-221-155.mail.qq.com [203.205.221.155]) by imf06.hostedemail.com (Postfix) with ESMTP id 1A04C18001E for ; Sat, 27 Apr 2024 09:05:23 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=EtUBFal1; dmarc=pass (policy=quarantine) header.from=qq.com; spf=pass (imf06.hostedemail.com: domain of lilinke99@qq.com designates 203.205.221.155 as permitted sender) smtp.mailfrom=lilinke99@qq.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714208725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=sHjG5dTObITpgnBpC3M6KzXKNedzHy80OgTnL62Ihkw=; b=fjVfPueN6Fxh/9/OSLFyXIiHpvjBvlf+RcJXl5oHFAHJ/WWI43ROBb/c6AW1hk2LyzZMnn OnNcf9gZPXYKOToejaNfaUgaXoQfVVnkEvzgKyk2NskgqqPvCPA+R6zpfb+EyUE966wD6w pF6VqultTqqOONUHUY7hcWL0cPgmkR8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714208725; a=rsa-sha256; cv=none; b=MXWqcE8kY9UTKAtYAO/i6fUjAFf6NaeddKDYU7om53rY4x7XkJwJYD1uG7M4z5HWvk2CDV 2t+2c/1smVtZDSOLNDReHLnawy5Rlq9UFhtxO+0xuiq6kNIqtXuZbRR8oZYB88xPxNymUf UjzBnhojVJJlatFgEL3fvj/Lk34Qb3Q= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=EtUBFal1; dmarc=pass (policy=quarantine) header.from=qq.com; spf=pass (imf06.hostedemail.com: domain of lilinke99@qq.com designates 203.205.221.155 as permitted sender) smtp.mailfrom=lilinke99@qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1714208718; bh=sHjG5dTObITpgnBpC3M6KzXKNedzHy80OgTnL62Ihkw=; h=From:To:Cc:Subject:Date; b=EtUBFal1S3K6qggroWezg0ZVrKMmuT0wpVF9rw0T25HrT/bpPm1C8AhGfj7oIBHZ7 5U6NYan7WCAQIG9q/KIR1idRQDvxtfzwbVbDwSeaD4PA4HDYUFmcjCdjvMJDaqBzVm zgoZ7/PBc+w838NfUpPZtUBSc5fMBLcLvJmZuRB8= Received: from localhost.localdomain ([58.213.8.145]) by newxmesmtplogicsvrszb16-1.qq.com (NewEsmtp) with SMTP id D0101220; Sat, 27 Apr 2024 16:52:01 +0800 X-QQ-mid: xmsmtpt1714207921twha7fb4m Message-ID: X-QQ-XMAILINFO: NMGzQWUSIfvTorIFbPMI2XNsr8ZOywSyWezSfQE1t1etn8KAMOZXaUAzyVQBaa 9yYeJiQPs2E3lCCKDYF3e/y3glKgqRFPETzrGQPiCog3jqd5K0clL0ESM/tUQGEH1+Xj/aLqsBK5 eu9q3y8egdqNTTo692J2q3RWzq9ghHMMySdQqJBaVmhrurOIa8HiqYwUtZ2jLVwudvlYUlAlJdJl /kZfkDmVOWnYZKBhAbGEuDo3WUn4IB5LEeu39HUS8DJ0in+5Ha4VJufQbqJz9Id3I96/9shDPMcl y/BbDHxANKRe5egZvas992gBHS9o6tzKMbBi2BS4iQDply0fUSGHmzrp6OKTfUnX3909tWs1oDzG erGNdrOkk6n3gJhwGgYC7bq6cNc+wSH/Qch/iwXTtLlySjjfG+rQeEd+hWdCk3IIfK8MLwwqdQ9U l5+NH3k1GNJOqbEB+kSF1TM86mnAuN84Nbs8c9fFKgQCkd9OcSARA0gl6WLr3fMHB6dw+zkxD4iv XuSgjh9a+GAbiAT9d2rHDNizchjhVV6vJINRypm07rmDmL0KQGfVhfHBuGahByUgKKANyU25LzYW 4NKdSULI42DkNGiWf1/HvPFV0ygBlAw9BoGAHvA+p2kIRODFTw4Eer0Pfx0himNzQAi6RHMdenZq HuJOwDxD0lYmBPCjudGJYf4J5jFrpMQk5okh5Tpl/i7QeMl4lqtoIZBgnnWrzcSZHTZFzjeWl9g4 W+U9kSx/erqOxJtez7shS6UFhB5gG9atlspWtooz+U121h6G/Ose5Yxikf5a92zB6kUH6ja8wB1C XguEAyFS1DsgYSa3t/bDrKwPw5emRrxexIZDHdeDUnxoEeqozD8T08CmQS2HYFG7ICQs49IFRwk5 tUmIzVgnE3pVsh2FL9DJmECQ/YIdRo3kRAyrYR5QUetISc5hmRdIxUQ1wkWILq7Hdk5hpsDoiz2A iFyRY6tbYafVR9lGNueabLZ21GjNcj1WQiH3n07WGmXidJchXR1g7tag9Erlms2inm7Egm/XsFIs aA9bGwK5dgOAen5YAt0mH7lFy9OhY= X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: linke li To: Cc: xujianhao01@gmail.com, linke li , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/slub: mark racy access on slab->freelist Date: Sat, 27 Apr 2024 16:51:54 +0800 X-OQ-MSGID: <20240427085154.33456-1-lilinke99@qq.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1A04C18001E X-Stat-Signature: pwps159jsmptourj36rwkcfs8zra1469 X-Rspam-User: X-HE-Tag: 1714208723-532203 X-HE-Meta: U2FsdGVkX1+CUrTzKpAYq0L46reczSNPzW+vXVhOoA6yp/NGwfSpg3gyqPBK6KnfK4jQbGr4kZCz/yqZRm5VoxVO4m4LvkejFoz+hXFPSO+xSCTzISZnTMeDU/IHoQ4isyRLQPrkz9zzEMofdRcuXuSgAmim4LCa9dGAgMVagRSXMd4gvUyfsTqWrppBf8rnktyIKEUhuLc6PxkPrSbPc9BRIjY911Ib6nQ5mJuY5ePDvsdlGDIHqjItySyCBP99Q//ee4tN7nLgAOznTfridOQCtGTXTk2yg+btSBvqbFnB9+mFb+B6ylUgWPwyjgqnyFM/LQ3oohfHjTDCcLyKveyMTrKoQjLuO5Lg8bofvyfD6O30B94a4vy9Cap2t/3ejBDKe6XAU6ltaqTrX1n4vLXrnHf1FEgEZQQnFptIfd1aZ8LpGbjb6KePCX7aw9gg9X9VTMTbHDvm+FhGW/hVcbPazK6ctJge9NbXKRTBC7rzaFIRSaTI2lEK8LSKVcvcbFyl5CEW2I2CzPOoy7MO/K3rkVfbXlALHEwdXezs0eAEkuXWORKpZwfLJ4SsGlyyEivayEunICwgZ/PuNaVBopTCPMn0it/t4ud2Cupg9n+7lYa5M53RqyEhWfvqrUShBv6UBWGZxtJBDVrMuRiGmuPhRd3TFq0r2AbolkQlO6O3u7KL6smk1oPB9Qe9Dfc15DZcnLrSWBgWB83l8pKeOz+nYhkdpIxaud3ivIQ3EmJYwh0wXn0an66lpWKCCy3DO6K319KBbp3Qe8xfHruW5h6U1AeGR9cEzJrV1mLRisAia/RerQXh8lrrPYCriW2YyGgDHFnGqvF/dPaKiBGMZkw1kkbme2EQteua4Kvd+A77R1EdhvTWsHVAc45dyzQuJtYTLDUKDhTKDlIpmDGu6xMlJ8ZuaSqEL/kykRnZ5iz7BAx4ypOy/M9AayOBCjJyVOWl8Kio8HOEvbCe37q MYb8PzWC LprvNkW8E6Kkb1QF7NTCyTHejO53zyqeCSU+kNbfvZ19zOuRKSiWk9o3NX2FHQIjpzNw0OAvfbv+pPQ963gEDkaX/g9ibszlNKZSd5LKtpWR3WoXj7AFswjCYEs85cvjOM/6JwSzZegrAMXOTuGJcIhDGdBXsHLc5DC+d3hLXaMHS80CGOYvZY0uZjT94t2AMwQvuPyjD4wZYuu9/vr40OcLVwK2L8n9BZJsEvnKKRc8vwClUAza4GUDmu90IrIQsdk6yP/0emrFvNMz4Lp00YczwiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.087758, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In deactivate_slab(), slab->freelist can be changed concurrently. Mark data race on slab->freelist as benign using READ_ONCE. This patch is aimed at reducing the number of benign races reported by KCSAN in order to focus future debugging effort on harmful races. Signed-off-by: linke li --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 0d700f6ca547..bb0e05a321e9 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2813,7 +2813,7 @@ static void deactivate_slab(struct kmem_cache *s, struct slab *slab, struct slab new; struct slab old; - if (slab->freelist) { + if (READ_ONCE(slab->freelist)) { stat(s, DEACTIVATE_REMOTE_FREES); tail = DEACTIVATE_TO_TAIL; }