mbox series

[v3,0/2] mmc: sdhci-milbeaut: add Milbeaut SD driver

Message ID 1568079631-28808-1-git-send-email-orito.takao@socionext.com (mailing list archive)
Headers show
Series mmc: sdhci-milbeaut: add Milbeaut SD driver | expand

Message

Takao Orito Sept. 10, 2019, 1:40 a.m. UTC
The following patches add driver for SD Host controller on
Socionext's Milbeaut M10V platforms.

SD Host controller on Milbeaut consists of two controller parts.
One is core controller F_SDH30, this is similar to sdhci-fujitsu
controller.
Another is bridge controller. This bridge controller is not compatible
with sdhci-fujitsu controller. This is special for Milbeaut series.

It has the several parts,
 - reset control
 - clock enable / select for SDR50/25/12
 - hold control of DATA/CMD line
 - select characteristics for WP/CD/LED line
 - Re-tuning control for mode3
 - Capability setting
   Timeout Clock / Base Clock / Timer Count for Re-Tuning /
   Debounce period
These requires special procedures at reset or clock enable/change or
 further tuning of clock.

Takao Orito (2):
  dt-bindings: mmc: add DT bindings for Milbeaut SD controller
  mmc: sdhci-milbeaut: add Milbeaut SD controller driver

 .../devicetree/bindings/mmc/sdhci-milbeaut.txt     |  30 ++
 drivers/mmc/host/Kconfig                           |  11 +
 drivers/mmc/host/Makefile                          |   1 +
 drivers/mmc/host/sdhci-milbeaut.c                  | 362 +++++++++++++++++++++
 drivers/mmc/host/sdhci_f_sdh30.c                   |  26 +-
 drivers/mmc/host/sdhci_f_sdh30.h                   |  32 ++
 6 files changed, 437 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
 create mode 100644 drivers/mmc/host/sdhci-milbeaut.c
 create mode 100644 drivers/mmc/host/sdhci_f_sdh30.h

Comments

Takao Orito Oct. 1, 2019, 5:17 a.m. UTC | #1
Hello

Does anyone have any comments on this ?

> The following patches add driver for SD Host controller on
> Socionext's Milbeaut M10V platforms.
> 
> SD Host controller on Milbeaut consists of two controller parts.
> One is core controller F_SDH30, this is similar to sdhci-fujitsu
> controller.
> Another is bridge controller. This bridge controller is not compatible
> with sdhci-fujitsu controller. This is special for Milbeaut series.
> 
> It has the several parts,
>  - reset control
>  - clock enable / select for SDR50/25/12
>  - hold control of DATA/CMD line
>  - select characteristics for WP/CD/LED line
>  - Re-tuning control for mode3
>  - Capability setting
>    Timeout Clock / Base Clock / Timer Count for Re-Tuning /
>    Debounce period
> These requires special procedures at reset or clock enable/change or
>  further tuning of clock.
> 
> Takao Orito (2):
>   dt-bindings: mmc: add DT bindings for Milbeaut SD controller
>   mmc: sdhci-milbeaut: add Milbeaut SD controller driver
> 
>  .../devicetree/bindings/mmc/sdhci-milbeaut.txt     |  30 ++
>  drivers/mmc/host/Kconfig                           |  11 +
>  drivers/mmc/host/Makefile                          |   1 +
>  drivers/mmc/host/sdhci-milbeaut.c                  | 362 +++++++++++++++++++++
>  drivers/mmc/host/sdhci_f_sdh30.c                   |  26 +-
>  drivers/mmc/host/sdhci_f_sdh30.h                   |  32 ++
>  6 files changed, 437 insertions(+), 25 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
>  create mode 100644 drivers/mmc/host/sdhci-milbeaut.c
>  create mode 100644 drivers/mmc/host/sdhci_f_sdh30.h
> 
> -- 
> 1.9.1
> 

Thanks
Orito

-----------------------------------------------------------------
Takao Orito
Socionext Inc.
E-mail:orito.takao@socionext.com
Tel:+81-80-9815-1460
-----------------------------------------------------------------
Ulf Hansson Oct. 3, 2019, 10 a.m. UTC | #2
On Tue, 10 Sep 2019 at 03:39, Takao Orito <orito.takao@socionext.com> wrote:
>
> The following patches add driver for SD Host controller on
> Socionext's Milbeaut M10V platforms.
>
> SD Host controller on Milbeaut consists of two controller parts.
> One is core controller F_SDH30, this is similar to sdhci-fujitsu
> controller.
> Another is bridge controller. This bridge controller is not compatible
> with sdhci-fujitsu controller. This is special for Milbeaut series.
>
> It has the several parts,
>  - reset control
>  - clock enable / select for SDR50/25/12
>  - hold control of DATA/CMD line
>  - select characteristics for WP/CD/LED line
>  - Re-tuning control for mode3
>  - Capability setting
>    Timeout Clock / Base Clock / Timer Count for Re-Tuning /
>    Debounce period
> These requires special procedures at reset or clock enable/change or
>  further tuning of clock.
>
> Takao Orito (2):
>   dt-bindings: mmc: add DT bindings for Milbeaut SD controller
>   mmc: sdhci-milbeaut: add Milbeaut SD controller driver
>
>  .../devicetree/bindings/mmc/sdhci-milbeaut.txt     |  30 ++
>  drivers/mmc/host/Kconfig                           |  11 +
>  drivers/mmc/host/Makefile                          |   1 +
>  drivers/mmc/host/sdhci-milbeaut.c                  | 362 +++++++++++++++++++++
>  drivers/mmc/host/sdhci_f_sdh30.c                   |  26 +-
>  drivers/mmc/host/sdhci_f_sdh30.h                   |  32 ++
>  6 files changed, 437 insertions(+), 25 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
>  create mode 100644 drivers/mmc/host/sdhci-milbeaut.c
>  create mode 100644 drivers/mmc/host/sdhci_f_sdh30.h
>
> --
> 1.9.1
>
>

Applied for next, thanks!

Kind regards
Uffe
Takao Orito Oct. 7, 2019, 2:32 a.m. UTC | #3
Thanks for checking and pushing my patch !

Orito

> On Tue, 10 Sep 2019 at 03:39, Takao Orito <orito.takao@socionext.com> wrote:
> >
> > The following patches add driver for SD Host controller on
> > Socionext's Milbeaut M10V platforms.
> >
> > SD Host controller on Milbeaut consists of two controller parts.
> > One is core controller F_SDH30, this is similar to sdhci-fujitsu
> > controller.
> > Another is bridge controller. This bridge controller is not compatible
> > with sdhci-fujitsu controller. This is special for Milbeaut series.
> >
> > It has the several parts,
> >  - reset control
> >  - clock enable / select for SDR50/25/12
> >  - hold control of DATA/CMD line
> >  - select characteristics for WP/CD/LED line
> >  - Re-tuning control for mode3
> >  - Capability setting
> >    Timeout Clock / Base Clock / Timer Count for Re-Tuning /
> >    Debounce period
> > These requires special procedures at reset or clock enable/change or
> >  further tuning of clock.
> >
> > Takao Orito (2):
> >   dt-bindings: mmc: add DT bindings for Milbeaut SD controller
> >   mmc: sdhci-milbeaut: add Milbeaut SD controller driver
> >
> >  .../devicetree/bindings/mmc/sdhci-milbeaut.txt     |  30 ++
> >  drivers/mmc/host/Kconfig                           |  11 +
> >  drivers/mmc/host/Makefile                          |   1 +
> >  drivers/mmc/host/sdhci-milbeaut.c                  | 362 +++++++++++++++++++++
> >  drivers/mmc/host/sdhci_f_sdh30.c                   |  26 +-
> >  drivers/mmc/host/sdhci_f_sdh30.h                   |  32 ++
> >  6 files changed, 437 insertions(+), 25 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> >  create mode 100644 drivers/mmc/host/sdhci-milbeaut.c
> >  create mode 100644 drivers/mmc/host/sdhci_f_sdh30.h
> >
> > --
> > 1.9.1
> >
> >
> 
> Applied for next, thanks!
> 
> Kind regards
> Uffe

-----------------------------------------------------------------
Takao Orito
Socionext Inc.
E-mail:orito.takao@socionext.com
Tel:+81-80-9815-1460
-----------------------------------------------------------------