From patchwork Fri Oct 25 09:41:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 11211993 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1677714ED for ; Fri, 25 Oct 2019 11:09:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F34DF21D81 for ; Fri, 25 Oct 2019 11:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503697AbfJYLJI (ORCPT ); Fri, 25 Oct 2019 07:09:08 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:36614 "EHLO xavier.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503164AbfJYLIs (ORCPT ); Fri, 25 Oct 2019 07:08:48 -0400 Received: from ramsan ([84.195.182.253]) by xavier.telenet-ops.be with bizsmtp id Hn8b2100e5USYZQ01n8bmB; Fri, 25 Oct 2019 13:08:46 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1iNxSN-0003rD-Iz; Fri, 25 Oct 2019 13:08:35 +0200 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1iNw6A-0006mq-Ia; Fri, 25 Oct 2019 11:41:34 +0200 From: Geert Uytterhoeven To: Jonathan Corbet , Greg Kroah-Hartman , Ludovic Desroches , Ulf Hansson , Nicolas Ferre , Alexandre Belloni , Jaehoon Chung , "David S . Miller" , "Rafael J . Wysocki" , Johannes Berg Cc: linux-doc@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 0/7] debugfs: Add and use debugfs_create_xul() Date: Fri, 25 Oct 2019 11:41:23 +0200 Message-Id: <20191025094130.26033-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi all, The existing debugfs_create_ulong() function supports objects of type "unsigned long", which are 32-bit or 64-bit depending on the platform, in decimal form. To format objects in hexadecimal, various debugfs_create_x*() functions exist, but all of them take fixed-size types. To work around this, some drivers call one of debugfs_create_x{32,64}(), depending on the size of unsigned long. Other drivers just cast the value pointer to "u32 *" or "u64 *", introducing portability bugs or data leaks in the process. Hence this patch series adds a debugfs helper for "unsigned long" objects in hexadecimal format, and converts drivers to make use of it. It also contains two cleanups removing superfluous casts, which I added to this series to avoid conflicts. Changes compared to v1[1]: - Add kerneldoc, - Update Documentation/filesystems/debugfs.txt, - Add Acked-by. Dependencies: - The first patch now depends on "Documentation: debugfs: Document debugfs helper for unsigned long values"[2], which Jon said he applied to his tree. Thanks! [1] https://lore.kernel.org/lkml/20191021143742.14487-1-geert+renesas@glider.be/ [2] https://lore.kernel.org/lkml/20191021150645.32440-1-geert+renesas@glider.be/ Geert Uytterhoeven (7): debugfs: Add debugfs_create_xul() for hexadecimal unsigned long mac80211: Use debugfs_create_xul() helper net: caif: Fix debugfs on 64-bit platforms mmc: atmel-mci: Fix debugfs on 64-bit platforms mmc: atmel-mci: Remove superfluous cast in debugfs_create_u32() call mmc: dw_mmc: Fix debugfs on 64-bit platforms mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call Documentation/filesystems/debugfs.txt | 5 ++++- drivers/mmc/host/atmel-mci.c | 10 +++++----- drivers/mmc/host/dw_mmc.c | 10 +++++----- drivers/net/caif/caif_serial.c | 4 ++-- include/linux/debugfs.h | 21 +++++++++++++++++++++ net/mac80211/debugfs_sta.c | 17 +++-------------- 6 files changed, 40 insertions(+), 27 deletions(-)