| Message ID | 20200129203709.30493-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mmc: tmio: move TAP handling to SDHI driver | expand |
Hi Wolfram-san, > From: Wolfram Sang, Sent: Thursday, January 30, 2020 5:37 AM > > TAP and SCC handling is Renesas specific, so it should be moved to the > SDHI driver. After previous refactoring, this is possible now. And > feasible, too, to simplify further HS400 corrections. IMHO it also makes > the driver less complicated. > > See the patches why this series is still RFC. > > This is based on top of the series: > [RFC PATCH v2 0/5] mmc: renesas_sdhi: add manual correction > > A branch can be found here: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/new_manual_calib > > It has been tested with a Renesas Salvator-XS boards, one with a R-Car > M3-N and one with H3-ES2.0. Tuning to HS400 still works. Thank you for the refactoring! This patch series looks good to me. So, Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda
On Wed, 29 Jan 2020 at 21:37, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > TAP and SCC handling is Renesas specific, so it should be moved to the > SDHI driver. After previous refactoring, this is possible now. And > feasible, too, to simplify further HS400 corrections. IMHO it also makes > the driver less complicated. > > See the patches why this series is still RFC. > > This is based on top of the series: > [RFC PATCH v2 0/5] mmc: renesas_sdhi: add manual correction > > A branch can be found here: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/new_manual_calib > > It has been tested with a Renesas Salvator-XS boards, one with a R-Car > M3-N and one with H3-ES2.0. Tuning to HS400 still works. > > > Wolfram Sang (6): > mmc: tmio: refactor tuning execution into SDHI driver > mmc: renesas_sdhi: complain loudly if driver needs update > mmc: tmio: give callback a generic name > mmc: tmio: enforce retune after runtime suspend > mmc: tmio: factor out TAP usage > mmc: tmio: remove superfluous callback wrappers > > drivers/mmc/host/renesas_sdhi.h | 5 ++ > drivers/mmc/host/renesas_sdhi_core.c | 90 +++++++++++++++++----------- > drivers/mmc/host/tmio_mmc.h | 11 +--- > drivers/mmc/host/tmio_mmc_core.c | 77 +++--------------------- > 4 files changed, 71 insertions(+), 112 deletions(-) > > -- > 2.20.1 > Wolfram, I realize that there were potentially a few minor nitpicks to address, but let's do that on top. So, applied for next, thanks! Kind regards Uffe