From patchwork Tue Jul 21 10:52:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Levitsky X-Patchwork-Id: 11675381 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E8114618 for ; Tue, 21 Jul 2020 10:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D15BF2077D for ; Tue, 21 Jul 2020 10:53:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HcDMl8M2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729358AbgGUKxU (ORCPT ); Tue, 21 Jul 2020 06:53:20 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:24925 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726127AbgGUKxR (ORCPT ); Tue, 21 Jul 2020 06:53:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595328796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a7FGaIHkD38JSVxPqaibb4DmZEBgCel4gb1OIq9hfcg=; b=HcDMl8M28Q2UocbN8b/QuXcF3AhaEwtt/3PFGX7RFHxYyIghX2F2+2tBS+xqN646Q6DUTj ZO4iICVPJMry+K0jN6Ii4KWIATTFaWZSrlOfIaHd+D8O0KVjA9wlOFjPqOI9rMVfXD7jmp YHA/kW7p9lzFyi/ayuRfDvJHEginceI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-ukSVL_ZBNG-8BMv4MWvP7A-1; Tue, 21 Jul 2020 06:53:12 -0400 X-MC-Unique: ukSVL_ZBNG-8BMv4MWvP7A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26294100AA21; Tue, 21 Jul 2020 10:53:09 +0000 (UTC) Received: from localhost.localdomain (unknown [10.35.206.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id DCBC78730C; Tue, 21 Jul 2020 10:52:40 +0000 (UTC) From: Maxim Levitsky To: linux-kernel@vger.kernel.org Cc: Keith Busch , Josef Bacik , linux-block@vger.kernel.org (open list:BLOCK LAYER), Sagi Grimberg , Jens Axboe , linux-nvme@lists.infradead.org (open list:NVM EXPRESS DRIVER), linux-scsi@vger.kernel.org (open list:SCSI CDROM DRIVER), Tejun Heo , Bart Van Assche , "Martin K. Petersen" , Damien Le Moal , Jason Wang , Maxim Levitsky , Stefan Hajnoczi , Colin Ian King , "Michael S. Tsirkin" , Paolo Bonzini , Ulf Hansson , Ajay Joshi , Ming Lei , linux-mmc@vger.kernel.org (open list:SONY MEMORYSTICK SUBSYSTEM), Christoph Hellwig , Satya Tangirala , nbd@other.debian.org (open list:NETWORK BLOCK DEVICE (NBD)), Hou Tao , Jens Axboe , virtualization@lists.linux-foundation.org (open list:VIRTIO CORE AND NET DRIVERS), "James E.J. Bottomley" , Alex Dubov , Maxim Levitsky Subject: [PATCH 00/10] RFC: move logical block size checking to the block core Date: Tue, 21 Jul 2020 13:52:29 +0300 Message-Id: <20200721105239.8270-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org This patch series aims to move the logical block size checking to the block code. This was inspired by missing check for valid logical block size in virtio-blk which causes the kernel to crash in a weird way later on when it is invalid. I added blk_is_valid_logical_block_size which returns true iff the block size is one of supported sizes. I added this check to virtio-blk, and also converted few block drivers that I am familiar with to use this interface instead of their own implementation. Best regards, Maxim Levitsky Maxim Levitsky (10): block: introduce blk_is_valid_logical_block_size block: virtio-blk: check logical block size block: loop: use blk_is_valid_logical_block_size block: nbd: use blk_is_valid_logical_block_size block: null: use blk_is_valid_logical_block_size block: ms_block: use blk_is_valid_logical_block_size block: mspro_blk: use blk_is_valid_logical_block_size block: nvme: use blk_is_valid_logical_block_size block: scsi: sd: use blk_is_valid_logical_block_size block: scsi: sr: use blk_is_valid_logical_block_size block/blk-settings.c | 18 +++++++++++++++++ drivers/block/loop.c | 23 +++++---------------- drivers/block/nbd.c | 12 ++--------- drivers/block/null_blk_main.c | 6 +++--- drivers/block/virtio_blk.c | 15 ++++++++++++-- drivers/memstick/core/ms_block.c | 2 +- drivers/memstick/core/mspro_block.c | 6 ++++++ drivers/nvme/host/core.c | 17 ++++++++-------- drivers/scsi/sd.c | 5 +---- drivers/scsi/sr.c | 31 ++++++++++++----------------- include/linux/blkdev.h | 1 + 11 files changed, 71 insertions(+), 65 deletions(-)