mbox series

[0/3] mmc: renesas_sdhi: generic cleanups

Message ID 20201111100244.15823-1-wsa+renesas@sang-engineering.com (mailing list archive)
Headers show
Series mmc: renesas_sdhi: generic cleanups | expand

Message

Wolfram Sang Nov. 11, 2020, 10:02 a.m. UTC
Here are a few patches fixing cosmetic issues which always annoyed me
when working on this driver. Patches #1+#2 improve naming and remove
hardcoded values. Patch #3 sorts the defines. The object files were
identical here before and after the patchset, as expected.

The patches depend on the series "[PATCH 0/3] mmc: renesas_sdhi:
refactor SCC reset" and are part of this branch:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tap_en_v2

Hope you'll like it,

   Wolfram


Wolfram Sang (3):
  mmc: renesas_sdhi: improve HOST_MODE usage
  mmc: renesas_sdhi: don't hardcode SDIF values
  mmc: renesas_sdhi: sort includes

 drivers/mmc/host/renesas_sdhi_core.c | 49 +++++++++++++++++-----------
 drivers/mmc/host/tmio_mmc.h          |  1 -
 2 files changed, 30 insertions(+), 20 deletions(-)

Comments

Yoshihiro Shimoda Nov. 13, 2020, 6 a.m. UTC | #1
Hi Wolfram-san,

> From: Wolfram Sang, Sent: Wednesday, November 11, 2020 7:03 PM
> 
> Here are a few patches fixing cosmetic issues which always annoyed me
> when working on this driver. Patches #1+#2 improve naming and remove
> hardcoded values. Patch #3 sorts the defines. The object files were
> identical here before and after the patchset, as expected.
> 
> The patches depend on the series "[PATCH 0/3] mmc: renesas_sdhi:
> refactor SCC reset" and are part of this branch:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tap_en_v2

Thank you for the patch!

Since I intended to reply on the patch 2/3 with my comment,
I sent my Reviewed-by on the patch 1/3. But, I realized the patch 2/3 was also OK.

So, I sent my Reviewed-by on the cover-letter:

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda
Ulf Hansson Nov. 17, 2020, 11:50 a.m. UTC | #2
On Wed, 11 Nov 2020 at 11:02, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Here are a few patches fixing cosmetic issues which always annoyed me
> when working on this driver. Patches #1+#2 improve naming and remove
> hardcoded values. Patch #3 sorts the defines. The object files were
> identical here before and after the patchset, as expected.
>
> The patches depend on the series "[PATCH 0/3] mmc: renesas_sdhi:
> refactor SCC reset" and are part of this branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tap_en_v2
>
> Hope you'll like it,
>
>    Wolfram
>
>
> Wolfram Sang (3):
>   mmc: renesas_sdhi: improve HOST_MODE usage
>   mmc: renesas_sdhi: don't hardcode SDIF values
>   mmc: renesas_sdhi: sort includes
>
>  drivers/mmc/host/renesas_sdhi_core.c | 49 +++++++++++++++++-----------
>  drivers/mmc/host/tmio_mmc.h          |  1 -
>  2 files changed, 30 insertions(+), 20 deletions(-)
>

Applied for next, thanks!

Kind regards
Uffe