| Message ID | 20220222033931.237638-1-jasonlai.genesyslogic@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Preparations to support SD UHS-II cards | expand |
Hi Jason, On Tue, 22 Feb 2022 at 04:39, Jason Lai <jasonlai.genesyslogic@gmail.com> wrote: > > From: Jason Lai <jason.lai@genesyslogic.com.tw> > > Series [1] that has been posted by Ulf Hansson which provided some guidance > and an overall structure. > > Series [2] focused on UHS-II card control side to address Ulf's intention > regarding to "modularising" sd_uhs2.c. > > Series [3] is based on series [2] and adopt most of Ulf's comments. > > This series is the successor version of post [3], which is base on Ulf's "next" branch 2022/02/14): > 1. Modify settings in uhs2_config_write(). > 2. Fix some compilation errors. > 3. Fix some warnings and errors when executing checkpatch.pl. > > Kind regards > Jason Lai > > [1] > https://patchwork.kernel.org/project/linux-mmc/list/?series=438509 > > [2] > https://patchwork.kernel.org/project/linux-mmc/list/?series=589827 > > [3] > https://patchwork.kernel.org/project/linux-mmc/list/?series=606241 > > Jason Lai (3): > mmc: add UHS-II related definitions in headers > mmc: Implement content of UHS-II card initialization functions > mmc: core: Support UHS-II card access > > Ulf Hansson (4): > mmc: core: Cleanup printing of speed mode at card insertion > mmc: core: Prepare to support SD UHS-II cards > mmc: core: Announce successful insertion of an SD UHS-II card > mmc: core: Extend support for mmc regulators with a vqmmc2 > > drivers/mmc/core/Makefile | 2 +- > drivers/mmc/core/bus.c | 38 +- > drivers/mmc/core/core.c | 43 +- > drivers/mmc/core/core.h | 1 + > drivers/mmc/core/host.h | 4 + > drivers/mmc/core/regulator.c | 34 ++ > drivers/mmc/core/sd_uhs2.c | 1088 ++++++++++++++++++++++++++++++++++ > drivers/mmc/core/sd_uhs2.h | 16 + > include/linux/mmc/card.h | 35 ++ > include/linux/mmc/core.h | 6 + > include/linux/mmc/host.h | 69 +++ > include/linux/mmc/sd_uhs2.h | 198 +++++++ > 12 files changed, 1514 insertions(+), 20 deletions(-) > create mode 100644 drivers/mmc/core/sd_uhs2.c > create mode 100644 drivers/mmc/core/sd_uhs2.h > create mode 100644 include/linux/mmc/sd_uhs2.h > I decided to help out a bit and are working on some improvements to some of the patches from this series. Although, rather than me reposting new versions of these patches, I will share a public branch via my mmc git tree within a few days. It will be based upon the v3 series, but incorporating some new changes from my side. The changes will be explained as a part of the commit messages. I will let you know as soon as the branch is available and I am also reviewing your series, so will provide you with some comments soon. Kind regards Uffe
On Fri, 18 Mar 2022 at 14:16, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > Hi Jason, > > On Tue, 22 Feb 2022 at 04:39, Jason Lai <jasonlai.genesyslogic@gmail.com> wrote: > > > > From: Jason Lai <jason.lai@genesyslogic.com.tw> > > > > Series [1] that has been posted by Ulf Hansson which provided some guidance > > and an overall structure. > > > > Series [2] focused on UHS-II card control side to address Ulf's intention > > regarding to "modularising" sd_uhs2.c. > > > > Series [3] is based on series [2] and adopt most of Ulf's comments. > > > > This series is the successor version of post [3], which is base on Ulf's "next" branch 2022/02/14): > > 1. Modify settings in uhs2_config_write(). > > 2. Fix some compilation errors. > > 3. Fix some warnings and errors when executing checkpatch.pl. > > > > Kind regards > > Jason Lai > > > > [1] > > https://patchwork.kernel.org/project/linux-mmc/list/?series=438509 > > > > [2] > > https://patchwork.kernel.org/project/linux-mmc/list/?series=589827 > > > > [3] > > https://patchwork.kernel.org/project/linux-mmc/list/?series=606241 > > > > Jason Lai (3): > > mmc: add UHS-II related definitions in headers > > mmc: Implement content of UHS-II card initialization functions > > mmc: core: Support UHS-II card access > > > > Ulf Hansson (4): > > mmc: core: Cleanup printing of speed mode at card insertion > > mmc: core: Prepare to support SD UHS-II cards > > mmc: core: Announce successful insertion of an SD UHS-II card > > mmc: core: Extend support for mmc regulators with a vqmmc2 > > > > drivers/mmc/core/Makefile | 2 +- > > drivers/mmc/core/bus.c | 38 +- > > drivers/mmc/core/core.c | 43 +- > > drivers/mmc/core/core.h | 1 + > > drivers/mmc/core/host.h | 4 + > > drivers/mmc/core/regulator.c | 34 ++ > > drivers/mmc/core/sd_uhs2.c | 1088 ++++++++++++++++++++++++++++++++++ > > drivers/mmc/core/sd_uhs2.h | 16 + > > include/linux/mmc/card.h | 35 ++ > > include/linux/mmc/core.h | 6 + > > include/linux/mmc/host.h | 69 +++ > > include/linux/mmc/sd_uhs2.h | 198 +++++++ > > 12 files changed, 1514 insertions(+), 20 deletions(-) > > create mode 100644 drivers/mmc/core/sd_uhs2.c > > create mode 100644 drivers/mmc/core/sd_uhs2.h > > create mode 100644 include/linux/mmc/sd_uhs2.h > > > > I decided to help out a bit and are working on some improvements to > some of the patches from this series. > > Although, rather than me reposting new versions of these patches, I > will share a public branch via my mmc git tree within a few days. It > will be based upon the v3 series, but incorporating some new changes > from my side. The changes will be explained as a part of the commit > messages. I will let you know as soon as the branch is available and I > am also reviewing your series, so will provide you with some comments > soon. Hi Jason, So I have worked on some various improvements for this series and have amended the patches here in v3. It's mostly cosmetic changes along with some restructuring of the code. I have described the changes in a specific section in each of the commit messages (please remove these parts before posting a new version). git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git wip_uhs2_v3 Going forward, I will continue to review the series and provide you with some additional comments. For the next submission, I suggest you start from the branch I provided above. I would also appreciate it if you can provide some information of what has changed for each of the patches in the series, when you post a new version. This makes it easier to review. Kind regards Uffe
From: Jason Lai <jason.lai@genesyslogic.com.tw> Series [1] that has been posted by Ulf Hansson which provided some guidance and an overall structure. Series [2] focused on UHS-II card control side to address Ulf's intention regarding to "modularising" sd_uhs2.c. Series [3] is based on series [2] and adopt most of Ulf's comments. This series is the successor version of post [3], which is base on Ulf's "next" branch 2022/02/14): 1. Modify settings in uhs2_config_write(). 2. Fix some compilation errors. 3. Fix some warnings and errors when executing checkpatch.pl. Kind regards Jason Lai [1] https://patchwork.kernel.org/project/linux-mmc/list/?series=438509 [2] https://patchwork.kernel.org/project/linux-mmc/list/?series=589827 [3] https://patchwork.kernel.org/project/linux-mmc/list/?series=606241 Jason Lai (3): mmc: add UHS-II related definitions in headers mmc: Implement content of UHS-II card initialization functions mmc: core: Support UHS-II card access Ulf Hansson (4): mmc: core: Cleanup printing of speed mode at card insertion mmc: core: Prepare to support SD UHS-II cards mmc: core: Announce successful insertion of an SD UHS-II card mmc: core: Extend support for mmc regulators with a vqmmc2 drivers/mmc/core/Makefile | 2 +- drivers/mmc/core/bus.c | 38 +- drivers/mmc/core/core.c | 43 +- drivers/mmc/core/core.h | 1 + drivers/mmc/core/host.h | 4 + drivers/mmc/core/regulator.c | 34 ++ drivers/mmc/core/sd_uhs2.c | 1088 ++++++++++++++++++++++++++++++++++ drivers/mmc/core/sd_uhs2.h | 16 + include/linux/mmc/card.h | 35 ++ include/linux/mmc/core.h | 6 + include/linux/mmc/host.h | 69 +++ include/linux/mmc/sd_uhs2.h | 198 +++++++ 12 files changed, 1514 insertions(+), 20 deletions(-) create mode 100644 drivers/mmc/core/sd_uhs2.c create mode 100644 drivers/mmc/core/sd_uhs2.h create mode 100644 include/linux/mmc/sd_uhs2.h