mbox series

[v1,0/1] mmc: sdhci-of-dwcmshc: Add CQE support

Message ID 20230825143525.869906-1-serghox@gmail.com (mailing list archive)
Headers show
Series mmc: sdhci-of-dwcmshc: Add CQE support | expand

Message

Sergey Khimich Aug. 25, 2023, 2:35 p.m. UTC
Hello!

This is implementation of SDHCI CQE support for sdhci-of-dwcmshc driver.
For enabling CQE support just set 'supports-cqe' in your DevTree file
for appropriate mmc node.

Also, while implementing CQE support for the driver, I faced with a problem 
which I will describe below.
According to the IP block documentation CQE works only with "AMDA-2 only"
mode which is activated only with v4 mode enabled. I see in dwcmshc_probe()
function that v4 mode gets enabled only for 'sdhci_dwcmshc_bf3_pdata' platform data.

So my question is: is it correct to enable v4 mode for all platform data
if 'SDHCI_CAN_64BIT_V4' bit is set in hw?

Because I`m afraid that enabling v4 mode for some platforms could break
them down. On the other hand, if host controller says that it can do v4
(caps & SDHCI_CAN_64BIT_V4), lets do v4 or disable it manualy by some
quirk. Anyway - RFC.

Thanks in advance, Sergey.


Sergey Khimich (1):
  mmc: sdhci-of-dwcmshc: Add CQE support

 drivers/mmc/host/Kconfig            |   1 +
 drivers/mmc/host/sdhci-of-dwcmshc.c | 154 +++++++++++++++++++++++++++-
 2 files changed, 154 insertions(+), 1 deletion(-)