| Message ID | cover.1549181242.git.lukas@wunner.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Raspberry Pi sdhost cleanups | expand |
On Sun, 3 Feb 2019 at 09:27, Lukas Wunner <lukas@wunner.de> wrote: > > Three mostly trivial cleanups for the Raspberry Pi sdhost driver, v2. > > Only change since v1: Use container_of() in patch [2/3] instead of > open-coding the same (Alexander Graf). > > The issue addressed by patch [2/3] appears to be present in 32 other > drivers as can be seen with "git grep -e '->mmc = ' -- drivers/mmc/host". > Perhaps cleaning them up would be suitable for Outreachy applicants to > get their feet wet? Adding Shraddha Barke and Vaishali Thakkar to cc. > > Thanks, > > Lukas > > > Lukas Wunner (3): > mmc: bcm2835: Drop DMA channel error pointer check > mmc: bcm2835: Drop pointer to mmc_host from bcm2835_host > mmc: bcm2835: Deduplicate reset of driver data on remove > > drivers/mmc/host/bcm2835.c | 23 +++++++++++------------ > include/linux/mmc/host.h | 5 +++++ > 2 files changed, 16 insertions(+), 12 deletions(-) > > -- > 2.20.1 > Applied for next, thanks! Kind regards Uffe
On Tue, Feb 05, 2019 at 01:48:31PM +0100, Ulf Hansson wrote: > On Sun, 3 Feb 2019 at 09:27, Lukas Wunner <lukas@wunner.de> wrote: > > Three mostly trivial cleanups for the Raspberry Pi sdhost driver, v2. > > > > Only change since v1: Use container_of() in patch [2/3] instead of > > open-coding the same (Alexander Graf). > > > > The issue addressed by patch [2/3] appears to be present in 32 other > > drivers as can be seen with "git grep -e '->mmc = ' -- drivers/mmc/host". > > Perhaps cleaning them up would be suitable for Outreachy applicants to > > get their feet wet? Adding Shraddha Barke and Vaishali Thakkar to cc. FWIW this is now documented as something for Outreachy applicants to look into, I hope that's okay: https://github.com/nerdyvaishali/kernelbridge/commit/6f8cbf7f8e36 > > Lukas Wunner (3): > > mmc: bcm2835: Drop DMA channel error pointer check > > mmc: bcm2835: Drop pointer to mmc_host from bcm2835_host > > mmc: bcm2835: Deduplicate reset of driver data on remove > > Applied for next, thanks! Awesome, thanks a lot. Lukas
On Tue, 5 Feb 2019 at 14:26, Lukas Wunner <lukas@wunner.de> wrote: > > On Tue, Feb 05, 2019 at 01:48:31PM +0100, Ulf Hansson wrote: > > On Sun, 3 Feb 2019 at 09:27, Lukas Wunner <lukas@wunner.de> wrote: > > > Three mostly trivial cleanups for the Raspberry Pi sdhost driver, v2. > > > > > > Only change since v1: Use container_of() in patch [2/3] instead of > > > open-coding the same (Alexander Graf). > > > > > > The issue addressed by patch [2/3] appears to be present in 32 other > > > drivers as can be seen with "git grep -e '->mmc = ' -- drivers/mmc/host". > > > Perhaps cleaning them up would be suitable for Outreachy applicants to > > > get their feet wet? Adding Shraddha Barke and Vaishali Thakkar to cc. > > FWIW this is now documented as something for Outreachy applicants > to look into, I hope that's okay: > > https://github.com/nerdyvaishali/kernelbridge/commit/6f8cbf7f8e36 Great, cool, thanks! :-) Kind regards Uffe