From patchwork Wed Nov 28 10:26:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seungwon Jeon X-Patchwork-Id: 1814991 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id DA3CD3FC54 for ; Wed, 28 Nov 2012 10:27:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753759Ab2K1K1A (ORCPT ); Wed, 28 Nov 2012 05:27:00 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:11934 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753572Ab2K1K07 (ORCPT ); Wed, 28 Nov 2012 05:26:59 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0ME700GKP10UL2Y0@mailout3.samsung.com> for linux-mmc@vger.kernel.org; Wed, 28 Nov 2012 19:26:58 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id D2.DB.01231.2F6E5B05; Wed, 28 Nov 2012 19:26:58 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-ce-50b5e6f29dd0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id B1.DB.01231.2F6E5B05; Wed, 28 Nov 2012 19:26:58 +0900 (KST) Received: from DOTGIHJUN01 ([12.23.118.161]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0ME7007PX10YOCA0@mmp2.samsung.com> for linux-mmc@vger.kernel.org; Wed, 28 Nov 2012 19:26:58 +0900 (KST) From: Seungwon Jeon To: linux-mmc@vger.kernel.org Cc: 'Chris Ball' , 'Will Newton' , 'James Hogan' , 'Jaehoon Chung' References: In-reply-to: Subject: [PATCH 2/2] mmc: dw_mmc: make sure of clearing HLE interrupt Date: Wed, 28 Nov 2012 19:26:58 +0900 Message-id: <001c01cdcd52$e58a2260$b09e6720$%jun@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac03z3aCvVFr8FaITt2vKVQKst76fw3Ogf7QC4iI1hAMCbge0A== Content-language: ko DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMIsWRmVeSWpSXmKPExsVy+t8zQ91Pz7YGGHTt0rI48r+f0YHR4/Mm uQDGKC6blNSczLLUIn27BK6Mm7tOsRa0cFasa9vH0sC4jL2LkZNDQsBEon3JXxYIW0ziwr31 bCC2kMAyRon1e3lhapbsmQYU5wKKT2eUOLH0AxNE0SwmidP7ZEBsNgEtib9v3jCD2CICshI/ /1wAa2AWmM8o8eLAFdYuRg6gBm6J1c1BIDWcAjwS6/50gtULC7hKTP1yHGwxi4CqxIobK1hB bF4BW4nDD+YxQtiCEj8m32MBGcMsoC4xZUouSJhZQF5i85q3zCBhCaDwo7+6EBc4STTMbmKB KBGR2PfiHSPEdAGJb5MPsUCUy0psOsAMcqSEwDJ2iXWL10ODQVLi4IobLBMYJWYhWTwLYfEs JItnIdmwgJFlFaNoakFyQXFSeq6hXnFibnFpXrpecn7uJkZITEntYFzZYHGIUYCDUYmH18Fx a4AQa2JZcWXuIUYJDmYlEV7mR0Ah3pTEyqrUovz4otKc1OJDjD5Ah09klhJNzgfGe15JvKGx sYmZiamJuaWpuSkOYSVx3maPlAAhgfTEktTs1NSC1CKYcUwcnFINjOWOjxi4ZtpdkPTfujvz xi+2tUIq82purtuxzfnxzilcD68wv7Fv8rN9aR0Ze+6o7foXR7+ZCbbGCL7f+LVowtHm7Yv6 NvP0iPVwXW3YI3bItFfx6QuPy28vtn040f+dV5Nv5sZXe34mbP9iWrurZ+PiyFPthx/bq+qe tDu65dKiM2kfixfx31ypxFKckWioxVxUnAgAtkKOfNYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t9jQd1Pz7YGGDxZqGZx5H8/owOjx+dN cgGMUQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlA U5UUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhHWMGTd3nWItaOGsWNe2j6WB cRl7FyMnh4SAicSSPdPYIGwxiQv31gPZXBxCAtMZJU4s/cAEkhASmMUkcXqfDIjNJqAl8ffN G2YQW0RAVuLnnwtgDcwC8xklXhy4wtrFyAHUwC2xujkIpIZTgEdi3Z9OsHphAVeJqV+Ogy1j EVCVWHFjBSuIzStgK3H4wTxGCFtQ4sfkeywgY5gF1CWmTMkFCTMLyEtsXvOWGSQsARR+9FcX 4gIniYbZTSwQJSIS+168Y5zAKDQLyaBZCINmIRk0C0nHAkaWVYyiqQXJBcVJ6bmGesWJucWl eel6yfm5mxjBMftMagfjygaLQ4wCHIxKPLwOjlsDhFgTy4orcw8xSnAwK4nwMj8CCvGmJFZW pRblxxeV5qQWH2L0AXpzIrOUaHI+MJ3klcQbGpuYGVkamVkYmZib4xBWEudt9kgJEBJITyxJ zU5NLUgtghnHxMEp1cC4ZW2++E3ZFn5VmyWJrW9VszIafe8XZ1/sCm7JkDKMPzOR6cLsZrHm 1UHmuXMfP9mv/FI5j6OmR+74k9ViIndmxbIb/hCV+rd6S8yZJT9yqi/NKkj4v45nntOuCOOC F+XThf+ya/d/2qvkopPDz3fO7P0Ug8Vb13xc+lbRV/B41Z/C9RJhcbxKLMUZiYZazEXFiQAq KWgfBgMAAA== X-CFilter-Loop: Reflected Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Even though HLE interrupt is enabled, there is no touch. This patch clears HLE interrupt which is not unhandled. Signed-off-by: Seungwon Jeon --- drivers/mmc/host/dw_mmc.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 6785d62..b6db0ae 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1009,6 +1009,11 @@ static void dw_mci_tasklet_func(unsigned long priv) state = host->state; data = host->data; + if (host->cmd_status & SDMMC_INT_HLE) { + dev_err(host->dev, "hardware locked write error\n"); + goto unlock; + } + do { prev_state = state; @@ -1577,6 +1582,12 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) if (!pending) break; + if (pending & SDMMC_INT_HLE) { + mci_writel(host, RINTSTS, SDMMC_INT_HLE); + host->cmd_status = pending; + tasklet_schedule(&host->tasklet); + } + if (pending & DW_MCI_CMD_ERROR_FLAGS) { mci_writel(host, RINTSTS, DW_MCI_CMD_ERROR_FLAGS); host->cmd_status = pending;