| Message ID | 00f901cd9d39$2f84c720$8e8e5560$%jun@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 28, 2012 at 6:21 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote: > Even though platform_get_irq returns error, 'host->irq' > always has an unsigned value. Less-than-zero comparison > of an unsigned value is never true. Type of 'unsigned int' > will be changed for 'int'. > > Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> > --- > include/linux/mmc/dw_mmc.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Acked-by: Will Newton <will.newton@imgtec.com> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Fri, Sep 28 2012, Will Newton wrote: > On Fri, Sep 28, 2012 at 6:21 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote: >> Even though platform_get_irq returns error, 'host->irq' >> always has an unsigned value. Less-than-zero comparison >> of an unsigned value is never true. Type of 'unsigned int' >> will be changed for 'int'. >> >> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> >> --- >> include/linux/mmc/dw_mmc.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > Acked-by: Will Newton <will.newton@imgtec.com> Thanks, pushed to mmc-next for 3.8. - Chris.
diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h index 7c6a113..3141676 100644 --- a/include/linux/mmc/dw_mmc.h +++ b/include/linux/mmc/dw_mmc.h @@ -186,7 +186,7 @@ struct dw_mci { struct regulator *vmmc; /* Power regulator */ unsigned long irq_flags; /* IRQ flags */ - unsigned int irq; + int irq; }; /* DMA ops for Internal/External DMAC interface */
Even though platform_get_irq returns error, 'host->irq' always has an unsigned value. Less-than-zero comparison of an unsigned value is never true. Type of 'unsigned int' will be changed for 'int'. Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> --- include/linux/mmc/dw_mmc.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)