From patchwork Tue Aug 8 05:46:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9886613 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7C28D60363 for ; Tue, 8 Aug 2017 05:47:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5ECE128739 for ; Tue, 8 Aug 2017 05:47:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 50F13287A2; Tue, 8 Aug 2017 05:47:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM, SUSPICIOUS_RECIPS,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 086E528739 for ; Tue, 8 Aug 2017 05:47:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751698AbdHHFrD (ORCPT ); Tue, 8 Aug 2017 01:47:03 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:38712 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736AbdHHFrC (ORCPT ); Tue, 8 Aug 2017 01:47:02 -0400 Received: by mail-pg0-f66.google.com with SMTP id 123so2125078pga.5; Mon, 07 Aug 2017 22:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=faEsvuqF/m2foLzETrYuetUpWEzaAB6oKA2nL3d8U64=; b=O1msJBZTqcLfqGfq+fTqQRcz33Z7qs4Odgx07GIt1ANEhhhaD0wy/z+cLlt5mR3pYL aUXOIF+FWjuRsCLx6xhO88A4A3DnYd7u7112M0VjXgMa0IxsMeBo5COOnBkCB9+YLRV9 g0GskcBf9oiZxBPtkhuWiBXkpahNwgN2Cwb/a5bcEY/MP9MXAOmKAdN2bsx3meUsRHR0 HevBqzrCZvJovGYmunhorydyWI0ZqTN4GOTMjTDJ5c8ZSdnJR2XMAK3M57pNEprbXIqZ bCrGzF6sSapS4KInGiT6XryqaxuJ1BOzv+2mK24kDZZ2kVY0JGC9MaemRHMHNG/rWDR2 LSug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=faEsvuqF/m2foLzETrYuetUpWEzaAB6oKA2nL3d8U64=; b=RXKS0/smvNkqYPA+gprnK6irO981gu/J4g0yXFF/mNUIO6J9WQczdXFl2DIHmgfJC4 Vf86m8RpU6YIUwaI7jVq9lcBzj8BoG0SXo/i+PN7iEgUGb58qbyJF7cJUc4AlrOUmz4q 5m6rvN+DgC/+hApDYcgX111ejYUt7u4PX7jZqFU2yJQcxfHUqDGHJgxDX7GoAME1OEx6 s2yjkmh6mSXU19rlu1mBlb6+y6xa0fk1WpABXuPoA+84GqWhjjgHb01/EgGIv1ehZ/N1 0z9uizk0q1QgmDdKeulAxvzpUDn5Z1xlFpmQWgwnW0S+OBHV6LyWo0h/Hn1C/HNARzDy oO5Q== X-Gm-Message-State: AHYfb5j/m44nhT/iIPaJQRM8s9xJ/+7XIhS3eWGD9a19E7yXFYDXEJMq hUJCHPeho1mIJw== X-Received: by 10.98.218.84 with SMTP id w20mr3183973pfl.240.1502171222465; Mon, 07 Aug 2017 22:47:02 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id z83sm1061214pfd.10.2017.08.07.22.47.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Aug 2017 22:47:01 -0700 (PDT) From: Arvind Yadav To: linux@prisktech.co.nz, ulf.hansson@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org Subject: [PATCH] mmc: wmt-sdmmc: Handle return value of clk_prepare_enable Date: Tue, 8 Aug 2017 11:16:38 +0530 Message-Id: <0d9fccf8e14a639274115cc43a97804ef059d8b1.1502171094.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/mmc/host/wmt-sdmmc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c index 21ebba8..e64f930 100644 --- a/drivers/mmc/host/wmt-sdmmc.c +++ b/drivers/mmc/host/wmt-sdmmc.c @@ -856,7 +856,9 @@ static int wmt_mci_probe(struct platform_device *pdev) goto fail5; } - clk_prepare_enable(priv->clk_sdmmc); + ret = clk_prepare_enable(priv->clk_sdmmc); + if (ret) + goto fail6; /* configure the controller to a known 'ready' state */ wmt_reset_hardware(mmc); @@ -866,6 +868,8 @@ static int wmt_mci_probe(struct platform_device *pdev) dev_info(&pdev->dev, "WMT SDHC Controller initialized\n"); return 0; +fail6: + clk_put(priv->clk_sdmmc); fail5: free_irq(dma_irq, priv); fail4: