From patchwork Tue Apr 5 15:02:26 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ohad Ben Cohen X-Patchwork-Id: 687361 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p35F4FCb028336 for ; Tue, 5 Apr 2011 15:04:23 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753688Ab1DEPDV (ORCPT ); Tue, 5 Apr 2011 11:03:21 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:42321 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753657Ab1DEPDT (ORCPT ); Tue, 5 Apr 2011 11:03:19 -0400 Received: by mail-fx0-f46.google.com with SMTP id 17so328800fxm.19 for ; Tue, 05 Apr 2011 08:03:18 -0700 (PDT) Received: by 10.223.3.132 with SMTP id 4mr137869fan.132.1302015798757; Tue, 05 Apr 2011 08:03:18 -0700 (PDT) Received: from localhost.localdomain (109-186-51-37.bb.netvision.net.il [109.186.51.37]) by mx.google.com with ESMTPS id c21sm2125975fac.22.2011.04.05.08.03.14 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Apr 2011 08:03:16 -0700 (PDT) From: Ohad Ben-Cohen To: Cc: Chris Ball , Ohad Ben-Cohen Subject: [PATCH 2/2] mmc: quirks: wl1271 is MMC_QUIRK_DISABLE_CD Date: Tue, 5 Apr 2011 18:02:26 +0300 Message-Id: <1302015746-8414-2-git-send-email-ohad@wizery.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1302015746-8414-1-git-send-email-ohad@wizery.com> References: <1302015746-8414-1-git-send-email-ohad@wizery.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 05 Apr 2011 15:04:23 +0000 (UTC) The wl12xx device supports disconnecting the pull-up resistor on CD/DAT[3] (pin 1) of the card. Tell SDIO core to disconnect that resistor during card init, since we don't need it at that point (and anyway all hosts shall provide pull-up resistors on all data lines DAT[3:0] as described in section 6 of the SD physical specification). As a result, this may save some power, but it's also generally healthy since it prevents both ends from pulling up that pin, which results in undesirable asymmetric physical bus. Signed-off-by: Ohad Ben-Cohen --- drivers/mmc/core/quirks.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.c index 1957398..a4c42ed 100644 --- a/drivers/mmc/core/quirks.c +++ b/drivers/mmc/core/quirks.c @@ -66,6 +66,8 @@ static const struct mmc_fixup mmc_fixup_methods[] = { remove_quirk, MMC_QUIRK_BROKEN_CLK_GATING }, { SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1271, add_quirk, MMC_QUIRK_NONSTD_FUNC_IF }, + { SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1271, + add_quirk, MMC_QUIRK_DISABLE_CD }, { 0 } };