From patchwork Mon May 9 00:55:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 768152 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p490ta2B005082 for ; Mon, 9 May 2011 00:55:40 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756634Ab1EIAzj (ORCPT ); Sun, 8 May 2011 20:55:39 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:50167 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756285Ab1EIAzh (ORCPT ); Sun, 8 May 2011 20:55:37 -0400 Received: from joe.akashicho.tokyo.vergenet.net (219-109-213-121.bitcat.net [219.109.213.121]) by kirsty.vergenet.net (Postfix) with ESMTP id F332A245A6; Mon, 9 May 2011 10:55:33 +1000 (EST) Received: by joe.akashicho.tokyo.vergenet.net (Postfix, from userid 7100) id 34A0428A074; Mon, 9 May 2011 09:55:29 +0900 (JST) From: Simon Horman To: Guennadi Liakhovetski , Magnus Damm Cc: Ian Molton , Chris Ball , Paul Mundt , linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org, Magnus Damm Subject: [PATCH 5/6] mmc: sdhi: print out something useful Date: Mon, 9 May 2011 09:55:15 +0900 Message-Id: <1304902516-14150-6-git-send-email-horms@verge.net.au> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1304902516-14150-1-git-send-email-horms@verge.net.au> References: <1304902516-14150-1-git-send-email-horms@verge.net.au> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 09 May 2011 00:55:41 +0000 (UTC) From: Magnus Damm Instead of printing out useless information such as the virtual base address and one of 4 interrupts, convert the SDHI probe() to print out physical base address together with clock rate. We do have a struct device so make use of dev_info(). Signed-off-by: Magnus Damm Signed-off-by: Guennadi Liakhovetski Reviewed-by: Simon Horman --- drivers/mmc/host/sh_mobile_sdhi.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c index c489547..2bd235b 100644 --- a/drivers/mmc/host/sh_mobile_sdhi.c +++ b/drivers/mmc/host/sh_mobile_sdhi.c @@ -126,8 +126,10 @@ static int __devinit sh_mobile_sdhi_probe(struct platform_device *pdev) if (ret) goto eirq; - pr_info("%s at 0x%08lx irq %d\n", mmc_hostname(host->mmc), - (unsigned long)host->ctl, irq); + dev_info(&pdev->dev, "%s base at 0x%08lx clock rate %u MHz\n", + mmc_hostname(host->mmc), (unsigned long) + (platform_get_resource(pdev,IORESOURCE_MEM, 0)->start), + mmc_data->hclk / 1000000); return ret;