| Message ID | 1348474558-23088-8-git-send-email-keyuan.liu@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Kevin, This make sense to me. Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Ulf Hansson On 24 September 2012 10:15, Kevin Liu <keyuan.liu@gmail.com> wrote: > From: Kevin Liu <kliu5@marvell.com> > > Both of MMC_TIMING_LEGACY and MMC_TIMING_UHS_SDR12 are defined > to 0. And ios->timing is set to MMC_TIMING_LEGACY during power up. > But set_ios can't distinguish these two timing if host support > spec 3.0. Just adjust timing values to be different can resolve > this issue without any other impact. > > Signed-off-by: Kevin Liu <kliu5@marvell.com> > --- > include/linux/mmc/host.h | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h > index d5d9bd4..036a5cc 100644 > --- a/include/linux/mmc/host.h > +++ b/include/linux/mmc/host.h > @@ -53,12 +53,12 @@ struct mmc_ios { > #define MMC_TIMING_LEGACY 0 > #define MMC_TIMING_MMC_HS 1 > #define MMC_TIMING_SD_HS 2 > -#define MMC_TIMING_UHS_SDR12 MMC_TIMING_LEGACY > -#define MMC_TIMING_UHS_SDR25 MMC_TIMING_SD_HS > -#define MMC_TIMING_UHS_SDR50 3 > -#define MMC_TIMING_UHS_SDR104 4 > -#define MMC_TIMING_UHS_DDR50 5 > -#define MMC_TIMING_MMC_HS200 6 > +#define MMC_TIMING_UHS_SDR12 3 > +#define MMC_TIMING_UHS_SDR25 4 > +#define MMC_TIMING_UHS_SDR50 5 > +#define MMC_TIMING_UHS_SDR104 6 > +#define MMC_TIMING_UHS_DDR50 7 > +#define MMC_TIMING_MMC_HS200 8 > > #define MMC_SDR_MODE 0 > #define MMC_1_2V_DDR_MODE 1 > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Ulf 2012/9/25 Ulf Hansson <ulf.hansson@linaro.org>: > Hi Kevin, > > This make sense to me. > > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> > Thanks for the review. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index d5d9bd4..036a5cc 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -53,12 +53,12 @@ struct mmc_ios { #define MMC_TIMING_LEGACY 0 #define MMC_TIMING_MMC_HS 1 #define MMC_TIMING_SD_HS 2 -#define MMC_TIMING_UHS_SDR12 MMC_TIMING_LEGACY -#define MMC_TIMING_UHS_SDR25 MMC_TIMING_SD_HS -#define MMC_TIMING_UHS_SDR50 3 -#define MMC_TIMING_UHS_SDR104 4 -#define MMC_TIMING_UHS_DDR50 5 -#define MMC_TIMING_MMC_HS200 6 +#define MMC_TIMING_UHS_SDR12 3 +#define MMC_TIMING_UHS_SDR25 4 +#define MMC_TIMING_UHS_SDR50 5 +#define MMC_TIMING_UHS_SDR104 6 +#define MMC_TIMING_UHS_DDR50 7 +#define MMC_TIMING_MMC_HS200 8 #define MMC_SDR_MODE 0 #define MMC_1_2V_DDR_MODE 1