From patchwork Fri Sep 28 07:56:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Liu X-Patchwork-Id: 1517441 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 78209E0010 for ; Fri, 28 Sep 2012 08:01:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756922Ab2I1IBr (ORCPT ); Fri, 28 Sep 2012 04:01:47 -0400 Received: from na3sys009aog134.obsmtp.com ([74.125.149.83]:44179 "EHLO na3sys009aog134.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756622Ab2I1IBq (ORCPT ); Fri, 28 Sep 2012 04:01:46 -0400 Received: from MSI-MTA.marvell.com ([65.219.4.132]) (using TLSv1) by na3sys009aob134.postini.com ([74.125.148.12]) with SMTP ID DSNKUGVZZUzlQHvQD5foVelvytGHQwE8JQZ+@postini.com; Fri, 28 Sep 2012 01:01:46 PDT Received: from maili.marvell.com ([10.68.76.210]) by MSI-MTA.marvell.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 28 Sep 2012 01:01:21 -0700 Received: from localhost.localdomain (unknown [10.38.36.240]) by maili.marvell.com (Postfix) with ESMTP id 5C4894E510; Fri, 28 Sep 2012 01:01:20 -0700 (PDT) From: Kevin Liu To: linux-mmc@vger.kernel.org, cjb@laptop.org, pierre@ossman.eu, ulf.hansson@linaro.org, zgao6@marvell.com Cc: hzhuang1@marvell.com, cxie4@marvell.com, prakity@marvell.com, kliu5@marvell.com, Jialing Fu , Tim Wang Subject: [PATCH v5 01/13] mmc: sdhci: fix transfer mode setting bug for cmds w/o data transfer Date: Fri, 28 Sep 2012 15:56:00 +0800 Message-Id: <1348818972-26711-2-git-send-email-keyuan.liu@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1348818972-26711-1-git-send-email-keyuan.liu@gmail.com> References: <1348818972-26711-1-git-send-email-keyuan.liu@gmail.com> X-OriginalArrivalTime: 28 Sep 2012 08:01:21.0956 (UTC) FILETIME=[72EA7E40:01CD9D4F] Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org From: Kevin Liu Commands without data transfer like cmd5/cmd7 will use previous transfer mode setting, which may lead to error since some bits may have been set unexpectedly. For example, cmd5 following cmd18/cmd25 will have timeout error since audo cmd23 has been enabled. Reviewed By: Girish K S Reviewed-by: Zhangfei Gao Signed-off-by: Jialing Fu Signed-off-by: Tim Wang Signed-off-by: Kevin Liu --- drivers/mmc/host/sdhci.c | 22 ++++++++++++++-------- 1 files changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 0e15c79..9be6a8c 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -886,8 +886,21 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host, u16 mode; struct mmc_data *data = cmd->data; - if (data == NULL) + if (!data) { + if (cmd->opcode == MMC_SEND_TUNING_BLOCK || + cmd->opcode == MMC_SEND_TUNING_BLOCK_HS200) + /* + * The tuning block is sent by the card to the host + * controller. So we set the TRNS_READ bit in the + * Transfer Mode register. This also takes care of + * setting DMA Enable and Multi Block Select in the + * same register to 0. + */ + sdhci_writew(host, SDHCI_TRNS_READ, SDHCI_TRANSFER_MODE); + else + sdhci_writew(host, 0, SDHCI_TRANSFER_MODE); return; + } WARN_ON(!host->data); @@ -1850,13 +1863,6 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode) SDHCI_BLOCK_SIZE); } - /* - * The tuning block is sent by the card to the host controller. - * So we set the TRNS_READ bit in the Transfer Mode register. - * This also takes care of setting DMA Enable and Multi Block - * Select in the same register to 0. - */ - sdhci_writew(host, SDHCI_TRNS_READ, SDHCI_TRANSFER_MODE); sdhci_send_command(host, &cmd);