From patchwork Fri Jan 11 17:03:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 1966841 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id EFD8FE007B for ; Fri, 11 Jan 2013 17:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755387Ab3AKRE6 (ORCPT ); Fri, 11 Jan 2013 12:04:58 -0500 Received: from mail-yh0-f73.google.com ([209.85.213.73]:33665 "EHLO mail-yh0-f73.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754776Ab3AKRER (ORCPT ); Fri, 11 Jan 2013 12:04:17 -0500 X-Greylist: delayed 80956 seconds by postgrey-1.27 at vger.kernel.org; Fri, 11 Jan 2013 12:04:17 EST Received: by mail-yh0-f73.google.com with SMTP id 47so239051yhr.2 for ; Fri, 11 Jan 2013 09:04:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=cktKuJ+4rLPrcyj+evJ54ATuQ6852LjTU/KC1t08K8c=; b=eRRDVDybRq67n7YRHush2iUPfruWzLaLVp+eeg4EVjEhpkNi2u1sn0/X6iQOyIiE7r KHnjJM5EeJaLj7yVxn8+Gm0uy9ceEWd6MZUEisuM52iMCQd4EDdQH7xTcrxf7KDz8DBd H0igL7M+8/oJmFauwhOQQYE1OnZQOltYcDONs7M2uNPc0BYVkZtgzfdQgsSo6h2LNn+l W+EzqpaSogZQGNlvBy30gEvkxnPfmXWFQEBTq76O/ifUg7Vcx1+4yAWWabicJcfzhwtI rT/QahGm7seEKvAqHFi3x76JWuba0Vwbkyk4ncwx9kc5UGXsot4VfLaLylpqKVH1jY2m A0gg== X-Received: by 10.101.75.3 with SMTP id c3mr10815174anl.11.1357923855802; Fri, 11 Jan 2013 09:04:15 -0800 (PST) Received: from wpzn3.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id s58si269657yhi.6.2013.01.11.09.04.15 (version=TLSv1 cipher=AES128-SHA bits=128/128); Fri, 11 Jan 2013 09:04:15 -0800 (PST) Received: from tictac.mtv.corp.google.com (tictac.mtv.corp.google.com [172.22.73.80]) by wpzn3.hot.corp.google.com (Postfix) with ESMTP id 9D5391000A1; Fri, 11 Jan 2013 09:04:15 -0800 (PST) Received: by tictac.mtv.corp.google.com (Postfix, from userid 121310) id 4F1BF81009; Fri, 11 Jan 2013 09:04:15 -0800 (PST) From: Doug Anderson To: linux-mmc@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, Thomas Abraham , Kukjin Kim , Olof Johansson , Arnd Bergmann , Will Newton , Chris Ball , Jaehoon Chung , Seungwon Jeon , linux-kernel@vger.kernel.org, Doug Anderson Subject: [PATCH v4 3/5] mmc: dw_mmc: exynos: Remove code for wp-gpios Date: Fri, 11 Jan 2013 09:03:52 -0800 Message-Id: <1357923834-31641-3-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1357923834-31641-1-git-send-email-dianders@chromium.org> References: <1357842269-15062-1-git-send-email-dianders@chromium.org> <1357923834-31641-1-git-send-email-dianders@chromium.org> X-Gm-Message-State: ALoCoQmlD0Ig2K7B3ngJPinwlFsaXmiyATke7BMnwsPlZXJ9eRKNn6Q/1BgHuTeDJ5IOZ+SJdoEAH7s/y+H9Zj7WQY4NqWZdaHJlIhdN8aaKSE/8h1O8AYlfv2BZ88gqbmV1+O50hKWOBZhlM/+FJNzocFoK7JZ0OebDTrAhWuWk0jpsDJCMzqYiDKhacly15MMGwQncPG189EZMpUejXbfCCe/SR2okGQ== Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The exynos code claimed the write protect with devm_gpio_request() but never did anything with it. That meant that anyone using a write protect GPIO would effectively be write protected all the time. The handling for wp-gpios belongs in the main dw_mmc driver and has been moved there. Signed-off-by: Doug Anderson Acked-by: Seungwon Jeon Acked-by: Olof Johansson --- Changes in v4: None Changes in v3: - Totally removed wp-gpios handling from exynos code. Changes in v2: None drivers/mmc/host/dw_mmc-exynos.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index 4d50da6..72fd0f2 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -175,16 +175,6 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host, } } - gpio = of_get_named_gpio(slot_np, "wp-gpios", 0); - if (gpio_is_valid(gpio)) { - if (devm_gpio_request(host->dev, gpio, "dw-mci-wp")) - dev_info(host->dev, "gpio [%d] request failed\n", - gpio); - } else { - dev_info(host->dev, "wp gpio not available"); - host->pdata->quirks |= DW_MCI_QUIRK_NO_WRITE_PROTECT; - } - if (host->pdata->quirks & DW_MCI_QUIRK_BROKEN_CARD_DETECTION) return 0;