| Message ID | 1359963959-2305-2-git-send-email-rogerable@realtek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 04, 2013 at 03:45:57PM +0800, Roger Tseng wrote: > Several new models of readers use different way to select driving > capability(a necessary adjustment along with voltage change). Removing this > from device-independent rtsx_pci_sdmmc module. It will be implemented in > device-depend calls encapsulated by rtsx_pci_switch_output_voltage(). > I'm not sure I understand. Does this patch break things and then "[PATCH 2/3] mfd: rtsx: implement driving adjustment to device-dependent callbacks" fixes things again? In other words, will all the old devices run if we only apply patch 1/3 and not 2/3? That's not the right idea. Just merge the two patches into one patch. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dan, Correct. I will prevent this kind of breaking in the future. However, after our analysis the breaking of patch 1/3 and 2/3 should not fail old devices. And since Samuel has applied 2/3 and 3/3, it might be better for Chris to apply patch 1/3 and let all this things appear in kernel v3.9. Hi Chris, Would you please apply patch 1/3 for kernel v3.9. Thanks. Best regards, Roger Tseng On 02/04/2013 04:47 PM, Dan Carpenter wrote: > On Mon, Feb 04, 2013 at 03:45:57PM +0800, Roger Tseng wrote: >> Several new models of readers use different way to select driving >> capability(a necessary adjustment along with voltage change). Removing this >> from device-independent rtsx_pci_sdmmc module. It will be implemented in >> device-depend calls encapsulated by rtsx_pci_switch_output_voltage(). >> > > I'm not sure I understand. > > Does this patch break things and then "[PATCH 2/3] mfd: rtsx: > implement driving adjustment to device-dependent callbacks" fixes > things again? In other words, will all the old devices run if we > only apply patch 1/3 and not 2/3? > > That's not the right idea. Just merge the two patches into one > patch. > > regards, > dan carpenter > > > ------Please consider the environment before printing this e-mail. > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 05, 2013 at 10:51:49AM +0800, Roger Tseng wrote: > Hi Dan, > > Correct. I will prevent this kind of breaking in the future. > Cool. Or if we applied 2/3 first and then 1/3 there would be no breakage? Anyway, it's a bit late to combine them at this point. > However, after our analysis the breaking of patch 1/3 and 2/3 should > not fail old devices. And since Samuel has applied 2/3 and 3/3, it > might be better for Chris to apply patch 1/3 and let all this things > appear in kernel v3.9. > > Hi Chris, > > Would you please apply patch 1/3 for kernel v3.9. Thanks. > Sounds good. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Mon, Feb 04 2013, Roger Tseng wrote: > Several new models of readers use different way to select driving > capability(a necessary adjustment along with voltage change). Removing this > from device-independent rtsx_pci_sdmmc module. It will be implemented in > device-depend calls encapsulated by rtsx_pci_switch_output_voltage(). > > Signed-off-by: Roger Tseng <rogerable@realtek.com> > Reviewed-by: Wei WANG <wei_wang@realsil.com.cn> > --- > drivers/mmc/host/rtsx_pci_sdmmc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c > index f74b5ad..f93f100 100644 > --- a/drivers/mmc/host/rtsx_pci_sdmmc.c > +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c > @@ -1083,11 +1083,6 @@ static int sdmmc_switch_voltage(struct mmc_host *mmc, struct mmc_ios *ios) > voltage = OUTPUT_1V8; > > if (voltage == OUTPUT_1V8) { > - err = rtsx_pci_write_register(pcr, > - SD30_DRIVE_SEL, 0x07, DRIVER_TYPE_B); > - if (err < 0) > - goto out; > - > err = sd_wait_voltage_stable_1(host); > if (err < 0) > goto out; Thanks, I've pushed 1/3 to mmc-next for 3.9 now. - Chris.
diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c index f74b5ad..f93f100 100644 --- a/drivers/mmc/host/rtsx_pci_sdmmc.c +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c @@ -1083,11 +1083,6 @@ static int sdmmc_switch_voltage(struct mmc_host *mmc, struct mmc_ios *ios) voltage = OUTPUT_1V8; if (voltage == OUTPUT_1V8) { - err = rtsx_pci_write_register(pcr, - SD30_DRIVE_SEL, 0x07, DRIVER_TYPE_B); - if (err < 0) - goto out; - err = sd_wait_voltage_stable_1(host); if (err < 0) goto out;