| Message ID | 1361177589-23953-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Acked-by: Jaehoon Chung <jh80.chung@samsung.com> On 02/18/2013 05:53 PM, Sachin Kamat wrote: > Silences the following sparse warning: > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: > symbol 'dw_mci_exynos_probe' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mmc/host/dw_mmc-exynos.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index 72fd0f2..5a09c77 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = { > }; > MODULE_DEVICE_TABLE(of, dw_mci_exynos_match); > > -int dw_mci_exynos_probe(struct platform_device *pdev) > +static int dw_mci_exynos_probe(struct platform_device *pdev) > { > const struct dw_mci_drv_data *drv_data; > const struct of_device_id *match; > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sachin, You're right. 'dw_mci_exynos_probe' is only used here. Acked-by: Seungwon Jeon <tgih.jun@samsung.com> On Monday, February 18, 2013, Jaehoon Chung wrote: > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> > > On 02/18/2013 05:53 PM, Sachin Kamat wrote: > > Silences the following sparse warning: > > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: > > symbol 'dw_mci_exynos_probe' was not declared. Should it be static? > > > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > --- > > drivers/mmc/host/dw_mmc-exynos.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > > index 72fd0f2..5a09c77 100644 > > --- a/drivers/mmc/host/dw_mmc-exynos.c > > +++ b/drivers/mmc/host/dw_mmc-exynos.c > > @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = { > > }; > > MODULE_DEVICE_TABLE(of, dw_mci_exynos_match); > > > > -int dw_mci_exynos_probe(struct platform_device *pdev) > > +static int dw_mci_exynos_probe(struct platform_device *pdev) > > { > > const struct dw_mci_drv_data *drv_data; > > const struct of_device_id *match; > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Chris, On 18 February 2013 16:21, Seungwon Jeon <tgih.jun@samsung.com> wrote: > Hi Sachin, > > You're right. > 'dw_mci_exynos_probe' is only used here. > > Acked-by: Seungwon Jeon <tgih.jun@samsung.com> > > On Monday, February 18, 2013, Jaehoon Chung wrote: >> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> >> >> On 02/18/2013 05:53 PM, Sachin Kamat wrote: >> > Silences the following sparse warning: >> > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: >> > symbol 'dw_mci_exynos_probe' was not declared. Should it be static? >> > >> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Can you please review this series?
On 4 March 2013 10:06, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Hi Chris, > > On 18 February 2013 16:21, Seungwon Jeon <tgih.jun@samsung.com> wrote: >> Hi Sachin, >> >> You're right. >> 'dw_mci_exynos_probe' is only used here. >> >> Acked-by: Seungwon Jeon <tgih.jun@samsung.com> >> >> On Monday, February 18, 2013, Jaehoon Chung wrote: >>> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> >>> >>> On 02/18/2013 05:53 PM, Sachin Kamat wrote: >>> > Silences the following sparse warning: >>> > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: >>> > symbol 'dw_mci_exynos_probe' was not declared. Should it be static? >>> > >>> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > Can you please review this series? > ping Chris. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Mon, Feb 18 2013, Sachin Kamat wrote: > Silences the following sparse warning: > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: > symbol 'dw_mci_exynos_probe' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mmc/host/dw_mmc-exynos.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index 72fd0f2..5a09c77 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = { > }; > MODULE_DEVICE_TABLE(of, dw_mci_exynos_match); > > -int dw_mci_exynos_probe(struct platform_device *pdev) > +static int dw_mci_exynos_probe(struct platform_device *pdev) > { > const struct dw_mci_drv_data *drv_data; > const struct of_device_id *match; Thanks, pushed to mmc-next for 3.10. - Chris.
>> -int dw_mci_exynos_probe(struct platform_device *pdev) >> +static int dw_mci_exynos_probe(struct platform_device *pdev) >> { >> const struct dw_mci_drv_data *drv_data; >> const struct of_device_id *match; > > Thanks, pushed to mmc-next for 3.10. Thanks Chris. There is also another patch in this series [1] that needs your attention. [1] https://patchwork.kernel.org/patch/2156621/
Hi, On Tue, Mar 12 2013, Sachin Kamat wrote: > There is also another patch in this series [1] that needs your attention. > [1] https://patchwork.kernel.org/patch/2156621/ I'd rather have one of the dw_mmc maintainers handle ACKing patches before I apply them. If they haven't reviewed it by the time we're getting ready to merge for 3.10, I can overrule them and apply it. Thanks, - Chris.
On 12 March 2013 20:30, Chris Ball <cjb@laptop.org> wrote: > Hi, > > On Tue, Mar 12 2013, Sachin Kamat wrote: >> There is also another patch in this series [1] that needs your attention. >> [1] https://patchwork.kernel.org/patch/2156621/ > > I'd rather have one of the dw_mmc maintainers handle ACKing patches > before I apply them. If they haven't reviewed it by the time we're > getting ready to merge for 3.10, I can overrule them and apply it. Thanks Chris. Seungwon, Jaehoon, Can you please review this patch? https://patchwork.kernel.org/patch/2156621/
Hi All, this patch has already got acked-by of Seungwon and me. Best Regards, Jaehoon Chung On 03/13/2013 12:04 AM, Sachin Kamat wrote: > On 12 March 2013 20:30, Chris Ball <cjb@laptop.org> wrote: >> Hi, >> >> On Tue, Mar 12 2013, Sachin Kamat wrote: >>> There is also another patch in this series [1] that needs your attention. >>> [1] https://patchwork.kernel.org/patch/2156621/ >> >> I'd rather have one of the dw_mmc maintainers handle ACKing patches >> before I apply them. If they haven't reviewed it by the time we're >> getting ready to merge for 3.10, I can overrule them and apply it. > > Thanks Chris. > > Seungwon, Jaehoon, > Can you please review this patch? > https://patchwork.kernel.org/patch/2156621/ > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jaehoon, On 13 March 2013 09:50, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Hi All, > > this patch has already got acked-by of Seungwon and me. It is needed for the second patch of this series "[PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr()" https://patchwork.kernel.org/patch/2156621/
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index 72fd0f2..5a09c77 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = { }; MODULE_DEVICE_TABLE(of, dw_mci_exynos_match); -int dw_mci_exynos_probe(struct platform_device *pdev) +static int dw_mci_exynos_probe(struct platform_device *pdev) { const struct dw_mci_drv_data *drv_data; const struct of_device_id *match;
Silences the following sparse warning: drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: symbol 'dw_mci_exynos_probe' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/mmc/host/dw_mmc-exynos.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)