| Message ID | 1365082866-28404-2-git-send-email-adrian.hunter@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2013-04-04 at 16:41 +0300, Adrian Hunter wrote: > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > index ad7decc..3bf1c46 100644 > --- a/drivers/mmc/core/core.c > +++ b/drivers/mmc/core/core.c > @@ -2418,7 +2418,6 @@ void mmc_start_host(struct mmc_host *host) > host->rescan_disable = 0; > mmc_power_up(host); > mmc_detect_change(host, 0); > - mmc_flush_scheduled_work(); > } > > void mmc_stop_host(struct mmc_host *host) Without some kind of synchronization between end of card probing and start of root mounting, it is not safe to have root on an mmc card. In other words, 'root_wait' will be mandatory to ensure successful mount of root filesystem on an mmc card. It may be worth documenting somewhere. It is not a big deal. I could live with a patched kernel or pass the parameter in the systems I work with. However, other people will fall in this trap later, and it would be nice to let them know what to do. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index ad7decc..3bf1c46 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -2418,7 +2418,6 @@ void mmc_start_host(struct mmc_host *host) host->rescan_disable = 0; mmc_power_up(host); mmc_detect_change(host, 0); - mmc_flush_scheduled_work(); } void mmc_stop_host(struct mmc_host *host)
This reverts commit 3500ed90b26a9935b943b5e2e4cd3226600d6b58. The reverted patch caused a significant performance regression when booting with the root file system on eMMC. Before the patch: [ 1.625623] VFS: Mounted root (ext4 filesystem) readonly on device 179:2. After the patch: [ 1.935851] VFS: Mounted root (ext4 filesystem) readonly on device 179:2. That was an addition of 310 ms which is a 19% performance degradation. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> --- drivers/mmc/core/core.c | 1 - 1 file changed, 1 deletion(-)