| Message ID | 1382433116-22180-1-git-send-email-yuvaraj.cd@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Acked-by: Jaehoon Chung <jh80.chung@samsung.com> Reported-by: Grant Grundler <grundler@chromium.org> On 10/22/2013 06:11 PM, Yuvaraj Kumar C D wrote: > commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning > ddr_timing value to sdr_timing.This patch fix's this by reverting > the sdr_timing assignment statement to the earlier location. > > Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com> > --- > drivers/mmc/host/dw_mmc-exynos.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index d42e664..3423c5e 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -251,12 +251,13 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host) > if (ret) > return ret; > > + priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); > + > ret = of_property_read_u32_array(np, > "samsung,dw-mshc-ddr-timing", timing, 2); > if (ret) > return ret; > > - priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); > priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); > host->priv = priv; > return 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, October 22, 2013, Jaehoon Chung wrote: > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> > Reported-by: Grant Grundler <grundler@chromium.org> Acked-by: Seungwon Jeon <tgih.jun@samsung.com> Thanks, Seungwon Jeon > > On 10/22/2013 06:11 PM, Yuvaraj Kumar C D wrote: > > commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning > > ddr_timing value to sdr_timing.This patch fix's this by reverting > > the sdr_timing assignment statement to the earlier location. > > > > Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com> > > --- > > drivers/mmc/host/dw_mmc-exynos.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > > index d42e664..3423c5e 100644 > > --- a/drivers/mmc/host/dw_mmc-exynos.c > > +++ b/drivers/mmc/host/dw_mmc-exynos.c > > @@ -251,12 +251,13 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host) > > if (ret) > > return ret; > > > > + priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); > > + > > ret = of_property_read_u32_array(np, > > "samsung,dw-mshc-ddr-timing", timing, 2); > > if (ret) > > return ret; > > > > - priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); > > priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); > > host->priv = priv; > > return 0; > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Yuvaraj, On Tue, Oct 22 2013, Yuvaraj Kumar C D wrote: > commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning > ddr_timing value to sdr_timing.This patch fix's this by reverting > the sdr_timing assignment statement to the earlier location. 4ad602c9df1e3 doesn't exist in mainline. Do you mean e6c784eded7b3 ("mmc: dw_mmc: exynos: move the exynos private init")? Thanks, - Chris.
On Sun, Oct 27, 2013 at 8:08 AM, Chris Ball <cjb@laptop.org> wrote: > Hi Yuvaraj, > > On Tue, Oct 22 2013, Yuvaraj Kumar C D wrote: >> commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning >> ddr_timing value to sdr_timing.This patch fix's this by reverting >> the sdr_timing assignment statement to the earlier location. > > 4ad602c9df1e3 doesn't exist in mainline. Do you mean e6c784eded7b3 > ("mmc: dw_mmc: exynos: move the exynos private init")? Yes Chris, thats the one. Do you want me to respin this patch with the updated commit message? > > Thanks, > > - Chris. > -- > Chris Ball <cjb@laptop.org> <http://printf.net/> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Yuvaraj, On Mon, Oct 28 2013, Yuvaraj Kumar wrote: > On Sun, Oct 27, 2013 at 8:08 AM, Chris Ball <cjb@laptop.org> wrote: >> Hi Yuvaraj, >> >> On Tue, Oct 22 2013, Yuvaraj Kumar C D wrote: >>> commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning >>> ddr_timing value to sdr_timing.This patch fix's this by reverting >>> the sdr_timing assignment statement to the earlier location. >> >> 4ad602c9df1e3 doesn't exist in mainline. Do you mean e6c784eded7b3 >> ("mmc: dw_mmc: exynos: move the exynos private init")? > Yes Chris, thats the one. > Do you want me to respin this patch with the updated commit message? No, that's okay, I fixed it and pushed to mmc-next for 3.13. Thanks, - Chris.
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index d42e664..3423c5e 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -251,12 +251,13 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host) if (ret) return ret; + priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); + ret = of_property_read_u32_array(np, "samsung,dw-mshc-ddr-timing", timing, 2); if (ret) return ret; - priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); host->priv = priv; return 0;
commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning ddr_timing value to sdr_timing.This patch fix's this by reverting the sdr_timing assignment statement to the earlier location. Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com> --- drivers/mmc/host/dw_mmc-exynos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)