| Message ID | 1382533832-21085-1-git-send-email-treding@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Soory, I thought I had corrected this typo.
Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@parrot.com>
Hi, On Wed, Oct 23 2013, Thierry Reding wrote: > Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets) > converts tasklets to work structs, but typos the conversion in the Dove > driver. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/mmc/host/sdhci-dove.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c > index 45c7f25..95f1076 100644 > --- a/drivers/mmc/host/sdhci-dove.c > +++ b/drivers/mmc/host/sdhci-dove.c > @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data) > { > struct sdhci_host *host = data; > > - schedule_schedule(&host->card_detect_work); > + schedule_work(&host->card_detect_work); > return IRQ_HANDLED; > } Thanks, Thierry -- I hope it's okay with you if I merge your fix into the original patch and add your S-o-b to that patch: Signed-off-by: Anton Vorontsov <avorontsov@mvista.com> Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@parrot.com> [treding: Fix typo causing sdhci-dove build breakage] Signed-off-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Chris Ball <cjb@laptop.org> - Chris.
On Sun, Oct 27, 2013 at 08:56:55AM -0400, Chris Ball wrote: > Hi, > > On Wed, Oct 23 2013, Thierry Reding wrote: > > Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets) > > converts tasklets to work structs, but typos the conversion in the Dove > > driver. > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > --- > > drivers/mmc/host/sdhci-dove.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c > > index 45c7f25..95f1076 100644 > > --- a/drivers/mmc/host/sdhci-dove.c > > +++ b/drivers/mmc/host/sdhci-dove.c > > @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data) > > { > > struct sdhci_host *host = data; > > > > - schedule_schedule(&host->card_detect_work); > > + schedule_work(&host->card_detect_work); > > return IRQ_HANDLED; > > } > > Thanks, Thierry -- I hope it's okay with you if I merge your fix into > the original patch and add your S-o-b to that patch: > > Signed-off-by: Anton Vorontsov <avorontsov@mvista.com> > Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@parrot.com> > [treding: Fix typo causing sdhci-dove build breakage] > Signed-off-by: Thierry Reding <treding@nvidia.com> > Signed-off-by: Chris Ball <cjb@laptop.org> Sure, no problem. Thierry
diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c index 45c7f25..95f1076 100644 --- a/drivers/mmc/host/sdhci-dove.c +++ b/drivers/mmc/host/sdhci-dove.c @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data) { struct sdhci_host *host = data; - schedule_schedule(&host->card_detect_work); + schedule_work(&host->card_detect_work); return IRQ_HANDLED; }
Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets) converts tasklets to work structs, but typos the conversion in the Dove driver. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/mmc/host/sdhci-dove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)