| Message ID | 1383142193-24950-2-git-send-email-b29396@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Oct 30, 2013 at 12:09 PM, Dong Aisheng <b29396@freescale.com> wrote: > The auto cmd settings bits should be cleared before sending new commands > or we may receive command timeout error for normal commands due to wrongly > pre-sent auto cmd. > > e.g. we receive CMD13 timeout error due to ACMD23 is wrongly enabled > by former data commands. > > mmc2: new high speed DDR MMC card at address 0001 > mmcblk1: mmc2:0001 SEM08G 7.39 GiB > mmcblk1boot0: mmc2:0001 SEM08G partition 1 2.00 MiB > mmcblk1boot1: mmc2:0001 SEM08G partition 2 2.00 MiB > mmcblk1rpmb: mmc2:0001 SEM08G partition 3 128 KiB > mmcblk1: p1 p2 p3 p4 < p5 p6 p7 > > mmc2: Timeout waiting for hardware interrupt. > mmcblk1boot1: unknown partition table > mmc2: Timeout waiting for hardware interrupt. > mmcblk1boot0: unknown partition table > > Signed-off-by: Dong Aisheng <b29396@freescale.com> Thanks for the patch, Dong. This fixes the eMMC interrupt timeout issue on mx6qsabresd. I think we should mark it for stable. At least 3.11 and 3.12 have this issue and your patch fixes it. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 68b3cac..22eab3a 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -903,8 +903,13 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host, u16 mode; struct mmc_data *data = cmd->data; - if (data == NULL) + if (data == NULL) { + /* clear Auto CMD settings for no data CMDs */ + mode = sdhci_readw(host, SDHCI_TRANSFER_MODE); + sdhci_writew(host, mode & ~(SDHCI_TRNS_AUTO_CMD12 | + SDHCI_TRNS_AUTO_CMD23), SDHCI_TRANSFER_MODE); return; + } WARN_ON(!host->data);
The auto cmd settings bits should be cleared before sending new commands or we may receive command timeout error for normal commands due to wrongly pre-sent auto cmd. e.g. we receive CMD13 timeout error due to ACMD23 is wrongly enabled by former data commands. mmc2: new high speed DDR MMC card at address 0001 mmcblk1: mmc2:0001 SEM08G 7.39 GiB mmcblk1boot0: mmc2:0001 SEM08G partition 1 2.00 MiB mmcblk1boot1: mmc2:0001 SEM08G partition 2 2.00 MiB mmcblk1rpmb: mmc2:0001 SEM08G partition 3 128 KiB mmcblk1: p1 p2 p3 p4 < p5 p6 p7 > mmc2: Timeout waiting for hardware interrupt. mmcblk1boot1: unknown partition table mmc2: Timeout waiting for hardware interrupt. mmcblk1boot0: unknown partition table Signed-off-by: Dong Aisheng <b29396@freescale.com> --- drivers/mmc/host/sdhci.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)