From patchwork Wed Jan 29 22:38:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 3554971 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AF7BFC02DC for ; Wed, 29 Jan 2014 22:38:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DD68020170 for ; Wed, 29 Jan 2014 22:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17B442017E for ; Wed, 29 Jan 2014 22:38:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751023AbaA2Wi3 (ORCPT ); Wed, 29 Jan 2014 17:38:29 -0500 Received: from mail-lb0-f170.google.com ([209.85.217.170]:41204 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbaA2Wi2 (ORCPT ); Wed, 29 Jan 2014 17:38:28 -0500 Received: by mail-lb0-f170.google.com with SMTP id u14so1961357lbd.15 for ; Wed, 29 Jan 2014 14:38:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hALE2kwt+9HdNO7QDkIgHzh6VERDLvwmISpgXvIgWyg=; b=OcbFLmDyMHTmXekBAHJWzs+BQR2Qo1cnXlbHufvjZh9SBFm7wqmMRORtBpSj2kTxvP INcubz6m/qKSEDYTY66NNPQfWMRsZFlemmnqlOUtAntm1DTElRok+V+8OYUz3KC/BURC dQv5SaQ+SCZEjyoO3C2q7AFf/ny8kSEuGiSKC//ybpyqPgeK8B3ZwSYEjB5a+sdJPqFo dPJlzSOI1ZSjvIISxVNq52btF22slHKLDm2IW3Qzcdo9sH71rM/p8kcEUH9yVOhsUfHo nvzh6fI3mBZRbqTs8mMgH0bCTB78b5atJYlYdz/aJan5gm6xM4iBnB/CQA/VVncS79yA 7WyA== X-Gm-Message-State: ALoCoQk5HwkLyBz9/+RLph2tZiqR/it9YWRsBnOj2Bz8txOjEfmQ/5iHX/oITBFQbl3i+IPuqvwv X-Received: by 10.152.234.202 with SMTP id ug10mr529987lac.28.1391035107627; Wed, 29 Jan 2014 14:38:27 -0800 (PST) Received: from linaro-ulf.lan (90-231-160-185-no158.tbcn.telia.com. [90.231.160.185]) by mx.google.com with ESMTPSA id wt2sm3998221lbb.2.2014.01.29.14.38.25 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 29 Jan 2014 14:38:26 -0800 (PST) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Chris Ball Cc: Dong Aisheng , Stephen Warren , Vladimir Zapolskiy , Adrian Hunter , Ulf Hansson Subject: [PATCH 08/13] mmc: block: Use R1 responses for stop cmds for read requests Date: Wed, 29 Jan 2014 23:38:00 +0100 Message-Id: <1391035085-2747-9-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1391035085-2747-1-git-send-email-ulf.hansson@linaro.org> References: <1391035085-2747-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While using open ended transmission and thus ending the transfer by sending a stop command, we shall use R1B only for writes and R1 shall be used for reads. Previously R1B were used in both cases. Signed-off-by: Ulf Hansson --- drivers/mmc/card/block.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 7b5424f..87cd2b0 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -1335,7 +1335,6 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq, brq->data.blksz = 512; brq->stop.opcode = MMC_STOP_TRANSMISSION; brq->stop.arg = 0; - brq->stop.flags = MMC_RSP_SPI_R1B | MMC_RSP_R1B | MMC_CMD_AC; brq->data.blocks = blk_rq_sectors(req); /* @@ -1378,9 +1377,15 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq, if (rq_data_dir(req) == READ) { brq->cmd.opcode = readcmd; brq->data.flags |= MMC_DATA_READ; + if (brq->mrq.stop) + brq->stop.flags = MMC_RSP_SPI_R1 | MMC_RSP_R1 | + MMC_CMD_AC; } else { brq->cmd.opcode = writecmd; brq->data.flags |= MMC_DATA_WRITE; + if (brq->mrq.stop) + brq->stop.flags = MMC_RSP_SPI_R1B | MMC_RSP_R1B | + MMC_CMD_AC; } if (do_rel_wr)