From patchwork Tue Apr 22 23:51:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 4037021 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 841D29F1F4 for ; Tue, 22 Apr 2014 23:51:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 899F0201E7 for ; Tue, 22 Apr 2014 23:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 731EB201C7 for ; Tue, 22 Apr 2014 23:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbaDVXv3 (ORCPT ); Tue, 22 Apr 2014 19:51:29 -0400 Received: from mail-vc0-f202.google.com ([209.85.220.202]:55085 "EHLO mail-vc0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752494AbaDVXv1 (ORCPT ); Tue, 22 Apr 2014 19:51:27 -0400 Received: by mail-vc0-f202.google.com with SMTP id lh14so43778vcb.1 for ; Tue, 22 Apr 2014 16:51:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=US7ga32SdcHOxKJ8JjC2D1v1uCZ0xW2c/W14fcFywwE=; b=kMvQrGfPsvjT5/8JUje5ghogQWs/TbxmqDKSJmMQ9hQpS98qyJdoiXye+UfW/o40cn 503q9Mg+/mXIH5RaD4I1Kj6uCzxu4NbQB0TlnFa2K8PtoQ9FEmTbgoc+Lujrxq6fmNXK HQxruiiARQHwnIe6gNSGusWFyZm9XSLLRfYxsOw5JlQEE2x2K5rfn5B3f1IQt7pEI08n 4+inQ0pnBn6bFCuqYX8pCZABD1JZOPvy7zwfa2UBG/Kb2PmS225UmqYC+eTeXnWehP23 VxRljPSkKDn3ArHzRglH5CszjfFJEk54kiD6YwX7WOme8PfVxhXmMSsZplo7DEs86dpK NUSw== X-Gm-Message-State: ALoCoQmywJm5H3KP7VKstnVPoESt+Fz67FOZO67yvMPDyRarQQJzrpu3TiSOA/wKg4xxA7UZUwNSudOF6AX1wFzWGiWAR88MPz8l1iBMNL3Lf8G2CUO/7jcSxUO0cNyNVryo9Z6dY2FntGjimnL59Z9JlBoRfAx22ls7K2Lma6vn6NDzbSXCZmbbAt1q2wDhWm/Hu6QH/8xrC4V6dshmjCjw7CeXjRe6WA== X-Received: by 10.236.203.113 with SMTP id e77mr21282208yho.15.1398210686794; Tue, 22 Apr 2014 16:51:26 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id e40si5823110yhf.0.2014.04.22.16.51.26 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Apr 2014 16:51:26 -0700 (PDT) Received: from tictac.mtv.corp.google.com (tictac.mtv.corp.google.com [172.22.72.141]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 9EB0631C04E; Tue, 22 Apr 2014 16:51:26 -0700 (PDT) Received: by tictac.mtv.corp.google.com (Postfix, from userid 121310) id 3822A80953; Tue, 22 Apr 2014 16:51:26 -0700 (PDT) From: Doug Anderson To: Seungwon Jeon , Jaehoon Chung Cc: yuvaraj.cd@samsung.com, Alim Akhtar , Sonny Rao , linux-samsung-soc@vger.kernel.org, Doug Anderson , chris@printf.net, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: dw_mmc: Don't print data errors Date: Tue, 22 Apr 2014 16:51:21 -0700 Message-Id: <1398210681-22976-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 1.9.1.423.g4596e3a Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Data errors are completely expected during tuning. Printing them out is confusing people looking at the kernel logs. They see things like: [ 3.613296] dwmmc_exynos 12200000.dwmmc0: data error, status 0x00000088 ...and they think something is wrong with their hardware. Remove the printouts. We'll leave it up to a higher level to report about errors. Signed-off-by: Doug Anderson Reviewed-by: Alim Akhtar --- drivers/mmc/host/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index cced599..4c8d423 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1248,7 +1248,7 @@ static int dw_mci_data_complete(struct dw_mci *host, struct mmc_data *data) data->error = -EIO; } - dev_err(host->dev, "data error, status 0x%08x\n", status); + dev_dbg(host->dev, "data error, status 0x%08x\n", status); /* * After an error, there may be data lingering