| Message ID | 1399714443-12459-3-git-send-email-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Hans, Thanks for your follow up on this. On Sat, May 10, 2014 at 11:33:59AM +0200, Hans de Goede wrote: > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > arch/arm/boot/dts/sunxi-common-regulators.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/sunxi-common-regulators.dtsi b/arch/arm/boot/dts/sunxi-common-regulators.dtsi > index 18eeac0..ebbba39 100644 > --- a/arch/arm/boot/dts/sunxi-common-regulators.dtsi > +++ b/arch/arm/boot/dts/sunxi-common-regulators.dtsi > @@ -72,4 +72,12 @@ > gpio = <&pio 7 3 0>; > status = "disabled"; > }; > + > + reg_vmmc0: vmmc0 { > + compatible = "regulator-fixed"; > + regulator-name = "vmmc0"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + status = "disabled"; > + }; I think you can rather define this as vcc-3.3v or something alike, that would always be enabled. That would allow to reuse this in some other nodes as well, you won't need to enable it on every board, and this is actually more accurate. Thanks! Maxime
diff --git a/arch/arm/boot/dts/sunxi-common-regulators.dtsi b/arch/arm/boot/dts/sunxi-common-regulators.dtsi index 18eeac0..ebbba39 100644 --- a/arch/arm/boot/dts/sunxi-common-regulators.dtsi +++ b/arch/arm/boot/dts/sunxi-common-regulators.dtsi @@ -72,4 +72,12 @@ gpio = <&pio 7 3 0>; status = "disabled"; }; + + reg_vmmc0: vmmc0 { + compatible = "regulator-fixed"; + regulator-name = "vmmc0"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + status = "disabled"; + }; };
Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- arch/arm/boot/dts/sunxi-common-regulators.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)