diff mbox

[1/1] mmc: quirks: Fixup debug message

Message ID 1400585361-5194-1-git-send-email-alexander.stein@systec-electronic.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alexander Stein May 20, 2014, 11:29 a.m. UTC 
There is no need for an output like this:
> mmcblk mmc1:0001: calling add_quirk_mmc+0x0/0x20
Instead use this one:
> mmcblk mmc1:0001: calling add_quirk_mmc

Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
 drivers/mmc/core/quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Stein June 3, 2014, 7:54 a.m. UTC | #1 
Any feedback in this?

Thanks,
Alexander

On Tuesday 20 May 2014 13:29:21, Alexander Stein wrote:
> There is no need for an output like this:
> > mmcblk mmc1:0001: calling add_quirk_mmc+0x0/0x20
> Instead use this one:
> > mmcblk mmc1:0001: calling add_quirk_mmc
> 
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>  drivers/mmc/core/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.c
> index 6c36fcc..dd1d1e0 100644
> --- a/drivers/mmc/core/quirks.c
> +++ b/drivers/mmc/core/quirks.c
> @@ -91,7 +91,7 @@ void mmc_fixup_device(struct mmc_card *card, const struct mmc_fixup *table)
>  		    (f->cis_device == card->cis.device ||
>  		     f->cis_device == (u16) SDIO_ANY_ID) &&
>  		    rev >= f->rev_start && rev <= f->rev_end) {
> -			dev_dbg(&card->dev, "calling %pF\n", f->vendor_fixup);
> +			dev_dbg(&card->dev, "calling %pf\n", f->vendor_fixup);
>  			f->vendor_fixup(card, f->data);
>  		}
>  	}
>
Ulf Hansson June 16, 2014, 8:55 a.m. UTC | #2 
On 20 May 2014 13:29, Alexander Stein
<alexander.stein@systec-electronic.com> wrote:
> There is no need for an output like this:
>> mmcblk mmc1:0001: calling add_quirk_mmc+0x0/0x20
> Instead use this one:
>> mmcblk mmc1:0001: calling add_quirk_mmc
>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>

Thanks! Applied for next.

Kind regards
Uffe

> ---
>  drivers/mmc/core/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.c
> index 6c36fcc..dd1d1e0 100644
> --- a/drivers/mmc/core/quirks.c
> +++ b/drivers/mmc/core/quirks.c
> @@ -91,7 +91,7 @@ void mmc_fixup_device(struct mmc_card *card, const struct mmc_fixup *table)
>                     (f->cis_device == card->cis.device ||
>                      f->cis_device == (u16) SDIO_ANY_ID) &&
>                     rev >= f->rev_start && rev <= f->rev_end) {
> -                       dev_dbg(&card->dev, "calling %pF\n", f->vendor_fixup);
> +                       dev_dbg(&card->dev, "calling %pf\n", f->vendor_fixup);
>                         f->vendor_fixup(card, f->data);
>                 }
>         }
> --
> 1.8.5.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.c
index 6c36fcc..dd1d1e0 100644
--- a/drivers/mmc/core/quirks.c
+++ b/drivers/mmc/core/quirks.c
@@ -91,7 +91,7 @@  void mmc_fixup_device(struct mmc_card *card, const struct mmc_fixup *table)
 		    (f->cis_device == card->cis.device ||
 		     f->cis_device == (u16) SDIO_ANY_ID) &&
 		    rev >= f->rev_start && rev <= f->rev_end) {
-			dev_dbg(&card->dev, "calling %pF\n", f->vendor_fixup);
+			dev_dbg(&card->dev, "calling %pf\n", f->vendor_fixup);
 			f->vendor_fixup(card, f->data);
 		}
 	}