diff mbox

[1/6] mmc: sh-mmcif: update to print version and bus clock rate on probe

Message ID 1401882133-11050-2-git-send-email-ben.dooks@codethink.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Ben Dooks June 4, 2014, 11:42 a.m. UTC
Change the initial print to show chip version and the bus rate it is
working at instead of the driver version. This is more useful information
as we already know which driver version from the kernel it is in.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/mmc/host/sh_mmcif.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Ulf Hansson June 4, 2014, 12:57 p.m. UTC | #1
On 4 June 2014 13:42, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> Change the initial print to show chip version and the bus rate it is
> working at instead of the driver version. This is more useful information
> as we already know which driver version from the kernel it is in.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

> ---
>  drivers/mmc/host/sh_mmcif.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 54730f4..7f819f1 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -1468,16 +1468,17 @@ static int sh_mmcif_probe(struct platform_device *pdev)
>
>         mutex_init(&host->thread_lock);
>
> -       clk_disable_unprepare(host->hclk);
>         ret = mmc_add_host(mmc);
>         if (ret < 0)
>                 goto emmcaddh;
>
>         dev_pm_qos_expose_latency_limit(&pdev->dev, 100);
>
> -       dev_info(&pdev->dev, "driver version %s\n", DRIVER_VERSION);
> -       dev_dbg(&pdev->dev, "chip ver H'%04x\n",
> -               sh_mmcif_readl(host->addr, MMCIF_CE_VERSION) & 0x0000ffff);
> +       dev_info(&pdev->dev, "Chip version 0x%04x, clock rate %luMHz\n",
> +                sh_mmcif_readl(host->addr, MMCIF_CE_VERSION) & 0xffff,
> +                clk_get_rate(host->hclk) / 1000000UL);
> +
> +       clk_disable_unprepare(host->hclk);
>         return ret;
>
>  emmcaddh:
> --
> 2.0.0.rc2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 54730f4..7f819f1 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -1468,16 +1468,17 @@  static int sh_mmcif_probe(struct platform_device *pdev)
 
 	mutex_init(&host->thread_lock);
 
-	clk_disable_unprepare(host->hclk);
 	ret = mmc_add_host(mmc);
 	if (ret < 0)
 		goto emmcaddh;
 
 	dev_pm_qos_expose_latency_limit(&pdev->dev, 100);
 
-	dev_info(&pdev->dev, "driver version %s\n", DRIVER_VERSION);
-	dev_dbg(&pdev->dev, "chip ver H'%04x\n",
-		sh_mmcif_readl(host->addr, MMCIF_CE_VERSION) & 0x0000ffff);
+	dev_info(&pdev->dev, "Chip version 0x%04x, clock rate %luMHz\n",
+		 sh_mmcif_readl(host->addr, MMCIF_CE_VERSION) & 0xffff,
+		 clk_get_rate(host->hclk) / 1000000UL);
+
+	clk_disable_unprepare(host->hclk);
 	return ret;
 
 emmcaddh: