diff mbox

mmc: sunxi: add MMC_CAP_SDIO_IRQ capability

Message ID 1426001796-19231-1-git-send-email-hdegoede@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hans de Goede March 10, 2015, 3:36 p.m. UTC
When the sunxi mmc-controller code was initially merged MMC_CAP_SDIO_IRQ was
not added to the host caps because of issues with some sdio wifi modules.

It turns out that these issues have nothing to do with using sdio-irq support,
they also happen with oob interrupts. Since the hardware supports sdio-irq
everywhere, and since the one reason to not claim the capability is gone,
add MMC_CAP_SDIO_IRQ to the default host caps.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/mmc/host/sunxi-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ulf Hansson March 13, 2015, 10:14 a.m. UTC | #1
On 10 March 2015 at 16:36, Hans de Goede <hdegoede@redhat.com> wrote:
> When the sunxi mmc-controller code was initially merged MMC_CAP_SDIO_IRQ was
> not added to the host caps because of issues with some sdio wifi modules.
>
> It turns out that these issues have nothing to do with using sdio-irq support,
> they also happen with oob interrupts. Since the hardware supports sdio-irq
> everywhere, and since the one reason to not claim the capability is gone,
> add MMC_CAP_SDIO_IRQ to the default host caps.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Thanks, applied!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sunxi-mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index e8a4218..94eee54 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1028,7 +1028,7 @@ static int sunxi_mmc_probe(struct platform_device *pdev)
>         mmc->f_min              =   400000;
>         mmc->f_max              = 50000000;
>         mmc->caps              |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
> -                                 MMC_CAP_ERASE;
> +                                 MMC_CAP_ERASE | MMC_CAP_SDIO_IRQ;
>
>         ret = mmc_of_parse(mmc);
>         if (ret)
> --
> 2.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index e8a4218..94eee54 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1028,7 +1028,7 @@  static int sunxi_mmc_probe(struct platform_device *pdev)
 	mmc->f_min		=   400000;
 	mmc->f_max		= 50000000;
 	mmc->caps	       |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
-				  MMC_CAP_ERASE;
+				  MMC_CAP_ERASE | MMC_CAP_SDIO_IRQ;
 
 	ret = mmc_of_parse(mmc);
 	if (ret)