| Message ID | 1426802354-3272-1-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19 March 2015 at 22:59, Fabio Estevam <festevam@gmail.com> wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Commit 46a3b345d38518 ("mmc: sdhci-esdhc-imx: Call mmc_of_parse()") caused > regression on some mx6q platforms: > > [ 1.478666] sdhci: Secure Digital Host Controller Interface driver > [ 1.484912] sdhci: Copyright(c) Pierre Ossman > [ 1.489333] sdhci-pltfm: SDHCI platform and OF driver helper > [ 1.496441] sdhci-esdhc-imx 2194000.usdhc: could not get ultra high speed state, work on normal mode > [ 1.505878] sdhci-esdhc-imx: probe of 2194000.usdhc failed with error -16 > > Reported-by: Olof's autobooter <build@lixom.net> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Olof, Fabio, Thanks for looking into this. Since I rebase my branch quite frequently, I preferred to just drop the original patch instead of applying the revert. So that done now! Kind regards Uffe > --- > I don't have hardware access at the moment to debug this issue, so reverting it > for now. > > drivers/mmc/host/sdhci-esdhc-imx.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index 631e136..9cce5cf 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -1075,11 +1075,6 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; > } > > - /* call to generic mmc_of_parse to support additional capabilities */ > - err = mmc_of_parse(host->mmc); > - if (err) > - goto disable_clk; > - > err = sdhci_add_host(host); > if (err) > goto disable_clk; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 631e136..9cce5cf 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1075,11 +1075,6 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; } - /* call to generic mmc_of_parse to support additional capabilities */ - err = mmc_of_parse(host->mmc); - if (err) - goto disable_clk; - err = sdhci_add_host(host); if (err) goto disable_clk;