From patchwork Thu Mar 19 21:59:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 6052551 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F126D9F2A9 for ; Thu, 19 Mar 2015 21:59:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1D9CA2050B for ; Thu, 19 Mar 2015 21:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 105DB204D1 for ; Thu, 19 Mar 2015 21:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750799AbbCSV72 (ORCPT ); Thu, 19 Mar 2015 17:59:28 -0400 Received: from mail-qc0-f172.google.com ([209.85.216.172]:34795 "EHLO mail-qc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbbCSV71 (ORCPT ); Thu, 19 Mar 2015 17:59:27 -0400 Received: by qcaz10 with SMTP id z10so79257110qca.1 for ; Thu, 19 Mar 2015 14:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=xCRAbqCG8Jzl5xKgUrAVZTq/VAu5c/Qf32R7o22I9c8=; b=RQz3qj+hOHh1pEoDoayzzek0szi+mfq0dJ25rw+7Kts+RpjiSpownGWDEB92iD0+7o Orv6EQq0Qslh8lty1PZegtHfTJ1r/Txv5yGHrmbEpDS+JIL6uBM/CVZwxEQaFVmvlsjH iZjwpleYALPb5A4MPQkJTtZ1/TXgb7bEobTFc6aDzrhiNwRUy5xAp+vvbyrgPEMoRdO0 ztns1oZu4jqMmh2t1B3fbt1RaeyfVTL1shJLhLsdj4+RaBgSZrhCDbRFSg9T6gBK0UxX U1fN95zDg6IibCDfXX3Glenf2dpkrr87NY6ARapb7KOqTEX77RAMpBr2gsJmq12PTBWU Ojlg== X-Received: by 10.55.15.104 with SMTP id z101mr92338409qkg.19.1426802366430; Thu, 19 Mar 2015 14:59:26 -0700 (PDT) Received: from localhost.localdomain ([187.66.157.195]) by mx.google.com with ESMTPSA id g21sm1705790qhc.35.2015.03.19.14.59.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Mar 2015 14:59:25 -0700 (PDT) From: Fabio Estevam To: ulf.hansson@linaro.org Cc: linux-mmc@vger.kernel.org, olof@lixom.net, Fabio Estevam Subject: [PATCH] Revert "mmc: sdhci-esdhc-imx: Call mmc_of_parse()" Date: Thu, 19 Mar 2015 18:59:14 -0300 Message-Id: <1426802354-3272-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam Commit 46a3b345d38518 ("mmc: sdhci-esdhc-imx: Call mmc_of_parse()") caused regression on some mx6q platforms: [ 1.478666] sdhci: Secure Digital Host Controller Interface driver [ 1.484912] sdhci: Copyright(c) Pierre Ossman [ 1.489333] sdhci-pltfm: SDHCI platform and OF driver helper [ 1.496441] sdhci-esdhc-imx 2194000.usdhc: could not get ultra high speed state, work on normal mode [ 1.505878] sdhci-esdhc-imx: probe of 2194000.usdhc failed with error -16 Reported-by: Olof's autobooter Signed-off-by: Fabio Estevam --- I don't have hardware access at the moment to debug this issue, so reverting it for now. drivers/mmc/host/sdhci-esdhc-imx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 631e136..9cce5cf 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1075,11 +1075,6 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; } - /* call to generic mmc_of_parse to support additional capabilities */ - err = mmc_of_parse(host->mmc); - if (err) - goto disable_clk; - err = sdhci_add_host(host); if (err) goto disable_clk;