From patchwork Wed Jun 17 17:33:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 6627431 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3103F9F1C1 for ; Wed, 17 Jun 2015 17:52:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4C87A20856 for ; Wed, 17 Jun 2015 17:51:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5228B20709 for ; Wed, 17 Jun 2015 17:51:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753449AbbFQRv5 (ORCPT ); Wed, 17 Jun 2015 13:51:57 -0400 Received: from mail-by2on0136.outbound.protection.outlook.com ([207.46.100.136]:63952 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932296AbbFQRv4 (ORCPT ); Wed, 17 Jun 2015 13:51:56 -0400 X-Greylist: delayed 953 seconds by postgrey-1.27 at vger.kernel.org; Wed, 17 Jun 2015 13:51:56 EDT Received: from CO2PR03CA0050.namprd03.prod.outlook.com (10.141.194.177) by BN1PR03MB251.namprd03.prod.outlook.com (10.255.200.18) with Microsoft SMTP Server (TLS) id 15.1.195.6; Wed, 17 Jun 2015 17:36:52 +0000 Received: from BN1BFFO11FD019.protection.gbl (2a01:111:f400:7c10::1:184) by CO2PR03CA0050.outlook.office365.com (2a01:111:e400:1414::49) with Microsoft SMTP Server (TLS) id 15.1.190.14 via Frontend Transport; Wed, 17 Jun 2015 17:36:52 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; lists.infradead.org; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD019.mail.protection.outlook.com (10.58.144.82) with Microsoft SMTP Server (TLS) id 15.1.190.9 via Frontend Transport; Wed, 17 Jun 2015 17:36:24 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id t5HHZpv4016757; Wed, 17 Jun 2015 10:36:16 -0700 From: Dong Aisheng To: CC: , , , , , , , , , , , , , , , , , , , , Subject: [PATCH 4/5] dts: imx25: fix sd card gpio polarity specified in device tree Date: Thu, 18 Jun 2015 01:33:37 +0800 Message-ID: <1434562418-24090-5-git-send-email-aisheng.dong@freescale.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1434562418-24090-1-git-send-email-aisheng.dong@freescale.com> References: <1434562418-24090-1-git-send-email-aisheng.dong@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD019; 1:Gn3pGUTd5jSX/qLQBrFLuhGNPRSz7aaQnQZwg3JF7kHstKLfv78GhgaWwYBpfq+WKGamAcC9FVSmM4YeHsYQbQpkkm7lNkO9E3/y7/jh/CQhVnIWeFX4d7yUzoccEfRFuP2youAr0iANbQUO/uPD/NpOiY/+4eUpRzkaprlGEOBMILu+L+7evUZexWfBtoesAVVkNQmtKRKnfNiMlRniWwonc8zIS73xRTHaZTFFX1Ik8Es2S4oUejG4nAs64EXJFvz3fQ4DZk4b3eXhxs9uUn0OOZERI0jQqTEq1Ze0vsQjzxu3f3ybLw4j2l736hqpycrem6wDS1WLNbWl201aPo2bdzkcrSxrw6Uno6oHHd8= X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(339900001)(199003)(189002)(77096005)(50226001)(86362001)(105606002)(46102003)(189998001)(2950100001)(87936001)(50986999)(76176999)(36756003)(47776003)(104016003)(48376002)(6806004)(85426001)(50466002)(33646002)(81156007)(92566002)(5001920100001)(110136002)(19580395003)(19580405001)(5001960100002)(77156002)(62966003)(2351001)(106466001)(229853001); DIR:OUT; SFP:1102; SCL:1; SRVR:BN1PR03MB251; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BN1PR03MB251; 2:pG4yAixb1s0eunOdukt3UMF9yrY50AxZdl4hIFi2KEakpfOXWC3IJyap67bfRMzE; 3:Fk2S0OjxdLWu0uV7kvFXdcM7OlKn6iTE8Elwyg9wCAVFqsuUv4B+kNplTgo+eleKfuKYvAs/3eozbY5dtQZ95JGdzz39scU9X+F6IWK+rsDzgNarwEVMGfepI23Qrwb0bm3hTZ2CdNri9I0u2OFbl8lBb07pO/AtNC4aJcgYon67NGb7lwHT0d/KQePsX9jrtJDKg5+4KvQClbAl6GoMdp2YhQawOIA7Tub8gYokmQU=; 20:NMonTE0rXvRMMZUm3IA/mP8tcHtYUfoHhtfaZibH8l4f5MDigsDzXTPCzCPf6qhD8GcsD1IYGSIJsLpQwx9akM4jRrj5x1d4w5kww+iaLvs1EN0J3eiMnLamM43LC0SDVbWW7hQa5dKdJUHV38uvNiBu2hV8hLauS35CLqaB287PsBZLntDDrhusih0+GKAgnqphdEUqmYDjz99TaMOkV53JQfkNfQHiHP7VoY7XLHancMBJLhUmCKFi3LXMBb3dFIBP+Kc6IAUr3f5MluHLVUzlGsMJE+xsPzFZTzYp9hf2/IjtxMDCBcQLww8Z32W7JtMCAQic1l2iX4uC1BbX/gJgiw/9WBKqVquJVs7g9Aw=; 4:SFZdkASCQRlMtomw2wsjdkB3nzOUDPPd+K/QAmhsN+oRKNCt6VepHndsHuZHFzp8h+EfMkquRFSLp5mgVqlyZTw6to6RoieNpaPLxs3FRaZgh1R+0Hn3LqPvPs3odGV8nuULiqtqq7rVmnOrFNImDu3r6BsOpFuKbxpn5uRt6CoyM+YgE/DUI9KP+c5KxQR/xZPE/phEiswvGyBIShugmwEANcLo9WEbtwAhbdcgzg9RsIDo/uN+56LRuvfYndcoZAS7LS1Om qsdVIvSho/xHHzttQxhJU8mxUYt2Zhqyj8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB251; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BN1PR03MB251; BCL:0; PCL:0; RULEID:; SRVR:BN1PR03MB251; X-Forefront-PRVS: 0610D16BBE X-Microsoft-Exchange-Diagnostics: 1; BN1PR03MB251; 23:d2LPQ/9VTvW4cgB4jNBwqaginNZMHZjOS7/VNHpc1Zk65IK35OP9rWlxJTwu9PhN5xG3vraJL5Hd8egqx2Oq/3NLfRvryvSsypD6eFRI1beAT2LNx52tp6Dseb+nUp3Xjj/O0MyoSKKaOhws7YpHqspaxwuwRZBIAvhSbTFFNtDkOluGveJHz3gUEeSDk0S6mTL89/pppOSLpilKV2g54iilOWvVn417W/T7GCEu+24TfjpNHBSea6exBm8+um3vzxaK/Zq3q/+4GvmQgnkIzTGZ5OQ1ORDuMn8CNOAZidHoPsg+q9hwLZ4cZ+bOAJK9hXpHilWs9OLPa3/jYRhKscWPN/w9ei754bkFxEzNKSzMOkBapcMgQgRxuSzKL/vHyICR3Ri6cQhxTeKe6PElw9R3RFORsWTR+R7NkTG+etf8zmGQhYJK6HOZuywn6vPGloAc+QCyO3o8/g+4PFD2Q0imbOqKNYI4nxMRsPluUqTUXszmf6t5tosTSzJ8PZ1DbvX9fyPrhIiiIp6qH36RfnFZX074et7+f5nSl0MXE1Lb4Kl3U6FTe3tqDSN0e7BFWeAwdfiK4kLrf3Wee/ewjFBhdGwmuXUglcBGjCmLjSgsoBBgiFBkwR4ylJbfgZM2Nl3fBNH1w7JBVMqOW5XvELxvowgwqT1YJW2YnRyNe0SiZRxHOuQfUo/t5j+cG9+HRa2ecc4yG7IJrGqYGecLk196NOB+4lIWKEHL4tLJYloHTViCyb2lRZnd0cy8C/fxqGwL9Xq2g/DqqZ8nHQEkpO/ewUhUMdtqRK1wQBX+/bjtcxQ1cT7p5y0Lm5RM3nqG9SSdY9twkvUsXOqRGyLpv6kFabRh1JB5SafShsBIAQ8v4RImKvNasNdGp0VBDVEj0T6A60bOo/JSQZOpvjU+1gDKCE5LLKBi1bTECol9wi I= X-Microsoft-Exchange-Diagnostics: 1; BN1PR03MB251; 5:gVm/r4h7T3MTI8/LEV4GaAZcZHP488MsiRT6MC/x27VIggTFFfEAhptzXwEd4DsAUKlMPg+RPlLhU4c6VCPnB/V6RjZ4IIqtrlPudhgz4kdPaZ8f4XPHIaXAyN+osYIYsSUH0+oqq8JqqWJboO/BLg==; 24:uTOCU5ptZh0aevgI6dG4miYXCHGOadynMoEMohCVnLJ6b/s5zXsvvUVwzlH4986j58MI4+y0KX/bYK0oN/tTcpj5n5v4xcoFVsBNgdL2RLE=; 20:G91wB+xuFaOKr7Mxj7vaoKRZfDcp0BxwlRkRFRboPCqP5TZz4VFGtqkugv/jjf8uB7QYVjbs3lhu4vhiuqT+/g== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2015 17:36:24.5570 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB251 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP cd-gpios polarity should be changed to GPIO_ACTIVE_LOW and wp-gpios should be changed to GPIO_ACTIVE_HIGH. Otherwise, the SD may not work properly due to wrong polarity inversion specified in DT after switch to common parsing function mmc_of_parse(). Signed-off-by: Dong Aisheng --- arch/arm/boot/dts/imx25-pdk.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts index dd45e69..faf252f 100644 --- a/arch/arm/boot/dts/imx25-pdk.dts +++ b/arch/arm/boot/dts/imx25-pdk.dts @@ -114,8 +114,8 @@ &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; - cd-gpios = <&gpio2 1 0>; - wp-gpios = <&gpio2 0 0>; + cd-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio2 0 GPIO_ACTIVE_HIGH>; status = "okay"; };