From patchwork Wed Jul 22 12:53:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 6844731 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C471DC05AC for ; Wed, 22 Jul 2015 14:17:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CC335206AA for ; Wed, 22 Jul 2015 14:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95641206B2 for ; Wed, 22 Jul 2015 14:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934304AbbGVORw (ORCPT ); Wed, 22 Jul 2015 10:17:52 -0400 Received: from mail-by2on0105.outbound.protection.outlook.com ([207.46.100.105]:54330 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934253AbbGVORv (ORCPT ); Wed, 22 Jul 2015 10:17:51 -0400 Received: from BLUPR03MB1409.namprd03.prod.outlook.com (10.163.81.143) by BLUPR03MB358.namprd03.prod.outlook.com (10.141.75.152) with Microsoft SMTP Server (TLS) id 15.1.225.13; Wed, 22 Jul 2015 14:03:07 +0000 Received: from BN3PR0301CA0051.namprd03.prod.outlook.com (10.160.152.147) by BLUPR03MB1409.namprd03.prod.outlook.com (10.163.81.143) with Microsoft SMTP Server (TLS) id 15.1.219.17; Wed, 22 Jul 2015 14:03:06 +0000 Received: from BN1BFFO11FD012.protection.gbl (2a01:111:f400:7c10::1:185) by BN3PR0301CA0051.outlook.office365.com (2a01:111:e400:401e::19) with Microsoft SMTP Server (TLS) id 15.1.225.19 via Frontend Transport; Wed, 22 Jul 2015 14:03:06 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; gmail.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD012.mail.protection.outlook.com (10.58.144.75) with Microsoft SMTP Server (TLS) id 15.1.213.8 via Frontend Transport; Wed, 22 Jul 2015 14:03:05 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id t6ME2iY0019637; Wed, 22 Jul 2015 07:02:59 -0700 From: Dong Aisheng To: CC: , , , , , , , , , , , , , , , , , , , , Subject: [PATCH V2 02/11] dts: imx53: fix sd card gpio polarity specified in device tree Date: Wed, 22 Jul 2015 20:53:01 +0800 Message-ID: <1437569590-5228-3-git-send-email-aisheng.dong@freescale.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1437569590-5228-1-git-send-email-aisheng.dong@freescale.com> References: <1437569590-5228-1-git-send-email-aisheng.dong@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD012; 1:Qf9WNdQDKM3R+eO82L9unAPcSJ58HnIcKVQI2vBlgKUBss/KVflfMEFF3QZ7mgjrJAIkx9PcsD5mZ8Hkqdi7l0W3Ech0smtgDCDeRcjnGWMizqxjcPVUzE3w/BwNkvTM0Gk1T1np9Vd2461za17YuqTsq7+qvml9Lwy23qtbvEzoQQ/XfKvAAElnod6ZJGo2rh/eGpi85eiCvo8147Cp9UYBv0ePuqWYbBrAzFQbsRhoTQeT9kzUQtcC+gtJL7xDp0drpPZ/yedtppj1nXnnsYx7AvYOy7Ambq3rN8YQy9uoSaKD4pjX13tey0bihrBsxUe/7umQecWAb4vw0Izeny5PdgRRyaHHkRJjDhQOxXfxpHrZwqFBAFb/faEs+YRcjgSeJ1QidfE1eRyzVC9W13GVp/X0/60ea3j7Ip1UAkzXHPXnUHjOIRJ5LFPyJUnt X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(979002)(6009001)(2980300002)(339900001)(189002)(199003)(62966003)(77096005)(36756003)(77156002)(76176999)(19580395003)(575784001)(106466001)(50986999)(2351001)(86362001)(229853001)(33646002)(92566002)(104016003)(50226001)(50466002)(189998001)(5003940100001)(5001960100002)(110136002)(46102003)(47776003)(6806004)(85426001)(2950100001)(87936001)(105606002)(19580405001)(48376002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR03MB1409; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1409; 2:sFzQzOUNG4YMMzpjlPAKZMMBm4ZlmHnPb2l3gZGxZWxrKf+2VFaiWacFBIR4qBUT; 3:0CkbwWOh3uMm+a2TEp5sB9Wb/ayemKLtCdnehb6NPrlr8MRTbLHgKfalL3RSfZrxaSGivIeIzeDtp/d9zra+JwCOiFMp368rp9GM9TKrsZFbuIURS+QLeQRpgRZN2CGY9SkibBxI/rEdRfI/ZHzJvJt8v0CqZbr2lNgnbmJ4RJlRYJ+lIVBZa/I6WavHV2gBsh9VbqegVOgr+KacEGvHjgd+1rvObRKzpaV2rlkUXPw=; 25:z/YOYYR951sFuoPV5SQYH6qatz5iaapk9DBnzu90Z2laaY3CKdk4SnCdVfcz6pAEuG2hC5rvNiyeoUPF7+CVPzzbA8wKi7PveivA2dw7WXq2Ekx1R7Uq3xu+yA+lf+f1vvgLxzENjoKtXoPzHZei4+/KzpubEl3/SpA6JODMlhFzdgk/6D+aWA/hTbCQKuQw4FJvHl8G140rxoVVMluAHKH/Z7iEF5Lgh8Tg2RV9icGG6eCLxxVEQ023DOG6G6qOApyp9zhiJVSRpfu7iO3Y/w==; 20:aJK9DNTw52yPPosZERqnWkU1b8kYrEm552XHx0dXkGGQwe1B/j7gD9Ht59h5HPJU8fYbGljN0ENmd1ZElIx15ORuKL55Vjb88j9Nt9H5GNN4SZrZBmhSLGkKBl0vJHee/SJPqlng516fm2fmNXIwDzY11x8FcZmZdEwIcCpOX+sKc6wsHuGIE+0lDqGJvx8SOLA1dEj2pxp5JC/v6kqMpNBLuRpPJj9CsRqtCYt5gEHv7eO+eN9jSsHIiI9bAflA3ukfcxsNbKqLcpWTK4rL8JzboEvJp//m017bjJXZZvEe8qsWKbpYwngWXrrjGLli/4OpMSrsSLIt8/QMD6D/8gT4fvJ I0yiz9rjtZPBrQ0I= X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB1409; UriScan:; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB358; BLUPR03MB1409: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BLUPR03MB1409; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB1409; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1409; 4:T9jEYj0EIbgRkBfQUFqncStn8/Ea9CCXYuAY0cVxr1I3vxG0vtSJsayErEFFw+Ol0qzoQ5QK7HWkhrUo7QHzASCcPkEqGOhSb8xvbUEiAQ2ZS5ZQ2LIlWHj9JHfV0K9getTD4xhlO1OlMrOUBpwF4w3g3VHgLdM105ArKRX3viQWkdmaNRSI5Do2kcoKEHb0vydYVYa83t28nm6TWW1JI6Y6p8mNjiABf5GQC3pZzpqdA2hKM+9or2o+f3O2H/yXeg9CYxoFoNc4SmSTrvH7IDoOwtwa8uypi4cm2uOf6Rc= X-Forefront-PRVS: 0645BEB7AA X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR03MB1409; 23:lEhZERddXye8MUlJxhJSyN7bV0zCJOl5DS5j0/n7x?= =?us-ascii?Q?t+1Lx3c2Pe8LAGDhBUINPmlfvkHTbYl0f/N4Y9xZb13TdH7Fu26teJ6EWZgH?= =?us-ascii?Q?Mz2WKuwi+dPSu04k/XquF/r4wByHe8jpWAPXfyFbwxofNEKx1el7KYZ/t3x5?= =?us-ascii?Q?WVfSAPK4gb6Qofa4mOZ0WhPB6Qs3j5bXQsXTXoA6t9iRmTopoRy47e8DnhUf?= =?us-ascii?Q?Ybn1iLhCEgqKW8Yanr5Q/BAn94h6tNHZZJLybIQqxzodxFhveQFYg5uFXYtD?= =?us-ascii?Q?teCpod9V9wkl2XAWca2S+dlSO2fZB7HgL2EnbvZsoBvnXVlUbM8UJEZzErca?= =?us-ascii?Q?blrxOZx5cSdsw/7njhk34z1o5tzw/kNbvaODWXm/pcX6Mldl416YOxXXRcqq?= =?us-ascii?Q?sAVrt5b21NQQ6eYHfqTxFuTksxH3jz30xBho+NaXRQjTK6iTAkPhT0PXdS1Z?= =?us-ascii?Q?73jn73TFnFRFOgpb6g1LJCnXuM24zGVoDhzTU6TzWZpFs+S5omx/5FkjXzN2?= =?us-ascii?Q?RkvOUBKCU834zgJ1pKrFDkXxECUXsKYPxBc1TcwavWnTcUH5ZLM1sXiBjYWj?= =?us-ascii?Q?Lo3gziAYO+mnOzOO9LgkB8OFCGiVipwYKJSysMQ2qs1VYLnh6Fe5U3g/AyNu?= =?us-ascii?Q?+PJCpbU3bG0Ve0zQSbuYSv0Dxjl+hZB+1jIpJ/W3RocUnQWt9ZnIWQcAd4Nb?= =?us-ascii?Q?55OrwtUiDz5J4c37xGFdxGd1HsF3TR1OmcsUEy7rJc4KbbOGq0+9ro8IRxl9?= =?us-ascii?Q?VdGT7JmEeCVK3hQ1KNW/DqAPn9soel7F1Sy7S1kpiTqVz2Mlwqv9x+cat91A?= =?us-ascii?Q?1+wVfYLn1apZj7wB4s11iEGjEFUR3cSEvfIR0gZqC35edWk9yOTVJvtFkMeb?= =?us-ascii?Q?8rtlBsTwezPScULAEnmNDWtkZdbE2/FjV/kmuB5m5hNzqCnTsEM09EMurZaF?= =?us-ascii?Q?kqomdvyF26ovWWhiVQjP4M5z66vxY10qaPpVgVHVBovEeN5oyYp/w1GmaLDr?= =?us-ascii?Q?ebGblo0s15uI2gR0F2YHzSgojNNsSrsTuGXp4xuLUVI7A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1409; 5:+XuFglqFnc2B6Gs4Pab8ClTbWV1kHCOz1qKl5XooEiV6OO45LHrzyWdf+JQucfHOoHDhNwcFbQkCe5e9qmKRCi6o9qXS3Lf3O5tz/c1pQm11IZF51aInaF0lFTvH4xyLRdZKtppjlt7gKJ/SHyUfHA==; 24:QRgZCSLQHdo68vKD5bpS4Znbcn4i9ktbJ5PhX/YvnvXhj61TyOrVzMnRdI/HS/B+yi/kPcFb1EpOwDEaQCyzrpg+P6aS6sitq/Ri17rA6KI=; 20:W3eG9p6Jsg9fsYK2iDybX1dscYS0YCr/8lVChO9lQY9vxyFT9dQnfFuPgk0WVVLIXOycujkScZoOv0qxI4rfiw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2015 14:03:05.4822 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1409 X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB358; 2:gREZQvz+9fZ4LcGesGvQjyGjriKr0ZWVovz6tmUGZwjMfH9Gxu1m+jPNF4Djkqy/VNXGkS5evW+H4nd07g5zOj7ZDAJMUheQxCL5enWWKfvzcN4ah+yOy2lYJIYFYjvsYJIexM8m57jUM8m2aAaBhCuUcuDrb6T39bOsk9cQJfc=; 3:dmfAStvX4eem3KnQbVOkAG4a1RxUgbU/X9DBj0qOu1oMZhqGWRvASbgkpgNoaBIH/wMushpuIeK9Hcos+5jy9YJtYI2w1CB2z3Q+Vyk6LSpf2yA7OJuUhsu+CbiuTZ0Jx1CUnxX841Ub9lubztss6dTP9mgRo8dmWEkGXhRM93VePuhhGHzoSFM2x+Pp8UNZWSL/7dhZC4klIlE7wV2rw+I6UyX8nfmhgM8mwN+lAnA=; 25:TVJPZZNsLfjYEUZET0tdnp4A8VY4+5LD2giERfTQUUtG6daHVMXxSb0hND2LsITnHi7J8LI5WMvIsYCDQqFYKODD4Il8EQQ00abz5rS/kUYPkKB7V2N+NBYy/IPmMXt1gXq2x8rBXudKjz7K0/qyQ7G2IEY0XGO1tIAUXFQxeJfa7YXXTJp/ISVxToOsNEgUBcovnQdeeNbMEqmOX6ARvws/sTu1Tt6unPYbZjdrcN2JxwTmDowqBX77pPsObwD5dpDzXORE+aVLSD2f9PKQZQ==; 23:dRIvv6Y4m7a7b93xKHG7GDhnk1hiP0L6Inf7EDeprq41uRxxmtLXrfOrofKyr0BPHce9Wyn9911dL9/AygAq2szUHQMkITd1jeDIs/Qlmdm7M3VV/8x5ieJAMK1HCS2NGiwYnIEIW2kpD7cU+Vr+poYrbCdhOHwZt5sOwrce8G8ACN6ZN7a6WN43caxZTvrBc41BE5xGGLquVFux1WFnEqcST0b6hDegKqoIfEM5j3MMMKMa vi2BLVHooSpPP/0t X-OriginatorOrg: freescale.com Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP cd-gpios polarity should be changed to GPIO_ACTIVE_LOW and wp-gpios should be changed to GPIO_ACTIVE_HIGH. Otherwise, the SD may not work properly due to wrong polarity inversion specified in DT after switch to common parsing function mmc_of_parse(). Signed-off-by: Dong Aisheng --- arch/arm/boot/dts/imx53-ard.dts | 4 ++-- arch/arm/boot/dts/imx53-m53evk.dts | 4 ++-- arch/arm/boot/dts/imx53-qsb-common.dtsi | 4 ++-- arch/arm/boot/dts/imx53-smd.dts | 4 ++-- arch/arm/boot/dts/imx53-tqma53.dtsi | 4 ++-- arch/arm/boot/dts/imx53-tx53.dtsi | 4 ++-- arch/arm/boot/dts/imx53-voipac-bsb.dts | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/arm/boot/dts/imx53-ard.dts b/arch/arm/boot/dts/imx53-ard.dts index e9337ad..3bc1883 100644 --- a/arch/arm/boot/dts/imx53-ard.dts +++ b/arch/arm/boot/dts/imx53-ard.dts @@ -103,8 +103,8 @@ &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; - cd-gpios = <&gpio1 1 0>; - wp-gpios = <&gpio1 9 0>; + cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx53-m53evk.dts b/arch/arm/boot/dts/imx53-m53evk.dts index d0e0f57..53f4088 100644 --- a/arch/arm/boot/dts/imx53-m53evk.dts +++ b/arch/arm/boot/dts/imx53-m53evk.dts @@ -124,8 +124,8 @@ &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; - cd-gpios = <&gpio1 1 0>; - wp-gpios = <&gpio1 9 0>; + cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx53-qsb-common.dtsi b/arch/arm/boot/dts/imx53-qsb-common.dtsi index ab4ba39..b0d5542 100644 --- a/arch/arm/boot/dts/imx53-qsb-common.dtsi +++ b/arch/arm/boot/dts/imx53-qsb-common.dtsi @@ -147,8 +147,8 @@ &esdhc3 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc3>; - cd-gpios = <&gpio3 11 0>; - wp-gpios = <&gpio3 12 0>; + cd-gpios = <&gpio3 11 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio3 12 GPIO_ACTIVE_HIGH>; bus-width = <8>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx53-smd.dts b/arch/arm/boot/dts/imx53-smd.dts index 1d32557..fc89ce1 100644 --- a/arch/arm/boot/dts/imx53-smd.dts +++ b/arch/arm/boot/dts/imx53-smd.dts @@ -41,8 +41,8 @@ &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; - cd-gpios = <&gpio3 13 0>; - wp-gpios = <&gpio4 11 0>; + cd-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio4 11 GPIO_ACTIVE_HIGH>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx53-tqma53.dtsi b/arch/arm/boot/dts/imx53-tqma53.dtsi index 4f1f0e2..e03373a 100644 --- a/arch/arm/boot/dts/imx53-tqma53.dtsi +++ b/arch/arm/boot/dts/imx53-tqma53.dtsi @@ -41,8 +41,8 @@ pinctrl-0 = <&pinctrl_esdhc2>, <&pinctrl_esdhc2_cdwp>; vmmc-supply = <®_3p3v>; - wp-gpios = <&gpio1 2 0>; - cd-gpios = <&gpio1 4 0>; + wp-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; + cd-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi index 704bd72..d3e50b2 100644 --- a/arch/arm/boot/dts/imx53-tx53.dtsi +++ b/arch/arm/boot/dts/imx53-tx53.dtsi @@ -183,7 +183,7 @@ }; &esdhc1 { - cd-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; + cd-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>; fsl,wp-controller; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; @@ -191,7 +191,7 @@ }; &esdhc2 { - cd-gpios = <&gpio3 25 GPIO_ACTIVE_HIGH>; + cd-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>; fsl,wp-controller; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc2>; diff --git a/arch/arm/boot/dts/imx53-voipac-bsb.dts b/arch/arm/boot/dts/imx53-voipac-bsb.dts index c17d3ad..fc51b87 100644 --- a/arch/arm/boot/dts/imx53-voipac-bsb.dts +++ b/arch/arm/boot/dts/imx53-voipac-bsb.dts @@ -119,8 +119,8 @@ &esdhc2 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc2>; - cd-gpios = <&gpio3 25 0>; - wp-gpios = <&gpio2 19 0>; + cd-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio2 19 GPIO_ACTIVE_HIGH>; vmmc-supply = <®_3p3v>; status = "okay"; };