From patchwork Wed Jul 22 12:53:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 6844151 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0B5539F1D4 for ; Wed, 22 Jul 2015 14:03:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1002620649 for ; Wed, 22 Jul 2015 14:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 496C32058C for ; Wed, 22 Jul 2015 14:03:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756734AbbGVOD1 (ORCPT ); Wed, 22 Jul 2015 10:03:27 -0400 Received: from mail-bn1bn0103.outbound.protection.outlook.com ([157.56.110.103]:43330 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756699AbbGVODY (ORCPT ); Wed, 22 Jul 2015 10:03:24 -0400 Received: from BN3PR0301CA0079.namprd03.prod.outlook.com (10.160.152.175) by BY1PR03MB1420.namprd03.prod.outlook.com (10.162.127.150) with Microsoft SMTP Server (TLS) id 15.1.213.14; Wed, 22 Jul 2015 14:03:16 +0000 Received: from BL2FFO11FD045.protection.gbl (2a01:111:f400:7c09::172) by BN3PR0301CA0079.outlook.office365.com (2a01:111:e400:401e::47) with Microsoft SMTP Server (TLS) id 15.1.225.19 via Frontend Transport; Wed, 22 Jul 2015 14:03:17 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; gmail.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD045.mail.protection.outlook.com (10.173.161.207) with Microsoft SMTP Server (TLS) id 15.1.213.8 via Frontend Transport; Wed, 22 Jul 2015 14:03:16 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id t6ME2iY2019637; Wed, 22 Jul 2015 07:03:10 -0700 From: Dong Aisheng To: CC: , , , , , , , , , , , , , , , , , , , , Subject: [PATCH V2 04/11] dts: imx25: fix sd card gpio polarity specified in device tree Date: Wed, 22 Jul 2015 20:53:03 +0800 Message-ID: <1437569590-5228-5-git-send-email-aisheng.dong@freescale.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1437569590-5228-1-git-send-email-aisheng.dong@freescale.com> References: <1437569590-5228-1-git-send-email-aisheng.dong@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD045; 1:mg3EWkzbojP6FUJl28hvl5XO/0pT2XnPxhSjBnNmPNmpoPhRigenjcV1rIG0iMkxWmVMOkggp0Weju/TwWGeWTRRFTa/SBn1a+I+5YisLLGOP/suhOxo2sqNaec5enemdmcnNbo9IyumG6ZbU4S1dOxvcKRl5KF+0GTGyXrfYzu2b8b4/iWefj77ifXL4WTlTDiRInWOVL4QwnZogKbJzsO1QYoK5yHPabFvr4pVRMsH4hqK+xj1HHx8A19AVV9SlOsAuIF+Ts34qiL6laer2NeWyjRnmQkaiN7vxDINkIPhh28jlbfZ2zGjpNwDGrgZsiTQi8/IXV/wEVeAhN8wSvOVhDpHZixGTqncrDMTjlgqr5drteVBIIwROtKyuVhkvDO6ChM/j8tdT/oa5ZAW7vQaVudU8NufC2HK34OlB6kYveZ5fwRPKVzk7ojQbJWS X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(339900001)(189002)(199003)(104016003)(33646002)(105606002)(77096005)(36756003)(62966003)(2950100001)(77156002)(5003940100001)(47776003)(92566002)(2351001)(106466001)(229853001)(50466002)(48376002)(87936001)(19580395003)(46102003)(85426001)(189998001)(50226001)(86362001)(19580405001)(50986999)(6806004)(76176999)(5001960100002)(110136002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR03MB1420; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:sfv; MX:1; A:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1420; 2:Q69UU5nowOv8x/U9cMN9M6Q3RQSzwrHmlOJ0YntAfpq5f8TMRshRn3Jqe0auJeva; 3:3whJNP3v+u/57SAilG9ecXg10FFlspMetTQHTwiaEP1wxztoKQlv1atjXT0+sOH/FNKItRYsBuu7bxAOBIrMvBS7DqFlsI/f7dzp0LvK+2WjYlzteZJPsKATJDCJ7NAxwtrZH7mgSzKUpEGdBllI7PMvi/vwskyr351YByqHSKAzCeFBowx63vKb3R4WNvzB4MmSKmYbn2JklVnwh16zKBoq6OHWkiWWHMLfu7lPSVI=; 25:CacLeKPIqHAHLPEnEDdmgdx9XkkiYb3SsN47IFOpgDYpU/pObn+QI+IgKr8wX5eLyLxfgYrQnlrvukkr1i7kQiwLM05VT+zzXHEh3SQ27LZnHNgLqg2j+lAnHwH0JmJPktSJB1niqe3WwNTeseZy6QRNwIFj6qujYEd4munoMRo11YWGl6WJlz/nUFPVXzZ46zVjc1X21ZIwG2v9pOdjXcRLKWB+iOIc5cTE0a1uFtAzlIDXdAGe2ps+GgeuBt7MB0o4IXiCGwaWok3GZIv6HQ==; 20:V1jXT46E5hyjHjCPe+Fpg+gJ1t090vfBRpltQWV3OztE0FaTBHQEB0zo6JuF/8f9AICb+wCheLJ9RDvj2y82YUgyVAEWjlN/tQwGhKw1kUWCr0DhS1aeUtVDQuJrpGk6ljN3MG9gADMnsPoAMs7tEs+0aXTEtMLDb69yLcsqx4TTT3AmaQ1mPdmFG5saOgh+lF3ZNHj/sB7x910D8iNdq7tREpQE8vOqeGcepii1tt6ceNTZRCj6gNagswBnTGmTzWgqnkQXrE7pYlL+B0mb7gaN/feisz0Vf0NGMVDWPNNvFcuV7Uv6qh2SqcnYdwFxMepPyd+TmEu7Nc0Ohq2UhY7ISmt UwHCxyETwWVOgMeE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1420; BY1PR03MB1420: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BY1PR03MB1420; BCL:0; PCL:0; RULEID:; SRVR:BY1PR03MB1420; X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1420; 4:MtBjgM/g0wksXwHHd4uwnZN0qDakrCrbw0TETAVKVDDU+28FhA8vR3IMiH807O7OghsONAfbPyeG4PYssbwcFNPsLouBdMrYxLrZLackPcx0aqPZf246k4E8IveAjIrJWvfpj15D6ITlT62rM2aV9BjwWoDWzge1aI1PFKLAIzkK1urz0hMQAOmPUczcSxcjjVpw850BbLn82bwq/yKpDpyHenR7fkyeGuZi6GomrCZAm43GjTO8uok6DIfKOB03D165OmxwXeuDLDryLcvJCincsa/KDrk2PRdhg0WmpRk= X-Forefront-PRVS: 0645BEB7AA X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1420; 23:V7p/kSKXb69zApABVoM7yMAswVnD+/KUlLSdMDa0hb4+NZcd5BPwmBqgivBo/W2y3a39keB5GIr7xTWX1895qGsRsIWBzZqnUoxEssbyxADs9TXJttiUxsx9jqMjbIVihcaZSvP3/jeaOYD3ZFWD36RSmY7icUzrRl9O6/Z38r1ZPRJYpw3oFL+ZNjHth0FAw9um7iGI24AGC/zimZeL+pq6pwHTXVrw2DNXbuX6re7H43srpNAPp9Bnc50Z+iaSoU/qmYxV24uOu/qzM4cQrJnNqD2B1GrtVN+0xUhqhiiNMJfruYtYoU1OgGu7d1de9D/UNLzVUkaB+VHv0wqSGdxXQReHv89lBA758h5H3K7wmOYEP9VY4yM5CuqaCEe9xD0holKYr0ECxANf3uTYrU+zpdKZPGjDh3ZA8rLy6Wd9ciLWBQX9bon9DxmNZbzSHuiX6UGa2YqGeTsMlD6pKIxwPXcW0uKqAiwMBOQ4IZNpG25jHpsokvBh1S3IEz3v5/NmDf0LCpOGqUbVRQKnjxEgQqb/1zQ0XxsdZYYIbjEzuVVc3kmjlmqhxBH4W4xG8Nd2KvHKIMQAtVTRTufSwjfjX7P6JO0NACGYDYCQvvR1bLm1V6f3NVrty/cDc5KECyNL6+8M7gm8dk9as/FmU4dfNxRUcniV0oxBpT/BLP1KsQdrx8eoLNcp9izgWSSQ6KQtsfQ4SGX/n7GPAGWiKjnEiy6LISAvLQaD01G7DyI7rpsljAwQn09TNa1R55t97uKNMmwrHxFxF1j/8SKv31bkw2v3aC0HN7OBD/oNK9C+h15VdYScIgAdqUNU3E5nSJA3lFkjifYzBSnxu3b2YD1Nwtb4PMtoPJP9VJVVWvOv+D1tt5Yxw/CMPZyfF/HBf6QchBz/6kjnr7tt1HHeHg== X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1420; 5:i3RgldEUkkbVzUxGeLpOy2RfJI4YsRtIa8h4dUAK07b0ayOHH0YDBmHU2Loj1LjFKqV6gikJZ/AgdDnq1lNEiloZaJVHpspQzmlLneGOBImSJYY/VgYa2GKWbcEKytzj5qXdsUK3P5DY2vcixe7ylw==; 24:AFO+BwxARwmtIWMpqxs+Ww7yTdug1FVqntOqKuFwSQi0dV5ADNr5ChZgi+vazjQciWhtNp2BkNuYtGjyXnK0hfeiBuEk7gd3uEabd90tQBE=; 20:0vt3gDnRAkEu+qIlNirE2fu50XtR4/yInWYogIphS1ZFVrB8ktloH/1U5TDB57u+TJGPtaIaJm1AdwY1kdAiKg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2015 14:03:16.4513 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1420 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP cd-gpios polarity should be changed to GPIO_ACTIVE_LOW and wp-gpios should be changed to GPIO_ACTIVE_HIGH. Otherwise, the SD may not work properly due to wrong polarity inversion specified in DT after switch to common parsing function mmc_of_parse(). Signed-off-by: Dong Aisheng --- arch/arm/boot/dts/imx25-pdk.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts index dd45e69..faf252f 100644 --- a/arch/arm/boot/dts/imx25-pdk.dts +++ b/arch/arm/boot/dts/imx25-pdk.dts @@ -114,8 +114,8 @@ &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; - cd-gpios = <&gpio2 1 0>; - wp-gpios = <&gpio2 0 0>; + cd-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio2 0 GPIO_ACTIVE_HIGH>; status = "okay"; };