diff mbox

[1/3] mmc: dw_mmc: fix the wrong condition checking

Message ID 1438845806-4486-1-git-send-email-jh80.chung@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jaehoon Chung Aug. 6, 2015, 7:23 a.m. UTC 
When num-slots is lower than 1, it's right that should be returned -ENODEV.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/host/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alim Akhtar Aug. 10, 2015, 5:06 p.m. UTC | #1 
Hi Jaehoon

On Thu, Aug 6, 2015 at 12:53 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>
> When num-slots is lower than 1, it's right that should be returned -ENODEV.
>
make sense.

> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Tested-by: Alim Akhtar <alim.akhtar@samsung.com>

> ---
>  drivers/mmc/host/dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 3c0e199..de88e64 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2760,7 +2760,7 @@ int dw_mci_probe(struct dw_mci *host)
>                 }
>         }
>
> -       if (host->pdata->num_slots > 1) {
> +       if (host->pdata->num_slots < 1) {
>                 dev_err(host->dev,
>                         "Platform data must supply num_slots.\n");
>                 return -ENODEV;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 3c0e199..de88e64 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -2760,7 +2760,7 @@  int dw_mci_probe(struct dw_mci *host)
 		}
 	}
 
-	if (host->pdata->num_slots > 1) {
+	if (host->pdata->num_slots < 1) {
 		dev_err(host->dev,
 			"Platform data must supply num_slots.\n");
 		return -ENODEV;