diff mbox

[1/3] mmc: sd: Remove superfluous error code assignment

Message ID 1441816398-4330-1-git-send-email-yszhou4tech@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yousong Zhou Sept. 9, 2015, 4:33 p.m. UTC
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
---
 drivers/mmc/core/sd.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Hans de Goede Sept. 9, 2015, 7:29 p.m. UTC | #1
Hi All,

I requested yousong to send this set to further discuss it,
and hopefully get some fix for this in the kernel.

Yousong, I actually intended you to do a patch to the sunxi-mmc
code, rather then too the core. Ah well. Since we've this set
now lets see if people like it, it may help other cases
too I guess.

Regards,

Hans


On 09-09-15 18:33, Yousong Zhou wrote:
> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
> ---
>   drivers/mmc/core/sd.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 4e7366a..e28ebf3 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -357,8 +357,6 @@ int mmc_sd_switch_hs(struct mmc_card *card)
>   	if (card->sw_caps.hs_max_dtr == 0)
>   		return 0;
>
> -	err = -EIO;
> -
>   	status = kmalloc(64, GFP_KERNEL);
>   	if (!status) {
>   		pr_err("%s: could not allocate a buffer for "
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ulf Hansson Sept. 15, 2015, 11:34 a.m. UTC | #2
On 9 September 2015 at 18:33, Yousong Zhou <yszhou4tech@gmail.com> wrote:
> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>

Thanks, applied for next!

I will comment on patch2 and patch3 separately.

Kind regards
Uffe

> ---
>  drivers/mmc/core/sd.c |    2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 4e7366a..e28ebf3 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -357,8 +357,6 @@ int mmc_sd_switch_hs(struct mmc_card *card)
>         if (card->sw_caps.hs_max_dtr == 0)
>                 return 0;
>
> -       err = -EIO;
> -
>         status = kmalloc(64, GFP_KERNEL);
>         if (!status) {
>                 pr_err("%s: could not allocate a buffer for "
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index 4e7366a..e28ebf3 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -357,8 +357,6 @@  int mmc_sd_switch_hs(struct mmc_card *card)
 	if (card->sw_caps.hs_max_dtr == 0)
 		return 0;
 
-	err = -EIO;
-
 	status = kmalloc(64, GFP_KERNEL);
 	if (!status) {
 		pr_err("%s: could not allocate a buffer for "