| Message ID | 1453042744-16196-4-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
looks good On 16-01-17 06:59 AM, Stefan Wahren wrote: > This patch defines the known quirks for BCM283x in the dtsi file: > * SDHCI_QUIRK_BROKEN_CARD_DETECTION > * SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 > > So we don't need to define them in the driver. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Acked-by: Scott Branden <sbranden@broadcom.com> > --- > arch/arm/boot/dts/bcm283x.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi > index 971e741..75451cd 100644 > --- a/arch/arm/boot/dts/bcm283x.dtsi > +++ b/arch/arm/boot/dts/bcm283x.dtsi > @@ -164,6 +164,8 @@ > reg = <0x7e300000 0x100>; > interrupts = <2 30>; > clocks = <&clocks BCM2835_CLOCK_EMMC>; > + broken-cd; > + sdhci,auto-cmd12; > status = "disabled"; > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/17/2016 07:59 AM, Stefan Wahren wrote: > This patch defines the known quirks for BCM283x in the dtsi file: > * SDHCI_QUIRK_BROKEN_CARD_DETECTION > * SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 > > So we don't need to define them in the driver. Given that the quirks are currently defined in the driver, I believe they will forever have to be defined in the driver. If the (or a different) driver suddenly starts requiring the DT to specify the quirks, then old DTs won't work with a new kernel, which is against DT ABI. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi index 971e741..75451cd 100644 --- a/arch/arm/boot/dts/bcm283x.dtsi +++ b/arch/arm/boot/dts/bcm283x.dtsi @@ -164,6 +164,8 @@ reg = <0x7e300000 0x100>; interrupts = <2 30>; clocks = <&clocks BCM2835_CLOCK_EMMC>; + broken-cd; + sdhci,auto-cmd12; status = "disabled"; };
This patch defines the known quirks for BCM283x in the dtsi file: * SDHCI_QUIRK_BROKEN_CARD_DETECTION * SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 So we don't need to define them in the driver. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm/boot/dts/bcm283x.dtsi | 2 ++ 1 file changed, 2 insertions(+)