diff mbox

[1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR

Message ID 1454469964-21365-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shawn Lin Feb. 3, 2016, 3:26 a.m. UTC
EVENT_XFER_ERROR isn't been used now, so we can
remove it.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 include/linux/mmc/dw_mmc.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Jaehoon Chung Feb. 4, 2016, 6:12 a.m. UTC | #1
Hi, Shawn.

On 02/03/2016 12:26 PM, Shawn Lin wrote:
> EVENT_XFER_ERROR isn't been used now, so we can
> remove it.

If you are ok, after changing the commit message, I will apply this.
Thanks!

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> 
>  include/linux/mmc/dw_mmc.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
> index 89df7ab..b29e06e 100644
> --- a/include/linux/mmc/dw_mmc.h
> +++ b/include/linux/mmc/dw_mmc.h
> @@ -36,7 +36,6 @@ enum {
>  	EVENT_XFER_COMPLETE,
>  	EVENT_DATA_COMPLETE,
>  	EVENT_DATA_ERROR,
> -	EVENT_XFER_ERROR
>  };
>  
>  struct mmc_data;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Shawn Lin Feb. 12, 2016, 11:31 a.m. UTC | #2
On 2016/2/4 14:12, Jaehoon Chung wrote:
> Hi, Shawn.
>
> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>> EVENT_XFER_ERROR isn't been used now, so we can
>> remove it.
>
> If you are ok, after changing the commit message, I will apply this.
> Thanks!

Should I respin v2 to amend the commit msg? :-)

>
> Best Regards,
> Jaehoon Chung
>
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>>   include/linux/mmc/dw_mmc.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>> index 89df7ab..b29e06e 100644
>> --- a/include/linux/mmc/dw_mmc.h
>> +++ b/include/linux/mmc/dw_mmc.h
>> @@ -36,7 +36,6 @@ enum {
>>   	EVENT_XFER_COMPLETE,
>>   	EVENT_DATA_COMPLETE,
>>   	EVENT_DATA_ERROR,
>> -	EVENT_XFER_ERROR
>>   };
>>
>>   struct mmc_data;
>>
>
>
>
>
Jaehoon Chung Feb. 14, 2016, 10:27 p.m. UTC | #3
On 02/12/2016 08:31 PM, Shawn Lin wrote:
> On 2016/2/4 14:12, Jaehoon Chung wrote:
>> Hi, Shawn.
>>
>> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>>> EVENT_XFER_ERROR isn't been used now, so we can
>>> remove it.
>>
>> If you are ok, after changing the commit message, I will apply this.
>> Thanks!
> 
> Should I respin v2 to amend the commit msg? :-)

Not important..but i want to use this. :)
"we can remove it" -> "It can be removed." 

Best Regards,
Jaehoon Chung

> 
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>>
>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>> ---
>>>
>>>   include/linux/mmc/dw_mmc.h | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>>> index 89df7ab..b29e06e 100644
>>> --- a/include/linux/mmc/dw_mmc.h
>>> +++ b/include/linux/mmc/dw_mmc.h
>>> @@ -36,7 +36,6 @@ enum {
>>>       EVENT_XFER_COMPLETE,
>>>       EVENT_DATA_COMPLETE,
>>>       EVENT_DATA_ERROR,
>>> -    EVENT_XFER_ERROR
>>>   };
>>>
>>>   struct mmc_data;
>>>
>>
>>
>>
>>
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jaehoon Chung Feb. 14, 2016, 10:29 p.m. UTC | #4
On 02/15/2016 07:27 AM, Jaehoon Chung wrote:
> On 02/12/2016 08:31 PM, Shawn Lin wrote:
>> On 2016/2/4 14:12, Jaehoon Chung wrote:
>>> Hi, Shawn.
>>>
>>> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>>>> EVENT_XFER_ERROR isn't been used now, so we can
>>>> remove it.
>>>
>>> If you are ok, after changing the commit message, I will apply this.
>>> Thanks!
>>
>> Should I respin v2 to amend the commit msg? :-)
> 
> Not important..but i want to use this. :)
> "we can remove it" -> "It can be removed." 

One more..This patch is [1/2]..I didn't see the second patch [2/2].

> 
> Best Regards,
> Jaehoon Chung
> 
>>
>>>
>>> Best Regards,
>>> Jaehoon Chung
>>>
>>>>
>>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>>> ---
>>>>
>>>>   include/linux/mmc/dw_mmc.h | 1 -
>>>>   1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>>>> index 89df7ab..b29e06e 100644
>>>> --- a/include/linux/mmc/dw_mmc.h
>>>> +++ b/include/linux/mmc/dw_mmc.h
>>>> @@ -36,7 +36,6 @@ enum {
>>>>       EVENT_XFER_COMPLETE,
>>>>       EVENT_DATA_COMPLETE,
>>>>       EVENT_DATA_ERROR,
>>>> -    EVENT_XFER_ERROR
>>>>   };
>>>>
>>>>   struct mmc_data;
>>>>
>>>
>>>
>>>
>>>
>>
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Shawn Lin Feb. 15, 2016, 12:20 a.m. UTC | #5
Hi Jaehoon,

On 2016/2/15 6:29, Jaehoon Chung wrote:
> On 02/15/2016 07:27 AM, Jaehoon Chung wrote:
>> On 02/12/2016 08:31 PM, Shawn Lin wrote:
>>> On 2016/2/4 14:12, Jaehoon Chung wrote:
>>>> Hi, Shawn.
>>>>
>>>> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>>>>> EVENT_XFER_ERROR isn't been used now, so we can
>>>>> remove it.
>>>>
>>>> If you are ok, after changing the commit message, I will apply this.
>>>> Thanks!
>>>
>>> Should I respin v2 to amend the commit msg? :-)
>>
>> Not important..but i want to use this. :)
>> "we can remove it" -> "It can be removed."
>

yes, please.

> One more..This patch is [1/2]..I didn't see the second patch [2/2].

Only one patch here, no [2/2]. sorry for the noise

>
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>>
>>>>
>>>> Best Regards,
>>>> Jaehoon Chung
>>>>
>>>>>
>>>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>>>> ---
>>>>>
>>>>>    include/linux/mmc/dw_mmc.h | 1 -
>>>>>    1 file changed, 1 deletion(-)
>>>>>
>>>>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>>>>> index 89df7ab..b29e06e 100644
>>>>> --- a/include/linux/mmc/dw_mmc.h
>>>>> +++ b/include/linux/mmc/dw_mmc.h
>>>>> @@ -36,7 +36,6 @@ enum {
>>>>>        EVENT_XFER_COMPLETE,
>>>>>        EVENT_DATA_COMPLETE,
>>>>>        EVENT_DATA_ERROR,
>>>>> -    EVENT_XFER_ERROR
>>>>>    };
>>>>>
>>>>>    struct mmc_data;
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>
>
>
>
diff mbox

Patch

diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
index 89df7ab..b29e06e 100644
--- a/include/linux/mmc/dw_mmc.h
+++ b/include/linux/mmc/dw_mmc.h
@@ -36,7 +36,6 @@  enum {
 	EVENT_XFER_COMPLETE,
 	EVENT_DATA_COMPLETE,
 	EVENT_DATA_ERROR,
-	EVENT_XFER_ERROR
 };
 
 struct mmc_data;