From patchwork Wed Feb 10 09:58:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ludovic Desroches X-Patchwork-Id: 8269311 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7799DBEEE5 for ; Wed, 10 Feb 2016 09:58:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A9CC620270 for ; Wed, 10 Feb 2016 09:58:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEBCC20260 for ; Wed, 10 Feb 2016 09:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757610AbcBJJ6U (ORCPT ); Wed, 10 Feb 2016 04:58:20 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:32516 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbcBJJ6S (ORCPT ); Wed, 10 Feb 2016 04:58:18 -0500 Received: from ibiza.corp.atmel.com (10.161.101.13) by eusmtp01.atmel.com (10.161.101.30) with Microsoft SMTP Server id 14.3.235.1; Wed, 10 Feb 2016 10:58:07 +0100 From: Ludovic Desroches To: CC: , , , Ludovic Desroches Subject: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe Date: Wed, 10 Feb 2016 10:58:03 +0100 Message-ID: <1455098283-14500-1-git-send-email-ludovic.desroches@atmel.com> X-Mailer: git-send-email 2.7.0 MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP By putting the device in suspend at the end of the probe, it is impossible to wake up on non software event such as card insertion/removal. Signed-off-by: Ludovic Desroches --- Hi, Since I had no feedback on this topic: http://permalink.gmane.org/gmane.linux.kernel.mmc/35160 I would like to no more put the device in suspend at the end of the probe. If my device is suspended at the end of the probe, I have no issue to resume on a software event such as mounting my sdcard but hardware event such as card insertion and removal do not trigger a resume. It seems there are only two sdhci drivers using runtime pm so maybe nobody has noticed this issue. Regards Ludovic drivers/mmc/host/sdhci-of-at91.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index 9cb86fb..ae24dea 100644 --- a/drivers/mmc/host/sdhci-of-at91.c +++ b/drivers/mmc/host/sdhci-of-at91.c @@ -210,8 +210,6 @@ static int sdhci_at91_probe(struct platform_device *pdev) if (ret) goto pm_runtime_disable; - pm_runtime_put_autosuspend(&pdev->dev); - return 0; pm_runtime_disable: